Version: 3.0 (using KDE 3.1.93 (CVS >= 20031028), compiled sources) Compiler: gcc version 3.2.1 OS: Linux (i686) release 2.4.22-ck2 when editing rich text style notes, Ctrl+B, Ctrl+U and Ctrl+I are not working as expected. Keyboard shortcuts for these actions can't be defined. This is definately a must-have :-)
> CVS commit by brade: > > The rest of the stuff I started in Melbourne, finally finished: > - rich text support is done (at least as good as it gets with > QTextEdit) > - finally switched to using KActions :-)) That means we also > have keyboard shortcuts for all rich text actions. > CCMAIL: 68031-done@bugs.kde.org What's wrong with that..? > - used a real KToolBar, port to XMLGUI still missing > > > M +54 -31 knote.cpp 1.95 > M +6 -5 knote.h 1.31 > M +125 -143 knoteedit.cpp 1.34 > M +15 -36 knoteedit.h 1.21
I also can't get those shortcuts to work. Besides, my "Configure Shortcuts" dialog (the one that appears when you right click on the knotes dock icon) only displays "New Note" and "New Note From Clipboard", no rich text stuff.
CVS commit by brade: Ouch, sorry, I commented out one important line, dunno why. Shortcuts should work again. Configuring them is on my TODO list. CCMAIL: 68031@bugs.kde.org M +1 -2 knote.cpp 1.116 M +8 -8 knoteedit.cpp 1.45 --- kdepim/knotes/knote.cpp #1.115:1.116 @@ -81,6 +81,5 @@ KNote::KNote( KXMLGUIBuilder* builder, Q setAcceptDrops( true ); - - //actionCollection()->setWidget( this ); + actionCollection()->setWidget( this ); // if there is no title yet, use the start date if valid --- kdepim/knotes/knoteedit.cpp #1.44:1.45 @@ -72,11 +72,11 @@ KNoteEdit::KNoteEdit( QWidget *parent, c // create the actions modifying the text format - m_textBold = new KToggleAction( i18n("&Bold"), "text_bold", CTRL + Key_B, 0, 0, + m_textBold = new KToggleAction( i18n("Bold"), "text_bold", CTRL + Key_B, 0, 0, actions, "format_bold" ); - m_textItalic = new KToggleAction( i18n("&Italic"), "text_italic", CTRL + Key_I, 0, 0, + m_textItalic = new KToggleAction( i18n("Italic"), "text_italic", CTRL + Key_I, 0, 0, actions, "format_italic" ); - m_textUnderline = new KToggleAction( i18n("&Underline"), "text_under", CTRL + Key_U, 0, 0, + m_textUnderline = new KToggleAction( i18n("Underline"), "text_under", CTRL + Key_U, 0, 0, actions, "format_underline" ); - m_textStrikeOut = new KToggleAction( i18n("&Strike Out"), "text_strike", CTRL + Key_S, 0, 0, + m_textStrikeOut = new KToggleAction( i18n("Strike Out"), "text_strike", CTRL + Key_S, 0, 0, actions, "format_strikeout" ); @@ -86,15 +86,15 @@ KNoteEdit::KNoteEdit( QWidget *parent, c connect( m_textStrikeOut, SIGNAL(toggled(bool)), SLOT(textStrikeOut(bool)) ); - m_textAlignLeft = new KToggleAction( i18n("Align &Left"), "text_left", CTRL + Key_L, + m_textAlignLeft = new KToggleAction( i18n("Align Left"), "text_left", ALT + Key_L, this, SLOT(textAlignLeft()), actions, "format_alignleft" ); m_textAlignLeft->setChecked( true ); // just a dummy, will be updated later - m_textAlignCenter = new KToggleAction( i18n("Align &Center"), "text_center", CTRL + ALT + Key_C, + m_textAlignCenter = new KToggleAction( i18n("Align Center"), "text_center", ALT + Key_C, this, SLOT(textAlignCenter()), actions, "format_aligncenter" ); - m_textAlignRight = new KToggleAction( i18n("Align &Right"), "text_right", CTRL + ALT + Key_R, + m_textAlignRight = new KToggleAction( i18n("Align Right"), "text_right", ALT + Key_R, this, SLOT(textAlignRight()), actions, "format_alignright" ); - m_textAlignBlock = new KToggleAction( i18n("Align &Block"), "text_block", CTRL + Key_J, + m_textAlignBlock = new KToggleAction( i18n("Align Block"), "text_block", ALT + Key_B, this, SLOT(textAlignBlock()), actions, "format_alignblock" );
CVS commit by brade: fixed #68031, #81888: configuring shortcuts is possible now and changes are preserved between several KNotes sessions. All possible interactions with KNotes can have custom shortcuts, there are no hidden features anymore. Good thing is that one can configure global and application shortcuts all in one dialog. Again, even less code needed and somewhat better design. After bugging David a thousand times about this and that, being told that some things are impossible, I found a better way and did it differently altogether, but it was fun talking to David anyway ;-> I almost reached my goal for aKademy: 0 bugs left for KNotes; one real bug is left, although this affects Kontact and KNotes, the other one I will fix in a bit. Thus, I'd say only 0.5 bugs left ;) CCMAIL: 81888-done@bugs.kde.org, 68031@bugs.kde.org M +7 -0 ChangeLog 1.89 M +8 -10 knote.cpp 1.133 M +1 -1 knote.h 1.45 M +67 -57 knotesapp.cpp 1.98 M +1 -1 knotesapp.h 1.41