Bug 67689 - textposition of bookmark toolbar not saved
Summary: textposition of bookmark toolbar not saved
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 67743 71095 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-11-09 18:25 UTC by Kai Lahmann
Modified: 2004-03-23 02:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Lahmann 2003-11-09 18:25:14 UTC
Version:            (using KDE Devel)

I try to use the konqueror bookmark toolbar with "icons only", but I need to set that manually every time, I open a new window, because this behavior isn't save anywhere, not even in a manual saved session.
Comment 1 Oded Arbel 2003-11-09 19:33:11 UTC
Indeed none of the toolbar manipulation options for any toolbar survives opening a new window or closing the current one and then opening a new window. that includes changing icon sizes and location, collapsing("flattening") a toolbar, changing toolbar location/orientation, floating a toolbar and adding or removing a toolbar.

Using current CVS HEAD (3.1.93 and a bit)
Comment 2 Oded Arbel 2003-11-09 19:35:27 UTC
Note - configuration is being saved if I use "Settings->save profile" and overwrite the "webbrowsing" profile. 
maybe this is a feature ?
Comment 3 Osho GG 2003-12-02 21:08:33 UTC
Hi,

FYI: There seems to be a duplicate of this bug at 67743.

http://bugs.kde.org/show_bug.cgi?id=67743

We can close the other bug (I am the reporter of that bug -  6743) and combine the votes of them both.

Osho
Comment 4 Osho GG 2003-12-09 08:18:45 UTC
Hi,

I can confirm that this bug is present in 3.1.94 (3.2 beta2).

Osho
Comment 5 Tommi Tervo 2004-01-06 21:53:13 UTC
*** Bug 67743 has been marked as a duplicate of this bug. ***
Comment 6 Tommi Tervo 2004-01-06 22:02:54 UTC
*** Bug 71095 has been marked as a duplicate of this bug. ***
Comment 7 A.P.C. 2004-01-07 01:44:01 UTC
I agree that my bug report #71095 is a dup (never saw this current one)....but the difference that I experienced compared to this one is that even maually saving and overwriting the "webbrowsing" profile still had no effect after logging out or rebbooting. But I am sure it is still basically the same bug nonetheless.

Cap
Comment 8 Klas Kalass 2004-03-22 19:43:07 UTC
CVS commit by kalass: 

if not hasDefault ; then 
  restoreToDefault

simply does not make sense :-)  

Fixes wrong optimization of default values

CCMAIL: 67689-done@bugs.kde.org


  M +6 -6      ktoolbar.cpp   1.369.2.2


--- kdelibs/kdeui/ktoolbar.cpp  #1.369.2.1:1.369.2.2
@@ -1122,5 +1122,5 @@ void KToolBar::saveSettings(KConfig *con
     KConfigGroupSaver saver(config, configGroup);
 
-    if(!config->hasDefault("Position") && position == d->PositionDefault )
+    if(config->hasDefault("Position") && position == d->PositionDefault )
       config->revertToDefault("Position");
     else
@@ -1129,5 +1129,5 @@ void KToolBar::saveSettings(KConfig *con
     //kdDebug(220) << name() << "                icontext=" << icontext << " hasDefault:" << config->hasDefault( "IconText" ) << " d->IconTextDefault=" << d->IconTextDefault << endl;
 
-    if(!config->hasDefault("IconText") && icontext == d->IconTextDefault )
+    if(config->hasDefault("IconText") && icontext == d->IconTextDefault )
     {
       //kdDebug(220) << name() << "                reverting icontext to default" << endl;
@@ -1140,10 +1140,10 @@ void KToolBar::saveSettings(KConfig *con
     }
 
-    if(!config->hasDefault("IconSize") && iconSize() == d->IconSizeDefault )
+    if(config->hasDefault("IconSize") && iconSize() == d->IconSizeDefault )
       config->revertToDefault("IconSize");
     else
       config->writeEntry("IconSize", iconSize());
 
-    if(!config->hasDefault("Hidden") && isHidden() == d->HiddenDefault )
+    if(config->hasDefault("Hidden") && isHidden() == d->HiddenDefault )
       config->revertToDefault("Hidden");
     else
@@ -1162,10 +1162,10 @@ void KToolBar::saveSettings(KConfig *con
     config->writeEntry("Index", index);
 
-    if(!config->hasDefault("Offset") && offset() == d->OffsetDefault )
+    if(config->hasDefault("Offset") && offset() == d->OffsetDefault )
       config->revertToDefault("Offset");
     else
       config->writeEntry("Offset", offset());
 
-    if(!config->hasDefault("NewLine") && newLine() == d->NewLineDefault )
+    if(config->hasDefault("NewLine") && newLine() == d->NewLineDefault )
       config->revertToDefault("NewLine");
     else


Comment 9 Osho GG 2004-03-23 02:23:31 UTC
I applied this patch against KDE 3.2.1 sources and recompiled kdelibs. I can confirm that the bug is fixed with this patch.

Many many thanks Klas.
Osho