Bug 67607 - Cannot build rpms from source tarball, spec file needs changes
Summary: Cannot build rpms from source tarball, spec file needs changes
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-08 18:56 UTC by Matthew Truch
Modified: 2003-11-11 22:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix spec file (1.18 KB, patch)
2003-11-08 19:00 UTC, Matthew Truch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Truch 2003-11-08 18:56:30 UTC
Version:           0.94 (using KDE KDE 3.1)
Installed from:    RedHat RPMs
OS:          Linux

when using the command rpmbuild -ta kst-0.94.tar.gz, rpmbuild fails at the end, as there are some 'unpackaged files.'  Appropriate entries need to be added to the %files section of the spec file.
Comment 1 Matthew Truch 2003-11-08 19:00:09 UTC
Created attachment 3081 [details]
Patch to fix spec file

The attached patch adds appropriate file entries.  It also sets the %defattr so
all files are installed with owner:group of root:root, and does an ldconfig
after install and removal (so libkst.so.1 for example, can be found after a
user installs kst for the first time).
Comment 2 Thiago Macieira 2003-11-09 04:58:30 UTC
Recommendation: remove the .spec file from the source-code .tar.gz. Distributions make each their own SPECs for their own system, with their own specificities. A KDE program cannot hope to make one .spec to work in every distribution.
Comment 3 Matthew Truch 2003-11-10 23:54:34 UTC
I don't think that removing the spec file makes any sense.  Distributions *do* make their own spec filess, and will ignore any spec that comes with the tarball.  But having a spec file that works for other people (whose distribution doesn't yet package kst....I don't think that many distros include kst yet) is a good thing.  

Also, the changes made above had nothing to do with tweaks for a specific distro, but for making the spec file complete (ie, the spec file must list all files installed during the install phase, a few of which were previously omitted).  
Comment 4 George Staikos 2003-11-11 22:45:00 UTC
Subject: kdeextragear-2/kst

CVS commit by staikos: 

add more files to the rpm

CCMAIL: 67607-done@bugs.kde.org


  M +15 -0     kst.spec.in   1.16


--- kdeextragear-2/kst/kst.spec.in  #1.15:1.16
@@ -14,4 +14,6 @@
 BuildRoot: /var/tmp/kst-%{version}.root
 
+Requires(post,postun): /sbin/ldconfig
+
 %description
 A data viewing application for KDE.
@@ -28,4 +30,5 @@
 
 %files
+%defattr(-,root,root)
 #binaries
 %prefix/bin/kst
@@ -44,4 +47,14 @@
 %prefix/share/services/kst/kstdata_planck.desktop
 %prefix/lib/kde3/kstdata_planck.so
+%prefix/include/kstdatasource.h
+%prefix/include/kstobject.h
+%prefix/lib/kde3/kstdata_ascii.la
+%prefix/lib/kde3/kstdata_dirfile.la
+%prefix/lib/kde3/kstdata_frame.la
+%prefix/lib/kde3/kstdata_indirect.la
+%prefix/lib/kde3/kstdata_planck.la
+%prefix/lib/libkst.la
+%prefix/share/servicetypes/kst/kstdatasourceplugin.desktop
+%prefix/share/servicetypes/kst/kstplugin.desktop
 # UI file
 %prefix/share/apps/kst/kstui.rc
@@ -74,5 +87,7 @@
 
 %post
+/sbin/ldconfig
 
 %postun
+/sbin/ldconfig