Bug 67523 - isReachable() is not called when clicking on the contact icon
Summary: isReachable() is not called when clicking on the contact icon
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Main Application (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-07 19:38 UTC by Matt Rogers
Modified: 2004-01-18 16:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Fix isReachable mostly (4.68 KB, patch)
2004-01-02 02:00 UTC, Martijn Klingens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rogers 2003-11-07 19:38:58 UTC
Version:           0.7.93 (using KDE Devel)
Installed from:    Compiled sources
Compiler:          GCC 3.3.2 
OS:          Linux

When clicking on the protocol icon for a metacontact, isReachable() doesn't appear to be called. 

For example, I have a metacontact named foobar and foobar has a yahoo contact, an msn contact and and AIM contact associated with it. If i click on the msn contact, the chatwindow opens and the dialog is displayed that says this person is offline (See bug 64918 for an exact error message) and so the dialog that is supposed to get displayed doesn't because then we're not working with metacontacts, but individual protocol contacts.

Hopefully this is descriptive enough.
Comment 1 Olivier Goffart 2003-11-08 10:05:46 UTC
I Know i'ts a bug, but i like this feature^W^WBug

personaly, i like to be ableto open chat window even for offline people.
for some reason such as consulting quickly the history, or see if this people did not blocked me (MSN).
Comment 2 Stefan Gehn 2003-11-08 18:10:46 UTC
And that makes clear: History has nothing to do inside a real chatwindow.
Comment 3 Martijn Klingens 2004-01-02 02:00:21 UTC
Created attachment 3923 [details]
Fix isReachable mostly

Please review.

This fixes all cases of isReachable that I encountered during use. There's one
drag-and-drop issue not fixed, but I consider that not important enough for KDE
3.2 -- I even doubt many people will ever notice the bug there.

See the FIXME in KopeteContact.h for the 'real' fix post 3.2, but for now this
should do.

Note 1: The diff is -bBw to exclude whitespace changes for readability. Obvious
side effect is messed up indentation though :)

Note 2: The i18n strings are copied from the meta contact and thus legal to
add.

Martijn
Comment 4 Olivier Goffart 2004-01-02 10:55:00 UTC
I'm against the test in KopeteContact::execute() .
I still want to be able to open chat window with offline msn contact for example.

Sighor objected for the patch to forbeid to open a chat with myslef, i object now :-D


Anyway all other FIXME and small code are fine.
Comment 5 Martijn Klingens 2004-01-02 13:27:12 UTC
Subject: Re: [Kopete-devel]  isReachable() is not called when clicking on the contact icon

On Friday 02 January 2004 10:55, Olivier Goffart wrote:
> I'm against the test in KopeteContact::execute() .
> I still want to be able to open chat window with offline msn contact for
> example.

For debugging it's indeed useful, but that's only for us developers. It is 
really a bug for everyone else.

What about adding an extra option 'Force Start Chat' when compiling with 
--enable-debug?

Comment 6 Olivier Goffart 2004-01-02 13:42:44 UTC
No, i use it in msn for example to know if the persone is realy offline (did not blocked me)
and also to vew the few last messages in the history (even if i could use the real history window for that)
Comment 7 Martijn Klingens 2004-01-02 14:23:31 UTC
Subject: Re: [Kopete-devel]  isReachable() is not called when clicking on the contact icon

On Friday 02 January 2004 13:42, Olivier Goffart wrote:
> No, i use it in msn for example to know if the persone is realy
> offline (did not blocked me) and also to vew the few last messages in the
> history (even if i could use the real history window for that)

That sounds like two usability issues that should be solved differently to me.

Why can't you use the history plugin for that?

(What we could do is show the history automatically when clicking on a blocked 
user, but that sounds a bit inconsistent to me. As for checking whether 
someone blocked you, that could e.g. go into the contact info. It doesn't 
belong here.)

Comment 8 Martijn Klingens 2004-01-18 14:53:39 UTC
Subject: kdenetwork/kopete/libkopete

CVS commit by mklingens: 

Fix bug 67523 by calling isReachable even when clicking directly on a contact.

Not suitable for backporting because some people (Hi Olivier :) abuse this
feature for viewing recent history and to detect blocking status. With this
only in HEAD it encourages them to find a proper solution.

CCMAIL: 67523-done@bugs.kde.org


  M +22 -10    kopetecontact.cpp   1.166
  M +4 -0      kopetecontact.h   1.120
  M +10 -8     kopetemetacontact.cpp   1.198



Comment 9 Olivier Goffart 2004-01-18 16:26:21 UTC
> and to detect blocking status.

Euh, it seems microsoft™ fixed his server yesterday. Detecting if someone blocked us does not work anymore :-(