Bug 66651 - Alarms triggered for completed To-do's
Summary: Alarms triggered for completed To-do's
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Cornelius Schumacher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-26 21:42 UTC by Tristan Miller
Modified: 2004-03-02 19:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2003-10-26 21:42:00 UTC
Version:            (using KDE KDE 3.1.4)
Installed from:    SuSE RPMs

Steps to reproduce problem:

1. Create a new To-do with a reminder.
2. Mark the To-do as completed by clicking on its checkbox.
3. At the designated time, the reminder pops up anyway.

Since people add reminders to To-do's to remind them to do the To-do, it seems rather pointless to raise the alarm for completed To-do's.  KOrganizer should suppress reminders for completed To-do's, or at least make this the default behaviour and give the user the choice of overriding it when creating the To-do.
Comment 1 Reinhold Kainhofer 2004-03-02 19:03:28 UTC
CVS commit by kainhofe: 

Don't show alarms for completed todo items.

CCMAIL: 66651-done@bugs.kde.org


  M +1 -1      calendarlocal.cpp   1.57


--- kdepim/libkcal/calendarlocal.cpp  #1.56:1.57
@@ -202,5 +202,5 @@ Alarm::List CalendarLocal::alarms( const
   Todo::List::ConstIterator it2;
   for( it2 = mTodoList.begin(); it2 != mTodoList.end(); ++it2 ) {
-    appendAlarms( alarms, *it2, from, to );
+    if (! (*it2)->isCompleted() ) appendAlarms( alarms, *it2, from, to );
   }