Bug 66377 - Ignore-List in buildtools/qmake/filebuffer.cpp messes up parsing of .pro files if $( is present in variable values
Summary: Ignore-List in buildtools/qmake/filebuffer.cpp messes up parsing of .pro file...
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KDevelop Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-22 11:43 UTC by matze
Modified: 2003-10-22 21:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description matze 2003-10-22 11:43:51 UTC 
Version:           CVS (using KDE KDE 3.1.2)
Installed from:    Compiled From Sources
Compiler:          gcc 2.95.3 
OS:          Linux

following patch fixes it, but probably has side effects:

Index: filebuffer.cpp
===================================================================
RCS file: /home/kde/kdevelop/buildtools/qmake/filebuffer.cpp,v
retrieving revision 1.32
diff -u -3 -p -r1.32 filebuffer.cpp
--- filebuffer.cpp      7 Oct 2003 20:14:15 -0000       1.32
+++ filebuffer.cpp      22 Oct 2003 09:41:21 -0000
@@ -759,7 +759,7 @@ void FileBuffer::filterOutIgnoreValues(Q
 {
   QStringList qmakeFunctions =
     QStringList::split(',',"join(,member(,find(,contains(,count(,error(,exists(,"
-                       "include(,isEmpty(,system(,message(,infile(,$(");
+                       "include(,isEmpty(,system(,message(,infile(");

   int len=0;
   int closestMatch = -1;
Comment 1 Andreas Koepfle 2003-10-22 21:00:15 UTC 
Subject: kdevelop/buildtools/qmake

CVS commit by koepfle: 

Fix parsing of pro-files with env-variables $(...)
As far as I can see this has no side effects, since env-variables aren't
evaluated by the qmake manager at the moment anyway.
thanks to matze@stud.fbi.fh-darmstadt.de for the patch

CCMAIL: 66377-done@bugs.kde.org


  M +1 -1      filebuffer.cpp   1.33


--- kdevelop/buildtools/qmake/filebuffer.cpp  #1.32:1.33
@@ -760,5 +760,5 @@ void FileBuffer::filterOutIgnoreValues(Q
   QStringList qmakeFunctions =
     QStringList::split(',',"join(,member(,find(,contains(,count(,error(,exists(,"
-                       "include(,isEmpty(,system(,message(,infile(,$(");
+                       "include(,isEmpty(,system(,message(,infile(");
 
   int len=0;