Bug 66202 - [PATCH] character count in chat window
Summary: [PATCH] character count in chat window
Status: RESOLVED INTENTIONAL
Alias: None
Product: kopete
Classification: Applications
Component: libkopete (show other bugs)
Version: 0.7.3
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
: 70777 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-10-18 13:20 UTC by Alexandre Pereira
Modified: 2009-07-23 15:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
icq sms character count (2.06 KB, patch)
2003-12-01 00:37 UTC, Philip Nelson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Pereira 2003-10-18 13:20:54 UTC
Version:           0.7.3 (using KDE KDE 3.1.4)
Installed from:    Gentoo Packages
OS:          Linux

it would be nice to use a caracter counter when using the sms send plugin.

i could be nice for all protocols,but specially for the sms send. (like 1rstwap window counts the caracters as we are typping , to know if its more than 160 or not )

the counter could be somewhere in the window , where it would not use much space ( to the left of the send button or to the right of the button that spins when a message is being sent )
Comment 1 Olivier Goffart 2003-10-18 13:28:40 UTC
This could go in a plugin  (the SMS plugin itself?)
The plugin could show the number of char in a toolbar widget. 
Comment 2 Martijn Klingens 2003-10-18 13:31:44 UTC
Subject: Re: [Kopete-devel]  counting the caracters of the messages we are typping

On Saturday 18 October 2003 13:28, Olivier Goffart wrote:
> The plugin could show the number of char in a toolbar widget.

Status bar you mean I guess, the toolbar is not meant for that.

Comment 3 Stefan Gehn 2003-10-18 18:54:36 UTC
We have no real statusbar in our chatwindow
Comment 4 Martijn Klingens 2003-10-18 19:59:12 UTC
Subject: Re: [Kopete-devel]  counting the caracters of the messages we are typping

On Saturday 18 October 2003 18:54, Stefan Gehn wrote:
> We have no real statusbar in our chatwindow

Hmm? Where do the typing notifications go then???

Comment 5 Stefan Gehn 2003-10-18 20:40:41 UTC
Into an ugly handmade widget, it's NOT a KStatusBar and it doesn't behave like one either (no sunken border + it contains a button).
Comment 6 Martijn Klingens 2003-10-18 20:52:01 UTC
Subject: Re: [Kopete-devel]  counting the caracters of the messages we are typping

On Saturday 18 October 2003 20:40, Stefan Gehn wrote:
> it contains a button

You can embed any widget in a KStatusBar, see KMail for an example.

I wonder what the reasoning behind this is...

Comment 7 Stefan Gehn 2003-10-18 20:59:54 UTC
Please read the ui guidelines before finding bad examples. A statusbar represents a status, the send button does not fit into that.
And yes, I know the problem of "where to put the darn button". I always voted for removing it altogether but some clickety-click users got in the way :P
Comment 8 Jason Keirstead 2003-10-18 21:47:45 UTC
Subject: Re: [Kopete-devel]  counting the caracters of the messages we are typping

On October 18, 2003 08:28 am, Olivier Goffart wrote:
--- Additional Comments From ogoffart@tiscalinet.be  2003-10-18 13:28
> ------- This could go in a plugin  (the SMS plugin itself?)
> The plugin could show the number of char in a toolbar widget.

Seems to me this would be a usefull thing to have in general (other protocols
besides SMS have char limits ), would only be around 5 lines of code and a UI
change, and could easily be put in the status bar of the main window. Other clients
have this too like the official MSN  client, and official ICQ client. don't think this is
plugin material, it can easily be put right in the chat window.

Comment 9 Jason Keirstead 2003-10-18 21:51:05 UTC
Subject: Re: [Kopete-devel]  counting the caracters of the messages we are typping

On October 18, 2003 03:52 pm, Martijn Klingens wrote:

> ------- Additional Comments From klingens@kde.org  2003-10-18 20:52 -------
> Subject: Re: [Kopete-devel]  counting the caracters of the messages we are
> typping
>
> On Saturday 18 October 2003 20:40, Stefan Gehn wrote:
> > it contains a button
>
> You can embed any widget in a KStatusBar, see KMail for an example.
>
> I wonder what the reasoning behind this is...

Does everyone around here have amnesia or something? We purposely removed the
status bar and replaced it with this one around a year ago because it looked MUCH better.
A KStatusBar with a button in it looks immensly retarded. And before this the button took
up its own giant space in the window. So we did it for asthetic reasons as well as practical
ones.

Comment 10 Casey Allen Shobe 2003-10-19 03:22:03 UTC
IMHO the status bar should be standard...it's very strange and ugly now.  And buttons don't go in KStatusBar because buttons don't belong in the status bar.

But no, I don't know where the button should go at the moment.  KMail has a send button as the first toolbar button.  What's wrong with that?  Just set the default send shortcut to Enter...

BTW, to stay on topic with *this* bug, look at how kmail's statusbar works in the composer for tracking the current column.  This would be the ideal setup for Kopete with a character and word counter on the right, and a status area on the left.
Comment 11 Jason Keirstead 2003-10-19 15:41:59 UTC
The default send shortcut s not going to be enter. This has been discussed over and over again.

Not to mention multiline messages, "Send Message" in KDE is CTRL+Enter.  Either you change it in all KDE apps or you leave it as is. Just because MSN and Gaim use Enter to send does not make it a de-facto standard.
Comment 12 Casey Allen Shobe 2003-10-19 17:26:09 UTC
> The default send shortcut s not going to be enter. This has been discussed
> over and over again.

Okay, who cares?  You can still put a send icon in the toolbar.  But it would certainly cut down on the number of false bug reports.  You can still enter newlines with shift-enter.
Comment 13 Philip Nelson 2003-12-01 00:37:32 UTC
Created attachment 3484 [details]
icq sms character count

This simple patch adds a characters left counter for sending icq sms's (there
is a limit of 160 chars). This is my first go of kde/qt programming so I hope
I've done things right. (not sure if i've created the patch in the right
format, couldn't find any kopete docs on this?)
Note I deliberately did not stop the user being able to go over the 160 limit.
This is how I like it, because I will often type a message which goes over the
limit, then go back through the message taking out chars that aren't needed.
I'm sure users are clever enough to see the counter has gone negative and the
font colour is red.
Comment 14 Olivier Goffart 2004-03-12 22:26:13 UTC
*** Bug 70777 has been marked as a duplicate of this bug. ***
Comment 15 Olivier Goffart 2004-03-12 22:27:51 UTC
this is also true for MSN (which is limited to 1600)
Something should be added in libkopete (KopeteMessageManager)  to have a maximum count of char
Comment 16 Alexandre Pereira 2008-12-26 19:29:32 UTC
is anyone interested in this ?

if not , i will just mark it as wontfix , since its been a long long time since it was reported. ( and i dont use or know if there still is a sms plugin , or if for example msn still has a word limit )
Comment 17 Lapo Luchini 2009-07-23 15:55:55 UTC
Personally, I'd be interested in this, mainly when I send Twitter/Identi.CA messages over Jabber (they are restricted to 140 chars).