Bug 65210 - Location bar not updated when opening new tab with Ctrl+Enter
Summary: Location bar not updated when opening new tab with Ctrl+Enter
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: tabbing (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-30 00:57 UTC by Philippe Rigault
Modified: 2003-11-14 14:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Example 1 (location bar not updated) (138.13 KB, image/png)
2003-09-30 00:58 UTC, Philippe Rigault
Details
Example 2 (correct behaviour) (194.47 KB, image/png)
2003-09-30 00:59 UTC, Philippe Rigault
Details
Example 3 (url-B = www.cnn.com) (347.77 KB, image/png)
2003-09-30 01:03 UTC, Philippe Rigault
Details
Before the problem(1) (276.59 KB, image/png)
2003-11-09 03:18 UTC, Philippe Rigault
Details
Before the problem(2) (276.59 KB, image/png)
2003-11-09 03:20 UTC, Philippe Rigault
Details
OOPS, forget #7. (270.61 KB, image/png)
2003-11-09 03:23 UTC, Philippe Rigault
Details
The problem (303.23 KB, image/png)
2003-11-09 03:46 UTC, Philippe Rigault
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Rigault 2003-09-30 00:57:16 UTC
Version:            (using KDE KDE 3.1.92)
Installed from:    Compiled From Sources
Compiler:          GCC 3.3.1 
OS:          Linux

This bug has been there since KDE 3.1.3 (reintroduction of Ctrl+Enter) and is still present in 3.1.92.

Opening a new tab with Ctrl+Enter requires setting the option 'Open links in new tab instead of in new window'. It is done by:
1. Opening a location (url-A) into the current window/tab (tab-A) 
2. Typing a new location (url-B) in the location bar, followed by Ctrl+Enter

The correct behaviour is:
	- a new tab is created with url-B loaded into it
	- the new tab (url-B) is activated
	- the location bar is updated to that of the current tab (url-B)

The problem is that the current behaviour is inconsistent, and depends on the URL opened in the new tab (url-B). The following may happen:
	- the location bar may or may not be updated
	- the new tab may or may not look as activated

I am including three examples to illustrate the problem
(all examples have url-A = www.kde.org)

1. url-B  = www.kdevelop.org
    In this case, the tab (url-B) is shown as active, but the location bar is NOT updated (still shows that of url-A)
2. url-B = bugs.kde.org
    This case is fine (tab is shown as active, location bar is updated to url-B)
2. url-B = www.cnn.com
    In this case, the tab is NOT shown as active and the location bar is NOT updated (still shows that of url-A)
Comment 1 Philippe Rigault 2003-09-30 00:58:59 UTC
Created attachment 2633 [details]
Example 1 (location bar not updated)
Comment 2 Philippe Rigault 2003-09-30 00:59:59 UTC
Created attachment 2634 [details]
Example 2 (correct behaviour)
Comment 3 Philippe Rigault 2003-09-30 01:03:02 UTC
Created attachment 2635 [details]
Example 3 (url-B = www.cnn.com)

Two things on this one:
	- Location bar not updated (still shows http://www.kde.org)
	- The tab itself does not look active, it is greyed out. The font on
the tab should be normal (black)
Comment 4 Stephan Binner 2003-11-08 23:50:00 UTC
> Opening a new tab with Ctrl+Enter requires setting the option 'Open links in new tab instead of in new window'.

This statement is wrong. But I see some problems with Ctrl+Enter.
Comment 5 Philippe Rigault 2003-11-09 03:14:37 UTC
>Opening a new tab with Ctrl+Enter requires setting the option 'Open links in new
> tab instead of in new window'. It is done by: 
I (very unclearly) meant to say: "To reproduce the bug, do this:"

The problem of location bar update that was present in 3.1.92 is apparently solved on 3.1.93.
However, there are new problems now, with website icons. Now I see that:
  - url-B tab is all right (location bar + website icon)
  - url-A tab lost its website icon.
Attachments to follow.
Comment 6 Philippe Rigault 2003-11-09 03:18:10 UTC
Created attachment 3092 [details]
Before the problem(1)

Url-A=www.kde.org
unchecked: Hide tab bar when only one tab is open
(Before tying url-B + Ctrl-Enter)
Comment 7 Philippe Rigault 2003-11-09 03:20:15 UTC
Created attachment 3093 [details]
Before the problem(2)

Url-A=www.kde.org 
CHECKED: Hide tab bar when only one tab is open 
 (Before tying url-B + Ctrl-Enter)
Comment 8 Philippe Rigault 2003-11-09 03:23:50 UTC
Created attachment 3094 [details]
OOPS, forget #7.

Before the problem(2) 
 
 Url-A=www.kde.org 
 CHECKED: Hide tab bar when only one tab is open 
 (Before tying url-B + Ctrl-Enter)
Comment 9 Philippe Rigault 2003-11-09 03:46:39 UTC
Created attachment 3095 [details]
The problem

Url-B=www.slashdot.org
typed url-B + Ctrl-Enter
Tab-B is fine (location + website icon)
Two problems here:
 - Location bar has wrong website icon
 - Tab-A has lost its website icon and has a wrong one now
Note that wrong website icon has nothing to do with url-A OR url-B

PS: I just realized that I should have swapped 'checked' and 'unchecked' in
comments #6 and #8 (Hide tab bar...). Too much caffeine today :-(
Comment 10 Stephan Binner 2003-11-14 14:59:32 UTC
I think it works now fine with CVS HEAD with today's commits. Please try next Beta.