Bug 64490 - Need patch to compile on RH9 __swab16 undefined
Summary: Need patch to compile on RH9 __swab16 undefined
Status: RESOLVED FIXED
Alias: None
Product: kdemultimedia
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Multimedia Developers
URL:
Keywords:
: 65063 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-09-18 13:36 UTC by Neal Becker
Modified: 2003-11-23 05:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Becker 2003-09-18 13:36:38 UTC
Version:            (using KDE KDE 3.1.4)
Installed from:    Compiled From Sources
OS:          Linux

Twisty maze of include files.  I don't know why, but

mpeglib/lib/input/httpInputStream.cpp

won't compile unless I add:
#include <netinet/in.h>
#undef _LINUX_BYTEORDER_SWAB_H
#include <linux/byteorder/swab.h>

Somehow, _LINUX_BYTEORDER_SWAB_H had gotten defined, preventing the definition of __swab16.
Comment 1 Neal Becker 2003-09-18 13:59:24 UTC
OH, here's the cause of the problem! 
 
It's cdromAccess_Linux.cpp: 
#define _LINUX_BYTEORDER_SWAB_H 
 
 
I don't know why this is here, but it's gotta go.  I haven't tested yet 
whether it can simply be removed or if a different fix is required, but this 
is just wrong. 
Comment 2 Matthias Kretz 2003-09-18 14:25:12 UTC
Subject: Re:  Need patch to compile on RH9 __swab16 undefined

This is because of swab.h using broken code in newer kernel versions so that 
compilation fails without it. But this should not have been put in there 
unguarded and has already been removed again. Both KDE_3_1_BRANCH and HEAD 
are fine.

On Thursday September 18 2003 13:59, nbecker@fred.net wrote:
> OH, here's the cause of the problem!
>
> It's cdromAccess_Linux.cpp:
> #define _LINUX_BYTEORDER_SWAB_H
>
>
> I don't know why this is here, but it's gotta go.  I haven't tested yet
> whether it can simply be removed or if a different fix is required, but
> this is just wrong.

Comment 3 Olu 2003-10-01 07:50:23 UTC
I am having the same problem with RH9. How do I solve it?
Comment 4 Rex Dieter 2003-10-01 14:20:49 UTC
Subject: Re:  Need patch to compile on RH9 __swab16 undefined   
      

On 1 Oct 2003, Olu wrote:

> ------- Additional Comments From oakins2@umbc.edu  2003-10-01 07:50 -------
> I am having the same problem with RH9. How do I solve it?

Build without --enable-final

-- Rex

Comment 5 Neal D. Becker 2003-10-01 14:46:13 UTC
Subject: Re:  Need patch to compile on RH9 __swab16 undefined

On Wednesday 01 October 2003 08:20 am, Rex Dieter wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=64490
>
>
>
>
> ------- Additional Comments From rdieter@math.unl.edu  2003-10-01 14:20
> ------- Subject: Re:  Need patch to compile on RH9 __swab16 undefined
>
> On 1 Oct 2003, Olu wrote:
> > ------- Additional Comments From oakins2@umbc.edu  2003-10-01 07:50
> > ------- I am having the same problem with RH9. How do I solve it?
>
> Build without --enable-final
>
 
Are you sure?  The problem was caused by erroneously #defining the guard used 
by a header file.

Comment 6 Rex Dieter 2003-10-01 15:39:30 UTC
Removing --enable-final worked for me. 
Comment 7 Olu 2003-10-02 01:32:05 UTC
Thanks. It worked
Comment 8 Thiago Macieira 2003-11-23 05:34:10 UTC
*** Bug 65063 has been marked as a duplicate of this bug. ***