Bug 63399 - Context menu for 'New Folder...' is confusing on 'Searches' folder
Summary: Context menu for 'New Folder...' is confusing on 'Searches' folder
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: search (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-29 06:12 UTC by Tom Collins
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Collins 2003-08-29 06:12:09 UTC
Version:           1.5.9 (using KDE 3.1.9)
Compiler:          gcc version 3.2.3 20030422 (Gentoo Linux 1.4 3.2.3-r1, propolice)
OS:          Linux (i686) release 2.6.0-test4

The context menu for the 'Searches' folder in 
CVS KMail has an entry for 'New Folder...' which 
doesn't work as expected.  When this is selected,
the normal KMail Create Subfolder dialog appears,
and a new folder can be created.  However, the
new folder cannot be created under 'Searches',
which is inconsistent with how this menu item 
works when right-clicked on other folders.

I suggest this menu item be removed, and replaced
with a 'New Search Folder...' menu item, which 
invokes the search-in-folders dialog.  After all,
if the user wants a new folder underneath 'Searches',
that's the only way to create it.
Comment 1 Ingo Klöcker 2003-08-31 19:46:11 UTC
that's more a bug than a wish 
Comment 2 Don Sanders 2003-12-03 12:53:55 UTC
Subject: kdepim/kmail

CVS commit by sanders: 

Trivial fix 63399
CCMAIL:63399-done@bugs.kde.org


  M +8 -4      kmfoldertree.cpp   1.273


--- kdepim/kmail/kmfoldertree.cpp  #1.272:1.273
@@ -959,4 +959,5 @@ void KMFolderTree::slotContextMenuReques
     if (!fti->folder()) createChild = i18n("&New Folder...");
 
+    if (fti->folder() || (fti->text(0) != i18n("Searches")))
     folderMenu->insertItem(SmallIcon("folder_new"),
                            createChild, this,
@@ -977,5 +979,7 @@ void KMFolderTree::slotContextMenuReques
                                i18n("&Send Queued Messages"), mMainWidget,
                                SLOT(slotSendQueued()));
-    if (!fti->folder()->isSystemFolder() || fti->folder()->folderType() == KMFolderTypeImap)
+    if ((!fti->folder()->isSystemFolder() && 
+         (fti->folder()->folderType() != KMFolderTypeSearch)) ||
+        fti->folder()->folderType() == KMFolderTypeImap)
     {
       folderMenu->insertItem(SmallIcon("folder_new"),