Bug 62919 - reply all should not use From when ReplyTo is set (except for mailing list messages)
Summary: reply all should not use From when ReplyTo is set (except for mailing list me...
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-18 23:10 UTC by Bernd Paysan
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Paysan 2003-08-18 23:10:05 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.2.1 
OS:          Linux

According to RFC822, a ReplyTo field supercedes a From field when replying to (the From: field is to be ignored then). Kmail does so when replying to a message, but not when doing ReplyAll. Basically, there's a little "else" missing in kmmessage.cpp, line 1002.

Note that the From-field may be generated by the mail agent, and set to some self-choosen user name @ dial-up domain, and can't be replied to.

--- kmmessage.cpp.orig  2003-08-18 23:05:22.000000000 +0200
+++ kmmessage.cpp       2003-08-18 23:05:59.000000000 +0200
@@ -999,7 +999,7 @@
       recipients += splitEmailAddrList( replyToStr );
 
     // add From address to the list of recipients if it's not already there
-    if( !from().isEmpty() )
+    else if( !from().isEmpty() )
       if( !addressIsInAddressList( from(), recipients ) ) {
         recipients += from();
         kdDebug(5006) << "Added " << from() << " to the list of recipients"
Comment 1 Ingo Klöcker 2003-08-18 23:42:31 UTC
In theory this is correct, but in reality you want Reply All to use the From if you reply to a 
mailing list message with a mangled Reply-to header (unfortunately all KDE mailing lists 
mangle the Reply-to header). 
So if we wanted to fix this problem then we would have to check whether the Reply-to was set 
by some mailing list software and only omit the From address in case the Reply-to wasn't 
mangled by a mailing list. 
 
I downgrade the severity to wishlist because KMail does behave the way it does behave for a 
reason and not because it's buggy. 
Comment 2 Ingo Klöcker 2004-02-01 14:36:59 UTC
This should be fixed as far as possible in KDE 3.2.1 (meaning that KMail now tries to figure out whether the reply-to was set by a mailing list or not).

If you notice further problems with KDE 3.2.1 (or with the current version of KMail from KDE_3_2_BRANCH if you don't want to wait for KDE 3.2.1) then please reopen this bug report and provide an example.