Version: 3.1.3 (using KDE KDE 3.1.3) Installed from: SuSE RPMs OS: Linux I understand the Bookmarks menu appearing in the Kmenu if enabled and in Konqueror and other places, but I don't see why it is in the context menu that comes up when right clicking on the desktop. It doesen't seem to belong there at all just as Run Command. You may say for coninience, but not everyone with KDE uses Konqueror and furhtermore, they can cess the bookmarks form other places and open Konqueror from the panel, from run, fromt eh desktop, from just about anywhere so this isn't justified. In the interest of making KDE easier to use, I full heartedly think it should be removed.
Just looked over KDE 3 and I can't help but be impressed. There has been a big improvement in the desktop context menu. Check out this screenshot of KDE 3: http://www.kde-look.org/content/preview.php?file=4030-1.jpg The context menu was a lot worse back then as was almost everything, I never knew there was so much improvement before I used KDE 3 today and saw the difference.
Bookmarks *are* in desktop's context menu. Whats the problem?
They don't belong there!
*** This bug has been confirmed by popular vote. ***
"*** This bug has been confirmed by popular vote. *** " What is the threshold for this automated message to appear? Also, does it have any other significance?
Oh and I still think context menus should be context sensitive and have 7 or less items. They should only include options that matter for their purpose. If people want to add illogical items (in the context of the menu) they should just create their own service menus. And I also think toolbars should *ONLY* have the most commonly used functions.
I created a patch for bug #11371 that also solves this problem. Assuming it is committed, this bug is now resolved.
Sorry, I meant Bug #92789, it was Attachment #11371 [details]!
Fantastic, thank you!
On Thursday 09 June 2005 08:08, Boudewijn Rempt wrote: > On Wednesday 08 June 2005 02:18, Luke Alan Sandell wrote: > > As an added bonus, I have included a fix for Bug #62791 in > > the same patch, meaning that the Bookmarks submenu is no longer present in > > the context menu (thank God!). > > And that's good? I've read the bug report and to me it's a typical example of > "I don't the feature so it must be superfluous and should be removed." type > of report. Well, time to ask for users' opinion then.... does anyone here use the bookmarks in the desktop's context menu? To retrace history: they were added there so that we could get rid of the desktop menubar being on by default at some point in kde2. Having a way to directly open a bookmark from your desktop, without having to launch konqueror first, is a timer saver, much like minicli is a time saver compared to opening konsole before launching a program, or compared to launching konqueror, then going to google and then making a search. However, kicker also offers the bookmarks menu, and although I was the one who pushed for bookmarks to be in kdesktop's RMB, I admit that I'm using kicker instead for opening bookmarks. So: I don't have objections to removing the bookmarks menu from the kdesktop popup, but if enough people are against the removal, they'll have to stay. Bookmarks submenu users: speak up now :)
SVN commit 424583 by dfaure: Remove bookmarks from kdesktop RMB popup BUG: 62791 Fix bug when using "Disable desktop menu", kwin, kicker etc. weren't told about it, so some gray area remained on top of the desktop. Code taken from kcontrol/konq/desktopbehavior_impl.cpp CCBUG: 46209 M +9 -1 krootwm.cc --- trunk/KDE/kdebase/kdesktop/krootwm.cc #424582:424583 @@ -94,6 +94,7 @@ if (kapp->authorizeKAction("bookmarks")) { bookmarks = new KActionMenu( i18n("Bookmarks"), "bookmark", m_actionCollection, "bookmarks" ); + // The KBookmarkMenu is needed to fill the Bookmarks menu in the desktop menubar. bookmarkMenu = new KBookmarkMenu( KonqBookmarkManager::self(), new KBookmarkOwner(), bookmarks->popupMenu(), m_actionCollection, @@ -379,11 +380,13 @@ needSeparator = true; } +#if 0 if (bookmarks) { bookmarks->plug( desktopMenu ); needSeparator = true; } +#endif action = m_actionCollection->action("exec"); if (action) @@ -732,7 +735,12 @@ else appname.sprintf("kdesktop-screen-%d", kdesktop_screen_number); - kapp->dcopClient()->send( appname.data(), "KDesktopIface", "configure()", ""); + QByteArray data; + kapp->dcopClient()->send( appname.data(), "KDesktopIface", "configure()", data); + // for the standalone menubar setting + kapp->dcopClient()->send( "menuapplet*", "menuapplet", "configure()", data ); + kapp->dcopClient()->send( "kicker", "kicker", "configureMenubar()", data ); + kapp->dcopClient()->send( "kwin*", "", "reconfigure()", data ); }
Bug closed. Kdesktop is no more mantained.