Bug 61627 - incorrenct target in choosetargetdialog of automake manager
Summary: incorrenct target in choosetargetdialog of automake manager
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: Automake (show other bugs)
Version: git master
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: KDevelop Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-24 18:53 UTC by Simo
Modified: 2003-07-25 12:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simo 2003-07-24 18:53:53 UTC
Version:           kdevelop CVS (24.7.2003) (using KDE KDE 3.1.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc 3.2 
OS:          Linux

Changing back to active target after another target was selected in "Choose Target"-dialog causes the file(s) to be added in the wrong target. 
e.g:
1) create targets "t1" and "t2"
2) set active target "t1"
3) create file or a class
4) In "Choose Target"-dialog select "Choose another Target" and set it to "t2"
5) change your mind and add it active target: click "add new file to my active target"
... and the files will be added to "t2".

furthermore, if one has project structure like
subproj1/
subproj1/test/target1
subproj2/
subproj2/test/target2
then one can't insert any file to "target2" because both have same subproject name ("test").

a patch for both problems ( except long names with relativePath() is not desired UI behaviour? ):
71c71
<                               subprojectComboBox->insertItem ( SmallIcon ( "folder" ), spitem->subdir );
---
>                               subprojectComboBox->insertItem ( SmallIcon ( "folder" ), spitem->relativePath() );
142c142
<               if ( spitem->subdir == name )
---
>               if ( spitem->relativePath() == name )
248a249,254
>       if ( activeTargetRadioButton->isChecked() )
>       {
>               m_choosenTarget = m_widget->activeTarget();
>               m_choosenSubproject = m_widget->activeSubproject();
>       }
>

Hope it helps ;)
Comment 1 Amilcar do Carmo Lucas 2003-07-25 12:02:29 UTC
Subject: kdevelop/parts/autoproject

CVS commit by aclu: 

Fix for [Bug 61627] incorrenct target in choosetargetdialog of automake manager
Changing back to active target after another target was selected in "Choose Target"-dialog causes the file(s) to be added in the wrong target.

Thanks to  Simo <sika in iwn.fi> for the patch
CCMAIL: 61627-done@bugs.kde.org

PS. Simo next time attach a diff file because I had no clue which file should I patch ;-)


  M +5 -0      choosetargetdialog.cpp   1.12


--- kdevelop/parts/autoproject/choosetargetdialog.cpp  #1.11:1.12
@@ -247,4 +247,9 @@ void ChooseTargetDialog::slotChooseTarge
 void ChooseTargetDialog::accept ()
 {
+        if ( activeTargetRadioButton->isChecked() )
+        {
+                m_choosenTarget = m_widget->activeTarget();
+                m_choosenSubproject = m_widget->activeSubproject();
+        }
         if ( !m_choosenSubproject || !m_choosenTarget )
                 return;