Bug 60249 - Need icons for debug toolbar
Summary: Need icons for debug toolbar
Status: RESOLVED WORKSFORME
Alias: None
Product: kdevelop
Classification: Applications
Component: CPP Debugger (show other bugs)
Version: git master
Platform: RedHat Enterprise Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: KDevelop Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-22 23:41 UTC by Jon Smirl
Modified: 2003-12-17 19:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Toolbar icon makefile (14.31 KB, text/plain)
2003-06-26 03:05 UTC, Jon Smirl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Smirl 2003-06-22 23:41:15 UTC
Version:           CVS (using KDE KDE 3.1)
Installed from:    RedHat RPMs

If it's not too much trouble could you add some temporary icons for the debug tool bar. Right now all of the buttons have the same icon and I keep forgetting which is which.
Comment 1 David Faure 2003-06-23 12:24:54 UTC
Subject: Re:  New: Need icons for debug toolbar

On Sunday 22 June 2003 23:41, you wrote:
> If it's not too much trouble could you add some temporary icons for the debug tool bar. Right now all of the buttons have the same icon and I keep forgetting which is which.

Which debug toolbar? In which application? Certainly not in "kdesktop"
(which is the desktop icons...)

Comment 2 Jon Smirl 2003-06-23 16:20:46 UTC
I must have missed selecting kdevelop CVS.
Should I refile or can you move it?
Comment 3 Harald Fernengel 2003-06-23 18:05:45 UTC
Which editor are you using? 
Comment 4 Jon Smirl 2003-06-23 18:13:47 UTC
They are missing from both the Qt and Advanced editor. When you drop down the
debug menu they are missing too, but those are probably the same icons. Icons
for "step into", "step over", "step out", etc.
Comment 5 John Birch 2003-06-26 00:57:19 UTC
 
I have the icons showing here. I can only guess that you have an install 
problem for some reason or maybe it's a style problem? What style are you 
using? Do you have anything different from default setup of kde that you can 
thing of that may cause this? 
 
Look for dbgstep.png in the install share directory. I have it in 
share/icons/kdeclassic/22x22/actions and share/icons/hicolor/22x22/actions. 
 
Comment 6 Jon Smirl 2003-06-26 01:49:41 UTC
This appears to be a problem with 'make install' the icons are in the source
tree but they are not being copied to the destination. I am running make install
as root.

About 10% of my kdevelop icons are missing.
Comment 7 Jon Smirl 2003-06-26 02:51:06 UTC
I played around with manually installing and I can't get them to work. I am on
RH9 and I have not changed any styles from the default.

The icons are not really missing, there is an icon that looks like a sheet of
paper with the lower right corner turned up in their place. 

For example I have icons for start, stop, interrupt but not step into, over, etc.
Comment 8 John Birch 2003-06-26 02:52:59 UTC
Hmm, you'll have to research this, I'm afraid, as I cannot repeat it. Here's  
some pointers though.  
  
Look in pics/toolbar/Makefile and find what "install-kde-icons" wants to  
install. Do the missing icons appear here?  
Run "make install" from this directory and see what it actually does. Does it  
say it tries to install them? What directory?  
  
These icons are 22x22. Perhaps this is the problem.  
  
I'm out of ideas now, but hope this helps :-)  
 
Comment 9 Jon Smirl 2003-06-26 02:59:18 UTC
make install does this:

make[1]: Entering directory `/home/kde3src/kdevelop/pics/toolbar'
make[1]: Nothing to be done for `install-exec-am'.
make[1]: Nothing to be done for `install-data-am'.
make[1]: Leaving directory `/home/kde3src/kdevelop/pics/toolbar'


In the makefile the tasks for install-exec-am and install-data-am are empty
Comment 10 Jon Smirl 2003-06-26 03:03:22 UTC
"install-kde-icons" does not appear in Makefile. I'll attach the makefile
Comment 11 Jon Smirl 2003-06-26 03:05:28 UTC
Created attachment 1885 [details]
Toolbar icon makefile
Comment 12 Jon Smirl 2003-06-26 05:28:33 UTC
This may be a problem with the way Redhat has put together KDE. I don't have a
kde-common directory or kde-common/admin. My only sources for am_edit are:

/usr/share/apps/kapptemplate/admin/am_edit
-- CVS source...
/home/kde3src/kdevelop/parts/appwizard/common/admin/am_edit
/home/kde3src/kdevelop/admin/am_edit

I tried poking through a bunch of the RH RPMs and I couldn't find one with
kde-common in it.

If this is the case ./configure should test for this and error out.
Comment 13 Jon Smirl 2003-07-02 23:17:26 UTC
I have confirmed this to be a problem in am_edit and 'make install'. tag_ICON()
is not detecting the string KDE_ICON = AUTO correctly.

I don't know Perl but I played around with $lookup in am_edit. Adding the '.+'
gets it into tag2 but I don't think $1 is being computed correctly. After
forcing the match the target directory was wrong too. When I manually copied
them into the tree the icons do work.

sub tag_ICON()
{
    my $lookup = '([^\s]*).+_ICON\s*=\s*([^\n]*)';
    my $install = "";
    my $uninstall = "";
                                                      
                                                    
print "tag1\n";
                                                      
                                                    
    while ($MakefileData =~ /\n$lookup/og) {
        my $destdir;
print "tag2\n";
print $1,"\n";
 
Comment 14 Jon Smirl 2003-12-17 19:56:07 UTC
This has been fixed for a long time