Version: (using KDE KDE 3.1.2) Installed from: SuSE RPMs Compiler: gcc version 3.3 20030226 (prerelease) (SuSE Linux) This is the GCC Version included as default with Suse 8.2 Pro OS: Linux I've endcoded several albums now using the ogg extraction, and I've been noticing that the encoded versions are too short, ie the last couple of seconds are missing. For most songs this isn't noticable but others it's glaringly obvious. I have only noticed this problem with .ogg files encoded with an average bit-rate of 160kps. However as I encode most of my tracks at 160kps, I don't have many I can check. I will try to encode a couple for comparison. My .ogg settings are Minimal bit rate 96kbps, Maximal bit rate 192kpbs, Average bit rate 160kbps. I found previously (earlier version) that if I didn't give it a max/min bit rate, it would encode at over 350kbs, even though I had sent an average. I get no error messages, and a side by side comparison of track length with an mp3 of the same song, shows that one song is over 4 seconds shorter. Any suggestions? I'm really happy with the audiocd extraction, it's a really cool addition to konqueror, I'd like to find out what's going wrong. If there's any more info you need, just ask, I'm not entirely sure what you'd need. Thanks David.
Can you try using cdparanoia from the command line to see if you experience similar problems? (It's likely that the bug is there in which case KDE can't do much about it.)
Ok, I'll try cdparanoia. Current version is cdparanoia III 9.8 (SuSE 8.2 Default) Sorry for the delay in replying, I've been out of the office for the past few days. I'll hopefully post an update later today, once I get hold of an audio cd to rip. Thanks David.
*** Bug 61441 has been marked as a duplicate of this bug. ***
Hi, I've just tried cdparanoia on an album I had previously ripped. Using the command 'cdparanoia -B' to batch rip the disc to hard drive. Comparison of the output '.wav' file to the previously encoded '.ogg' produced an average track length difference of about 4 seconds. Just to check, I then encoded the '.wav' files to '.ogg' using the command: 'oggenc -m 96 -M 196 -b 160 *.wav' so that I had the same parameters set. The output '.ogg' files were the same length as the input '.wav' files. I haven't tried piping the output of cdparanoia directly into oggenc, I'm not entirely sure what command to use. Do you want me to try, or is there something else you want me to try? As a side note, when I ran cdparanoia directly I discovered a track I hadn't heard before. The album is Blur's ThinkTank - limited edition, and the first track is called 'White Noise' it's not listed in the album notes, and I don't remeber hearing it on my home stereo (I'll check this evening). The track doesn't appear in konqueror using audiocd, but when ripped directly using cdparanoia, the track appears. It's about 6 min long and cdparanoia lists it as track 00. Any ideas? I'm really sorry that I'm taking up your time with a trivial bug like this one, I really wish I knew how to fix it myself. I really do appreciate everything the KDE team has put together. Thanks David.
Update, I've just tried a 'cdparanoia -Q' to get a track list and track 00 isn't listed there either. So this is likely to be either a cdparanoia bug, or one of those weird 'hidden' tracks. Just ignore me, must be the mumblings of a madman... :) Thanks David.
Another Update, I've just updated to 3.1.3 via SuSE's KDE Rpms (from Suse's site rather than KDE.org) Unfortunately, the problem still exists. I wasn't sure if any of the other bug fixes would have resolved this. Is there any more info I can provide that might be of use? Thanks David.
When ripping CD audio tracks and encoding them in Ogg Vorbis format using the audiocd protocol in Konqueror, the resulting Ogg Vorbis files are missing the last 2 - 3 seconds of each track. If the CD audio tracks are ripped as wav files and encoded manually using the Ogg Vorbis encoder (oggenc), the resulting Ogg Vorbis files are the correct length. I have the following setting set in the Ogg Vorbis tab of the Audio CDs control module: * Average Bitrate: 256 kbps * Add track information Also, when encoding the wav file manually, I ran oggenc in the following manner: oggenc -b 256 *.wav Here is the output of 'oggenc --version' and 'kde-config --version': OggEnc v1.0 (libvorbis 1.0) Qt: 3.1.2 KDE: 3.1.2 kde-config: 1.0 For reference, here is the ouput of ogginfo between several files encoded with the audiocd protocol and manually. For clarity, the files with the comment "kde-encoder=kio_audiocd" were encoded using the audiocd protocol. ===== Processing file "01 Intro.ogg"... New logical stream (#1, serial: 15346451): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... title=Intro artist=Deliverance album=What a Joke genre=misc tracknumber=1 Vorbis stream 1: Total data length: 424008 bytes Playback length: 0m:17s Average bitrate: 197.826439 kbps Logical stream 1 ended Processing file "01-Intro.ogg"... New logical stream (#1, serial: 6a213c04): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Intro artist=Deliverance album=What a Joke genre=misc tracknumber=1 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 468171 bytes Playback length: 0m:14s Average bitrate: 249.858906 kbps ===== Processing file "02 Prophet Of Idiocy.ogg"... New logical stream (#1, serial: 6860abb0): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 6770452 bytes Playback length: 3m:27s Average bitrate: 261.626277 kbps Logical stream 1 ended Processing file "02-Prophet_Of_Idiocy.ogg"... New logical stream (#1, serial: 5a4d3392): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Prophet Of Idiocy artist=Deliverance album=What a Joke genre=misc tracknumber=2 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 6633593 bytes Playback length: 3m:24s Average bitrate: 259.009098 kbps ===== Processing file "03 Pseudo Intellectual.ogg"... New logical stream (#1, serial: 6860abb1): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 14185565 bytes Playback length: 7m:15s Average bitrate: 260.652263 kbps Logical stream 1 ended Processing file "03-Pseudo_Intellectual.ogg"... New logical stream (#1, serial: 1853930e): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Pseudo Intellectual artist=Deliverance album=What a Joke genre=misc tracknumber=3 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 13921027 bytes Playback length: 7m:13s Average bitrate: 257.088599 kbps ===== Processing file "04 Cheeseburger Make Du.ogg"... New logical stream (#1, serial: 6860abb2): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 211291 bytes Playback length: 0m:08s Average bitrate: 203.164423 kbps Logical stream 1 ended Processing file "04-Cheeseburger_Make_Du.ogg"... New logical stream (#1, serial: 525b4af2): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Cheeseburger Make Du artist=Deliverance album=What a Joke genre=misc tracknumber=4 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 196633 bytes Playback length: 0m:06s Average bitrate: 254.505615 kbps ===== Processing file "05 What A Joke.ogg"... New logical stream (#1, serial: 6860abb3): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 12360411 bytes Playback length: 6m:20s Average bitrate: 259.799853 kbps Logical stream 1 ended Processing file "05-What_A_Joke.ogg"... New logical stream (#1, serial: 38b788fb): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=What A Joke artist=Deliverance album=What a Joke genre=misc tracknumber=5 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 12158916 bytes Playback length: 6m:18s Average bitrate: 257.006555 kbps ===== Processing file "06 Chipped Beef.ogg"... New logical stream (#1, serial: 6860abb4): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 3939130 bytes Playback length: 2m:03s Average bitrate: 255.125000 kbps Logical stream 1 ended Processing file "06-Chipped_Beef.ogg"... New logical stream (#1, serial: 2838c045): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Chipped Beef artist=Deliverance album=What a Joke genre=misc tracknumber=6 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 3940594 bytes Playback length: 2m:01s Average bitrate: 259.736281 kbps ===== Processing file "07 After Forever.ogg"... New logical stream (#1, serial: 6860abb5): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 10466523 bytes Playback length: 5m:26s Average bitrate: 256.721192 kbps Logical stream 1 ended Processing file "07-After_Forever.ogg"... New logical stream (#1, serial: 40b8e619): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=After Forever artist=Deliverance album=What a Joke genre=misc tracknumber=7 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 10496525 bytes Playback length: 5m:24s Average bitrate: 259.119197 kbps ===== Processing file "08 It's The Beat.ogg"... New logical stream (#1, serial: 6860abb6): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 3595744 bytes Playback length: 1m:57s Average bitrate: 243.944640 kbps Logical stream 1 ended ===== Processing file "08-Its_The_Beat.ogg"... New logical stream (#1, serial: 6ff02c1f): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=It's The Beat artist=Deliverance album=What a Joke genre=misc tracknumber=8 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 3711152 bytes Playback length: 1m:55s Average bitrate: 256.295028 kbps ===== Processing file "09 A Product Of Society.ogg"... New logical stream (#1, serial: 6860abb7): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 9086895 bytes Playback length: 4m:42s Average bitrate: 257.370515 kbps Logical stream 1 ended Processing file "09-A_Product_Of_Society.ogg"... New logical stream (#1, serial: 6c862d04): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=A Product Of Society artist=Deliverance album=What a Joke genre=misc tracknumber=9 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 9030282 bytes Playback length: 4m:40s Average bitrate: 257.688180 kbps ===== Processing file "10 Happy Star.ogg"... New logical stream (#1, serial: 6860abb8): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 69205 bytes Playback length: 0m:05s Average bitrate: 102.273399 kbps Logical stream 1 ended Processing file "10-Happy_Star.ogg"... New logical stream (#1, serial: 7a052586): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Happy Star artist=Deliverance album=What a Joke genre=misc tracknumber=10 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 85173 bytes Playback length: 0m:03s Average bitrate: 207.658630 kbps ===== Processing file "11 J.P.D..ogg"... New logical stream (#1, serial: 6860abb9): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 523917 bytes Playback length: 0m:17s Average bitrate: 245.202964 kbps Logical stream 1 ended Processing file "11-J.P.D..ogg"... New logical stream (#1, serial: 5e6bdcd9): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=J.P.D. artist=Deliverance album=What a Joke genre=misc tracknumber=11 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 477323 bytes Playback length: 0m:14s Average bitrate: 256.082047 kbps ===== Processing file "12 Pray.ogg"... New logical stream (#1, serial: 6860abba): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 1214006 bytes Playback length: 0m:41s Average bitrate: 234.515003 kbps Logical stream 1 ended Processing file "12-Pray.ogg"... New logical stream (#1, serial: 504ff7f5): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Pray artist=Deliverance album=What a Joke genre=misc tracknumber=12 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 1248004 bytes Playback length: 0m:38s Average bitrate: 258.564365 kbps ===== Processing file "13 Silent Night.ogg"... New logical stream (#1, serial: 6860abbb): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 9176972 bytes Playback length: 4m:59s Average bitrate: 245.002367 kbps Logical stream 1 ended Processing file "13-Silent_Night.ogg"... New logical stream (#1, serial: 33d714d3): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Silent Night artist=Deliverance album=What a Joke genre=misc tracknumber=13 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 9621799 bytes Playback length: 4m:57s Average bitrate: 258.880273 kbps ===== Processing file "14 J.I.G..ogg"... New logical stream (#1, serial: 6860abbc): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 4195765 bytes Playback length: 2m:10s Average bitrate: 256.909787 kbps Logical stream 1 ended Processing file "14-J.I.G..ogg"... New logical stream (#1, serial: 5720b83d): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=J.I.G. artist=Deliverance album=What a Joke genre=misc tracknumber=14 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 4121561 bytes Playback length: 2m:08s Average bitrate: 256.547521 kbps ===== Processing file "15 Purgatory Sandwich With Mustard.ogg"... New logical stream (#1, serial: 6860abbd): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 6060889 bytes Playback length: 2m:58s Average bitrate: 270.897899 kbps Logical stream 1 ended Processing file "15-Purgatory_Sandwich_With_Mustard.ogg"... New logical stream (#1, serial: 0e56b3a1): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Purgatory Sandwich With Mustard artist=Deliverance album=What a Joke genre=misc tracknumber=15 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 5701480 bytes Playback length: 2m:56s Average bitrate: 257.937353 kbps ===== Processing file "16 Attack.ogg"... New logical stream (#1, serial: 6860abbe): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set Vorbis stream 1: Total data length: 6828244 bytes Playback length: 3m:37s Average bitrate: 250.746459 kbps Logical stream 1 ended Processing file "16-Attack.ogg"... New logical stream (#1, serial: 233e7aeb): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20020717 (1.0) Channels: 2 Rate: 44100 Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... kde-encoder=kio_audiocd title=Attack artist=Deliverance album=What a Joke genre=misc tracknumber=16 Warning: EOS not set on stream 1 Vorbis stream 1: Total data length: 6889981 bytes Playback length: 3m:35s Average bitrate: 255.539021 kbps
Aha! This is the bug I have found, we have it in the Gentoo bugzilla, see http://bugs.gentoo.org/show_bug.cgi?id=28887 The problem is that the audiocd slave is not telling vorbisenc when it gets to the end of the stream. What needs to happen is that audiocd needs to call vorbis_analysis_wrote(&d->vd,0) to tell vorbisenc to close off the stream, then it needs to flush out all the remaining Ogg Vorbis data (i.e. write them to a file). I have made a patch which partly fixes the problem. Sometimes. http://bugs.gentoo.org/attachment.cgi?id=17811&action=view This works some of the time. A solution which would (I think) work all of the time would be to have an end-of-stream-flushout occur during the cleanup phase (just before ogg_stream_clear(&d->os)). This protects the case where CDParanoia reports an error on the very last sector of the track, which I think may be happenning to me at least one case.
I've uploaded a better patch to http://bugs.gentoo.org/attachment.cgi?id=17868&action=view See how you like it. There should be no "Warning: EOS not set on stream 1" messages now.
I'd love to give your patch a try, but I'm afraid I'm not a coder, and I have no idea how to make use of your patch. I can install RPM's and even go through the gereric ./configure, make routine as well as solving minor issues that come up, but I'm afraid I don't know how to use the patch. However, I am willing to learn. I'm not looking for step by step instructions, but either some pointers or a link to a site where I can find out would be quite handy. I'm pretty sure you'd rather spend your time doing something other that trying to teach me how to suck eggs. :) Thanks David.
David, I don't mind giving you step by step instructions. Maybe one day you will be able to help someone else. :) If you are familiar with configure and make, you are most of the way there. Here are instructions for testing my patch. If you aren't comfortable with them, you can just wait for the next release---I'm sure one of the KDE people will fix this bug now that it has been identified more clearly. If you're itching to test it, read on. 1) Download and unpack kdemultimedia source tree. If you are still using 3.1.2, this is the version of kdemultimedia you should download. hiro tmp # tar jxf /usr/portage/distfiles/kdemultimedia-3.1.2.tar.bz2 2) Change directory into the source tree and apply the patch. Even though my patch was made against version 3.1.3, it should work fine for 3.1.2 as well. hiro tmp # cd kdemultimedia-3.1.2/ hiro kdemultimedia-3.1.2 # patch -p0 < /tmp/kdemultimedia-3.1.3-audiocd-ogg.diff patching file kioslave/audiocd/audiocd.cpp patching file kioslave/audiocd/audiocd.h 3) Run ./configure, which will create all the makefiles. hiro kdemultimedia-3.1.2 # ./configure 4) Change to the directory for the audiocd:/ ioslave, because this is all we really care about for now. hiro kdemultimedia-3.1.2 # cd kioslave/audiocd/ 5) Make and install. hiro audiocd # make && make install 6) If you want to check that it's installed into the right place, try running "ls -l $KDEDIR/lib/kde3/kio_audiocd.*" and check the dates on the listed files.
Cool, Thanks for the instructions. :-D Using that method, I've recompiled and installed the patched files, my KDE is 3.1.3 so no problems there. The only difference being, I downloaded the SuSE .src.rpm of kdemultimedia3, I figured I should use the same source package as I used to install it. So having patched, all I need to do now is test. Unfortunately, I don't have an audio cd with me so I'll post an update, once I get the chance to test. Thanks Again! David.
Ok, I've just ripped a 4 track CD-single, unfortunatley, all 4 tracks are still short. I noticed two differences during the rip, firstly the rip seemed to take a *lot* longer, I think it took about 25mins for the rip (17min CD), but I don't normally pay attention to how long it takes, and secondly, each of the tracks was short by a different length; 4-5 seconds, while originally they'd all be short by exactly 4 seconds. So this means one of two things. Either I've screwed up somewhere during the patching process, or my laptop isn't using the new patched versions (If SuSE have put versions in a different place). I've just done a 'find / |grep kio_audiocd' and this was the output: /opt/kde3/lib/kde3/kio_audiocd.la /opt/kde3/lib/kde3/kio_audiocd.so /usr/local/kde/lib/kde3/kio_audiocd.la /usr/local/kde/lib/kde3/kio_audiocd.so So it looks like I have 2 versions on my PC. I've checked the dates on them all and the 2 files in /opt/kde3 are older versions. I'm going to try copying the new libs over the old ones. Is there anyway I can confirm, which version of the Lib, Konqueror is using? Finally, I'm pretty sure I didn't need to apply both of the Diffs you posted, but if I did, I'm not surprised that it isn't working as I only applied the second of the 2 diffs. I'm just going to do a test rip again, now that I've moved the libs, but before I do that, I'm going to restart X. I'll post an update, once I've tested. Thanks again David.
Ok, it looks like SuSE have the libs in a different location, from the default compile. I copied the 4 files in /usr/local/kde/lib/kde3/ into /opt/kde3/lib/kde3/ overwriting the original files, ran SuSEconfig and then restarted X (just to be sure it reloaded all the libs). I then tried ripping the same 4 track single, and all 4 were the correct length. I'll try ripping a few more CD's but, it looks like your patch has fixed the problem. So do I now close the bug, or should your patch be passed to someone for further testing, or put into CVS? I'm afraid this is my first bug, so I don't know what to do next. Bloody n00b ;-) Thanks. David.
David, Please leave the bug open. The decision on what happens now is up to the KDE developers. Hopefully they will commit my patch (or something like it) into CVS, then they will close the bug as being resolved/fixed.
*** Bug 67650 has been marked as a duplicate of this bug. ***
Are any KDE developers watching this bug? Any chance it will be fixed in 3.2 now that we have a patch? I know very few people have noticed the bug, but it does seem to me to be fairly important that you don't knowingly ship a product which creates invalid output.
Subject: kdemultimedia/kioslave/audiocd CVS commit by carewolf: Fixing a handfull of bugs: - bug 60069 Songs too short after encoding (thanks to toojays for patch) - bug 63238 Error ripping files with "/" in their name (renaming slashes to %2F was already present but not consistent). - Set correct title in id3 and ogg-comments CCMAIL: 63238-done@bugs.kde.org CCMAIL: 60069-done@bugs.kde.org M +57 -42 audiocd.cpp 1.81 M +1 -0 audiocd.h 1.15