Bug 60030 - [patch] "Clear Location Bar" button stops download
Summary: [patch] "Clear Location Bar" button stops download
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-19 00:51 UTC by Unai Garro
Modified: 2010-08-02 22:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Unai Garro 2003-06-19 00:51:21 UTC
Version:           CVS HEAD (6/Jun/2003) (using KDE 3.1.9)
Compiler:          gcc version 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk)
OS:          Linux (i686) release 2.5.70-mm6

If one presses the "Clear Location Bar" button when a page is being downloaded, the download process is stopped.  

If this is the intended behavior (which was not in previous versions and  is quite non-intuitive), the same should be applied when removing the text by hand or editing it. 

Continuing with the download while editing the text was quite useful, since one could start typing a second adress even before the download finishes.
Comment 1 Tommi Tervo 2004-01-04 23:02:43 UTC
Confirmed. Statusbar says "Cancelled" and page loading stops.
Comment 2 Bui Arantsson 2008-05-03 19:52:19 UTC
I can confirm that his bug is still present in konqueror 3.5.9.

However it has been fixed in konqueror 4.0.3, so the question is whether it would still be considered relevant by the KDE developers
Comment 3 Matt Rogers 2008-05-03 20:50:59 UTC
*** Bug has been marked as fixed ***.
Comment 4 Unai Garro 2008-05-04 00:30:47 UTC
I'm afraid that this bug is still unsolved in the current svn trunk 
version.  How did you actually test it?

Add the "clear" button to the toolbar of konqueror (yes, it's not there 
by default now). Try opening a long time taking web page. While it's 
loading, press the button. It stops loading.

Please notice that RMB->clear works fine, but the toolbar action doesn't.

Could you please reopen the bug, Matt?

Matt Rogers wrote:
[bugs.kde.org quoted mail]
Comment 5 Unai Garro 2008-05-04 00:46:23 UTC
This bug isn't solved yet. Possibly Bui tested using the right mouse button menu. I can confirm that this bug is still valid on svn trunk.
Comment 6 Tommi Tervo 2008-06-30 11:01:38 UTC
Linus Östberg has nice "patch". Seems to work fine.
http://lists.kde.org/?l=kfm-devel&m=121476589905440&w=2
Comment 7 Linus Östberg 2008-08-04 19:02:44 UTC
Any updates? Will the line be removed or kept?

Anyway, I think it's about time for this bug to be closed soon.
Comment 8 Unai Garro 2008-10-07 23:50:17 UTC
I still don't see why this should not be closed. A patch exists and it's confirmed to work nicely.
Somebody in irc said this... how to call it... "misfeature" was created to avoid (in a bad manner imho) some websites from changing the url in a recursive way or something similar. If that's the only reason, I don't know if the issue is still present, but nobody seems to know about it anymore. And if it's there, IMHO there should be a better way to fix it.
So please either close it or I'll close it myself  in less than a week as WONTFIX. Keeping bugs open for over 5 years is pointless.
Comment 9 Maksim Orlovich 2008-10-08 01:07:02 UTC
Uga: you could just test the problem scenario described in kfm-devel thread, and apply the patch if appropriate :)
Comment 10 Unai Garro 2008-10-08 06:37:02 UTC
Hi sad, thanks for the response. I'd appreciate if you could point me to that thread, which I must have missed for over 5 years. So far nobody had provided a testcase to me and I haven't read such thread.
Comment 11 Tommi Tervo 2008-10-08 07:30:00 UTC
uga: http://lists.kde.org/?l=kfm-devel&m=121520413203316&w=2
Comment 12 Unai Garro 2008-10-08 10:45:12 UTC
Tommi, that thread doesn't show any testcases nor urls. He only mentions the same thing I did, but doesn't provide any samples that can cause the issue.
Comment 13 Unai Garro 2008-10-08 20:24:47 UTC
I could create an html page that could try redirecting to itself, as described by dfaure, but I would not be reproducing the exact issue that caused this fix. We would really need to know what site or what code caused committing this workaround.
Comment 14 FiNeX 2010-08-02 17:44:20 UTC
Cannot reproduce the bug on KDE 4.4.5: when I press the "clear" button the page doesn't stop loading.


Is someone able to reproduce the bug with the latest KDE version?
Comment 15 Tommi Tervo 2010-08-02 20:02:21 UTC
I can reproduce this one if I enable "old" clear location bar button. But nowadays default is klineedit clear button which works fine and doesn't interfere page loading. I'll close this bug although the original bug/feature is still there. Maybe we should just remove the old slotClearLocationBar code?
Comment 16 FiNeX 2010-08-02 22:23:37 UTC
@Tommi: I agree.