Bug 59794 - tabs should have control+T as a shortcut by default
Summary: tabs should have control+T as a shortcut by default
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: tabbing (show other bugs)
Version: 4.0
Platform: Mandrake RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 70687 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-06-15 05:16 UTC by pramodleo
Modified: 2006-01-01 19:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Adds CTRL+T as alternative shortcut for new tab and replaces CTRL+T with F10 for opening a terminal (2.24 KB, patch)
2004-02-20 02:34 UTC, Simon Perreault
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pramodleo 2003-06-15 05:16:09 UTC
Version:           4.0 (using KDE 3.1.0)
Installed from:    Mandrake Linux Cooker i586 - Cooker
Compiler:          gcc version 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk)
OS:          Linux (i686) release 2.4.21-0.13mdk

Tabs should have Control+T as a shortcut by default, just like in mozilla and galeon. It is not only consistent, but easier to remember. The new tabs button in the menu, should be enabled by default, else you have to browse to a site, only then you will see the new tab menu. Which is not only a waste of productivity, but also irritating, since you can't start browsing in two tabs at once.
Comment 1 Thiago Macieira 2003-06-15 14:19:45 UTC
I don't understand. Ctrl+T as a shortcut for what action? Create new tab? 
 
Besides, that action is already available when Konqueror is started. I can open two 
tabs or more without going anywhere (using KDE CVS) 
Comment 2 Ismail Donmez 2003-06-15 15:34:25 UTC
This is from Mozilla fame and I think very useful. 
Comment 3 pramodleo 2003-06-18 16:41:58 UTC
Yes. Ctrl+T as a shortcut for Creating new tabs. This is consistent with both 
Mozilla & Galeon. I would also suggest that the "create new tab" should come 
uder the location menu, since no newbie would find it under the window menu. 
Thank you. 
Comment 4 Thiago Macieira 2003-06-18 16:49:04 UTC
I am already kind of used to Ctrl+Shift+N. I know Ctrl+N creates new window and 
Ctrl+D duplicates; for me it's natural to do the same but with tabs with Ctrl+Shift+N 
and Ctrl+Shift+D... 
 
Anyways, the menu options is already in the Location menu. 
Comment 5 pramodleo 2003-06-18 16:54:40 UTC
I understand your concern. But I am speaking for newbies, since Ctrl+T is 
simple,easy to remember & used in most browsers. Maybe Ctrl+shift+N could be 
anyway changed by experienced users. This is atleast, My opinion.  
Comment 6 Maksim Orlovich 2003-12-17 15:19:31 UTC
*** Bug 70687 has been marked as a duplicate of this bug. ***
Comment 7 Thiago Macieira 2003-12-17 17:36:39 UTC
You can change the shortcut to suit your needs. It's fully configurable.

You are, however, asking that we change the default. I can't answer that for you, except that Konqueror has to be consistent with Konqueror and other KDE programs (in less polite words, "I couldn't care less what the shortcuts are in Mozilla").

Other KDE applications with tabs:
Konsole: shortcuts are Ctrl+Alt+N and Ctrl+Shift+N
(what other applications use tabs?)

If you want to change the default, I recommend posting to kfm-devel and kde-usability and convincing them why Ctrl+T is better than Ctrl+Shift+N.
Comment 8 Leo Savernik 2003-12-19 14:12:11 UTC
I support this bug. Why not make Ctrl+T the global shortcut for opening new tabs, and Ctrl+Shift+N the secondary shortcut (so that the old users can keep their habits)?

This would not be the first time Mozilla shortcuts have been reused for konqueror:
Ctrl+U for "view document source" [1], and Ctrl+I for "page information" [2].

Konsole is a very bad example for consistency because nearly all Ctrl+<key> actions are reserved for terminal-specific stuff (think Ctrl+C, which interrupts, but does not paste).

So konsole is a prime example of non-consistency (which is *good* because konsole is a very special app fulfilling special needs for special kinds of users).

References:
[1] http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/khtml_part.cpp.diff?r1=1.906&r2=1.907&f=h
[2] "Add other shortcut for 'View Document Information' as in Mozilla", 
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/khtml_part.cpp.diff?r1=1.907&r2=1.908&f=h
Comment 9 Janis Blechert 2004-01-10 20:16:12 UTC
The shortcuts in konsole and konqueror should be consistent (http://bugs.kde.org/show_bug.cgi?id=53855) so why don't change them to something like Strg+Alt+T (for tab) Strg+Alt+R (Remove) and so on, would be kinda logical :)
Comment 10 Leo Savernik 2004-01-10 22:58:49 UTC
Because you can't reach Ctrl+Alt+T with one hand without severe wrenches.

Shortcuts have to be the more convenient the more frequently its associated action is to be executed. And opening a new tab is undoubtedly a *very* frequent action.

As I already mentioned, konsole cannot have Ctrl+T because all Ctrl+<key> combinations are reserved for the terminal.
Comment 11 Simon Perreault 2004-02-20 02:34:04 UTC
Created attachment 4785 [details]
Adds CTRL+T as alternative shortcut for new tab and replaces CTRL+T with F10 for opening a terminal
Comment 12 Simon Perreault 2004-02-23 03:46:02 UTC
Applied the proposed patch after discussion (or absense of it) in kfm-devel.
Comment 13 Sashmit Bhaduri 2004-02-28 10:07:31 UTC
thank you simon.
Comment 14 Ricardo Ferreira 2004-02-28 14:28:12 UTC
The problem is that F10 is already used for New Folder in konqueror. That happens to be a shortcut i use a LOT. Now i find myself hitting F10 and opening a new tab when i wanted a new folder. Atleast change the new folder shortcut to something other than F10.

I noticed this last week but only knew the source of the change when i read this weeks CVS digest.
Comment 15 Ricardo Ferreira 2004-02-28 14:30:45 UTC
Forget it, i see now that the open terminal shortcut has been changed to F4.

Thanks.
Comment 16 Leo Savernik 2004-03-16 22:55:11 UTC
CVS commit by savernik: 

Backport: Add Ctrl+T as alternative shortcut for opening a new tab, and
make F4 open konsole.
CCMAIL: 59794@bugs.kde.org


  M +2 -2      konq_mainwindow.cc   1.1274.2.13


--- kdebase/konqueror/konq_mainwindow.cc  #1.1274.2.12:1.1274.2.13
@@ -3185,5 +3185,5 @@ void KonqMainWindow::initActions()
   if (kapp->authorize("shell_access"))
   {
-     (void) new KAction( i18n( "Open &Terminal" ), "openterm", CTRL+Key_T, this, SLOT( slotOpenTerminal() ), actionCollection(), "open_terminal" );
+     (void) new KAction( i18n( "Open &Terminal" ), "openterm", Key_F4, this, SLOT( slotOpenTerminal() ), actionCollection(), "open_terminal" );
   }
   (void) new KAction( i18n( "&Open Location..." ), "fileopen", KStdAccel::shortcut(KStdAccel::Open), this, SLOT( slotOpenLocation() ), actionCollection(), "open_location" );
@@ -3244,5 +3244,5 @@ void KonqMainWindow::initActions()
   m_paSplitViewHor = new KAction( i18n( "Split View &Left/Right" ), "view_left_right", CTRL+SHIFT+Key_L, this, SLOT( slotSplitViewHorizontal() ), actionCollection(), "splitviewh" );
   m_paSplitViewVer = new KAction( i18n( "Split View &Top/Bottom" ), "view_top_bottom", CTRL+SHIFT+Key_T, this, SLOT( slotSplitViewVertical() ), actionCollection(), "splitviewv" );
-  m_paAddTab = new KAction( i18n( "&New Tab" ), "tab_new", CTRL+SHIFT+Key_N, this, SLOT( slotAddTab() ), actionCollection(), "newtab" );
+  m_paAddTab = new KAction( i18n( "&New Tab" ), "tab_new", "CTRL+SHIFT+N;CTRL+T", this, SLOT( slotAddTab() ), actionCollection(), "newtab" );
   m_paDuplicateTab = new KAction( i18n( "&Duplicate Current Tab" ), "tab_duplicate", CTRL+SHIFT+Key_D, this, SLOT( slotDuplicateTab() ), actionCollection(), "duplicatecurrenttab" );
   m_paBreakOffTab = new KAction( i18n( "Detach Current Tab" ), "tab_breakoff", CTRL+SHIFT+Key_B, this, SLOT( slotBreakOffTab() ), actionCollection(), "breakoffcurrenttab" );


Comment 17 Thorsten Staerk 2006-01-01 19:50:07 UTC
You guys are so great! I just wanted to program it on my own!!!