Bug 58404 - goto bookmark location with split windows
Summary: goto bookmark location with split windows
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-12 23:33 UTC by Nan Zou
Modified: 2003-05-13 17:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Zou 2003-05-12 23:33:34 UTC
Version:            (using KDE KDE 3.1)
Installed from:    Compiled From Sources
Compiler:          gcc 2.96 
OS:          Linux

Add a bookmark location, now split this window into two, using Alt-PgDn to goto the next bookmark location always goes to the newly created window, instead of the window with the cursor.
Comment 1 Anders Lund 2003-05-12 23:47:50 UTC
This is a misunderstanding: The new view allways gets focus. You can see it, 
because the cursor is blinking in it, and the statusbar has the active color 
scheme (it is a bit lighter than the statusbar of the old view). 
 
Unless you have more arguments, I close this bug tomorrow. 
 
-anders 
Comment 2 Nan Zou 2003-05-13 00:00:23 UTC
Yes, the new view automatically gets focus.  But, even after I select the 
original view for focus, Alt-PgDn still goes to bookmark location the new 
view.  So the new view becomes "sticky" for bookmark navigation.
Comment 3 Anders Lund 2003-05-13 00:43:25 UTC
Subject: Re:  goto bookmark location with split windows

On Tuesday 13 May 2003 00:00, Nan Zou wrote:
> Yes, the new view automatically gets focus.  But, even after I select the
> original view for focus, Alt-PgDn still goes to bookmark location the new
> view.  So the new view becomes "sticky" for bookmark navigation.

Right you are.
I can't see a way to ix this immediately, since it has to do with the action, 
which is handled by the kdeui libraries.

We'll keep the bug for now (culmann, should we reassign this to kdeui?)

-anders

Comment 4 Paul Pogonyshev 2003-05-13 00:50:23 UTC
If i'm not mistaken, it is caused by the fact that m_activeView in KateDocument class is never 
updated. There are more related bugs i think. 
Comment 5 Anders Lund 2003-05-13 14:33:12 UTC
Subject: Re:  goto bookmark location with split windows

On Tuesday 13 May 2003 00:50, Paul Pogonyshev wrote:
> If i'm not mistaken, it is caused by the fact that m_activeView in
> KateDocument class is never updated. There are more related bugs i think.

Oh, thanks! That definitely needs fixing.

-anders

Comment 6 Anders Lund 2003-05-13 17:03:28 UTC
Subject: Re:  goto bookmark location with split windows

On Tuesday 13 May 2003 00:50, Paul Pogonyshev wrote:
> If i'm not mistaken, it is caused by the fact that m_activeView in
> KateDocument class is never updated. There are more related bugs i think.

Hm, I fixed that issue, but it didn't fix the bookmark bug. The bookmarks menu 
is owned by the view, but it seems to work really weird.

If i have  a document with several bookmarks and split the view, pressing alt 
+ pgdown several times will make the two views go to next bookmark in turn...

Activating the menu allways works correctly.

I could fix this by using the now fixed doc->m_activeView, since this seems to 
be a issue with kaccel (?) - i'll do that in a moment.

-anders

Comment 7 Anders Lund 2003-05-13 17:21:01 UTC
Works in HEAD now, even the fix is a bit hacky. However, I don't think the wrong 
view getting the keyboard event is a kate issue, and the feature is absolutely not 
mission critical. 
 
Thanks for reporting.