Bug 58254 - Doesn't hide files that it should
Summary: Doesn't hide files that it should
Status: RESOLVED FIXED
Alias: None
Product: cervisia
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Andre Woebbeking
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-08 22:39 UTC by Adrian Page
Modified: 2004-05-17 23:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix the bug (560 bytes, patch)
2003-05-08 22:43 UTC, Adrian Page
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Page 2003-05-08 22:39:32 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.2.2 
OS:          Linux

The 'Hide' items filter does not work correctly. If the option to hide files that are not in CVS is set, opening up a branch of the file tree still shows files that are not in CVS. If, however, you switch the option off and then back on again, the files do then get hidden.

The problem is that the UpdateView's filter does not get applied to the newly opened directory's items.

Regards,
Adrian Page
Comment 1 Adrian Page 2003-05-08 22:43:43 UTC
Created attachment 1505 [details]
Patch to fix the bug

This patch fixes the problem by applying the filter once the directory has been
opened.
Comment 2 Andre Woebbeking 2003-05-14 22:25:47 UTC
Hi Adrian, 
 
thank you for your bug report and your patch. Sadly, I have to search for 
another patch as yours can be a bit slow (think of "unfold tree" for large 
repositories). 
 
 
Andre. 
Comment 3 Adrian Page 2003-05-17 00:34:29 UTC
Hi Andre, 
 
I see what you mean about Unfold Tree. I'll have a look at finding a more efficient 
solution, unless it gets fixed in the meantime. 
 
Adrian 
 
Comment 4 Andre Woebbeking 2003-05-17 18:32:02 UTC
Hi Adrian, 
 
if you want to, nice, but you don't have to as UpdateView is on my ToDo list 
anyway. 
 
Andr
Comment 5 Adrian Page 2003-05-19 17:11:06 UTC
Hi Andre, 
 
Ok, I'll leave it with you, if you're going to be reviewing UpdateView anyway. 
 
Adrian 
 
Comment 6 A T Somers 2003-09-24 10:07:53 UTC
This problem also occurs when restarting Cervisia: although the state of the 
check in the menu is kept, it is ineffective for all newly opened directories, 
which are all directories except the root of the sandbox.  
Comment 7 Federico Zenith 2004-05-04 09:58:19 UTC
Hi,
4 days more and it will be one year since this bug was opened. If no better patch has been worked out, the one here presented should be implemented. I am using KDE 3.2.2, and Cervisia still behaves exactly as reported by the original poster.
It's better having a patch that fixes this problem sloppily than not being able to do it at all.
Yes, I know, I should have done it myself instead of whining, but I'm not a programmer (yet). :-)

Cheers,
-Federico
Comment 8 Andre Woebbeking 2004-05-17 23:14:29 UTC
CVS commit by woebbe: 

Fixed BR #58254.

Sorry for the huge delay!

CCMAIL: 58254-done@bugs.kde.org


  M +5 -0      ChangeLog   1.126
  M +16 -8     updateview.cpp   1.56
  M +10 -0     updateview.h   1.16
  M +11 -0     updateview_items.cpp   1.10


--- kdesdk/cervisia/ChangeLog  #1.125:1.126
@@ -1,2 +1,7 @@
+2004-05-17  Andr