Bug 58231 - ScroolLock doesn't do its job
Summary: ScroolLock doesn't do its job
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 1.2
Platform: FreeBSD Ports FreeBSD
: NOR minor
Target Milestone: ---
Assignee: groot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-08 13:21 UTC by Yaroslav Kolomiyets
Modified: 2003-05-09 22:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
konsole.diff (1005 bytes, text/plain)
2004-10-19 16:20 UTC, groot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Kolomiyets 2003-05-08 13:21:55 UTC
Version:           1.2 (using KDE KDE 3.1)
Installed from:    FreeBSD Ports
OS:          FreeBSD

It would be nice if 'ScroolLock' key became doing of job it is created for - scrolling of console. (just like in FreeBSD's vtty)
Comment 1 Waldo Bastian 2003-05-08 13:37:42 UTC
It is supposed to do just that. It works on Linux, if it doesn't work on FreeBSD it 
needs some TLC from a FreeBSD developer. 
 
See e.g. TEmuVt102::onScrollLock() in konsole/TEmuVt102.cpp 
Comment 2 groot 2003-05-08 14:04:38 UTC
Indeed, scroll lock in a konsole from 3.1.1 just locks the konsole like ^S would, and while locked 
the arrow keys / pgup / pgdn do not function for scrolling like the OP wishes. Looks FBSD 
specific indeed, and I'll see what I can do. 
Comment 3 Waldo Bastian 2003-05-08 14:30:10 UTC
Subject: Re: [Konsole-devel]  ScroolLock doesn't do its job

Scrolling is supposed to work with SHIFT-PgUp / SHIFT-Arrow / etc. but not 
with PgUp / Arrow only. I guess the wish is then to be able to scroll with 
PgUp/PgDn/Arrow only when ScrollLock is active?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+uk1wN4pvrENfboIRAlsmAJ49TI8Uq9q6Rg/3vbVGhbF4JO9ybQCglCLB
TnulB+f1PzZeXGAtujmNGYI=
=0pKm
-----END PGP SIGNATURE-----

Comment 4 Yaroslav Kolomiyets 2003-05-08 14:40:47 UTC
> Scrolling is supposed to work with SHIFT-PgUp / SHIFT-Arrow / etc. but not 
> with PgUp / Arrow only. I guess the wish is then to be able to scroll with 
> PgUp/PgDn/Arrow only when ScrollLock is active? 
Of course. It is familiar behavior of traditional UNIX consoles... 
 
Comment 5 Thiago Macieira 2003-05-08 15:06:43 UTC
Scrolling with Shift is the familiar behaviour of xterm... 
Comment 6 groot 2003-05-08 15:27:04 UTC
Subject: Re:  ScroolLock doesn't do its job         

On 8 May 2003, Thiago Macieira wrote:
> Scrolling with Shift is the familiar behaviour of xterm...
Indeed, just because the *BSD platforms have scrolllock+arrows to scroll
their syscons'es, it doesn't mean this is "traditional UNIX behavior". I'm
fairly sure the Sun/Solaris boxes here in the building don't scroll either
when treated that way. I don't have a Linux box handy to test with.

_IF_ I implement this, I'm going to #ifdef Q_OS_FREEBSD it, to make sure
it affects only people who might reasonably expect it to behave so.
Unfortunately it'll probably only prompt more hacks to konsole's code to
imitate the quirks of other syscons implementations (like prtsc switches
to the next syscons).

Comment 7 Yaroslav Kolomiyets 2003-05-08 15:51:51 UTC
> I'm fairly sure the Sun/Solaris boxes here in the building don't scroll either when  
> treated that way 
Solaris is farther from original AT&T UNIX then FreeBSD... 
 
> _IF_ I implement this, I'm going to #ifdef Q_OS_FREEBSD it 
That is not necessary, 'cause people who won't use this, wil not use this... 
Comment 8 groot 2003-05-08 20:06:33 UTC
Subject: Re:  ScroolLock doesn't do its job         

On 8 May 2003, Yaroslav Kolomiyets wrote:
> > I'm fairly sure the Sun/Solaris boxes here in the building don't scroll either when
> > treated that way
> Solaris is farther from original AT&T UNIX then FreeBSD...

I prefer the argument "xterm doesn't do this either", actually. Anyway,
the patch is attached, I hope that makes it into the bugs system. It
_does_ change the behavior of konsole though, subtly:

start vi on a large file
page down, say 100 lines
hit scroll lock
hit pageup twice

with the patch, this scrolls the view. Without the patch, the two pageups
hang around and are sent to vi when scrolllock is released. What to do?



Created an attachment (id=1504)
konsole.diff
Comment 9 groot 2003-05-09 22:46:01 UTC
Implemented (and documented) in HEAD anyway; I think the OP was right, people 
who don't know this exists will not be inconvenienced.