Bug 57875 - Sequence diagram: label placement
Summary: Sequence diagram: label placement
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 1.1.1
Platform: Mandrake RPMs Linux
: LO normal
Target Milestone: ---
Assignee: Oliver Kellogg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-30 08:38 UTC by Stevan White
Modified: 2005-04-08 22:29 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stevan White 2003-04-30 08:38:51 UTC
Version:           1.1.1 (using KDE KDE 3.1.1)
Installed from:    Mandrake RPMs
OS:          Linux

Currently, message labels in sequence diagrams always appear on the left side.

If they can't be moved, they should at least always appear on the base side of the arrow!

But you should also allow the user to place them where they want.
Comment 1 Jonathan Riddell 2004-01-19 18:35:19 UTC
Base side seems to make sense, not sure what advantage there is in allowing the labels free placement.
Comment 2 Sebastian Stein 2004-02-04 14:02:26 UTC
Subject: Re: [Uml-devel]  Sequence diagram: label placement

Jonathan Riddell <jr@jriddell.org> [040119 18:40]:
> Base side seems to make sense, not sure what advantage there is in
> allowing the labels free placement.

What does base side mean?

Steinchen
Comment 3 Jonathan Riddell 2004-02-04 14:22:50 UTC
I don't know if it makes sense but it ment the side of the arrow with the class that has the method which is being called.  At the moment is appears next to the calling class.

Not sure which is best, it may not matter.
Comment 4 Sebastian Stein 2004-02-04 15:57:35 UTC
Subject: Re: [Uml-devel]  Sequence diagram: label placement

Jonathan Riddell <jr@jriddell.org> [040204 14:54]:
> I don't know if it makes sense but it ment the side of the arrow with the
> class that has the method which is being called.  At the moment is appears
> next to the calling class.
> 
> Not sure which is best, it may not matter.

So can we close the report or change it to a wish (free label placement)? Or
should we just move it to the other side?

Steinchen
Comment 5 Jonathan Riddell 2004-02-05 17:38:54 UTC
OK, closing.  I think the choice is arbitrary which end you put them at and I can't see any reason for free placement, the labels are supposed to be attached to the arrows.
Comment 6 Stevan White 2004-06-13 12:05:06 UTC
Nobody proposed that the labels be disattached from the arrows.
Nor did anybody propose free placement.

The question is, where is the label to be placed along the arrow. This leaves at
least one degree of freedom along the line of the arrow, and a choice between one of the two sides of the line.

As it is, the automatic placement often results in ugly or confusing diagrams.

It is possible to construct diagrams that work around this problem.  But it's a bad
policy to take, expecting users to work around interface glitches.
Comment 7 Oliver Kellogg 2004-07-03 03:40:22 UTC
*** Bug has been marked as fixed ***.
Comment 8 Jonathan Riddell 2004-07-06 01:09:56 UTC
Labels on asynchronous messages can now be moved along the horizontal fine, on synchronous messages they just back to the start of the message as soon as you move the message itself.
Comment 9 Oliver Kellogg 2004-07-06 06:58:40 UTC
> [...] on synchronous messages they just back to the start of the message
> as soon as you move the message itself.

What do you suggest then be the proper behaviour?
Comment 10 Jonathan Riddell 2004-07-06 15:26:14 UTC
> What do you suggest then be the proper behaviour? 

As with asynchronous messages the labels should keep their horizontal position when the message is being moved up or down.
Comment 11 Oliver Kellogg 2004-07-06 17:20:20 UTC
> [...] the labels should keep their horizontal position when the message
> is being moved up or down. 

If nobody objects then I'll implement it such that it is not possible to
change the horizontal position of the text on messages to self (i.e. restore
the behaviour as before the mod.)
Comment 12 Oliver Kellogg 2004-07-08 09:59:32 UTC
> [...] it is not possible to change the horizontal position of the
> text on messages to self 

Since nobody objected I implemented it as aforementioned.
Comment 13 Jonathan Riddell 2004-07-13 23:38:20 UTC
On aynchronous operations you can move the label left and right, but you can not move it at all on synchronous operations.

On messages to self with asynchronous operations the text jumps around the screen when moving, with synchronous operations it can not be moved except with the operation (which is probably best).

Are you maybe confusing synchonous/asynchonous with messages to self/messages to another object Oliver?
Comment 14 Oliver Kellogg 2005-04-05 19:37:52 UTC
Bummer. I has this fixed and now it's broken again :(
Comment 15 Oliver Kellogg 2005-04-08 22:29:24 UTC
Following reoccurrences are fixed by this checkin:
1. movability of message text of sequence message pointing left
2. movability of newly created message text

CVS commit by okellogg: 

Fix reoccurrences of bug 57875.
MessageWidget::{drawSolidArrowhead,drawArrow}: New methods facilitate
understanding the drawing code.


  M +71 -54    messagewidget.cpp   1.69
  M +15 -0     messagewidget.h   1.33