Bug 57116 - Missing some useful C++ warning options
Summary: Missing some useful C++ warning options
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: 3.0.0a4
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: KDevelop Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-11 02:11 UTC by Chris Thompson
Modified: 2005-05-01 20:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch to change warnings tab headers (678 bytes, patch)
2003-05-23 17:09 UTC, Chris Thompson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Thompson 2003-04-11 02:11:19 UTC
Version:           Gideon 3.0.0a4 (using KDE KDE 3.1.1)
Installed from:    Gentoo Packages
Compiler:          gcc 3.2.2 
OS:          Linux

From main menu with a C++ project, do the following:

Project --> Project Options --> Configure Options --> C++ --> [...] on the Compiler Flags line.

The Warnings I and Warnings II tabs are missing some useful settings.

I'd specifically like at least the following warnings given as options:
-Wall
-Wctor-dtor-privacy
-Wnon-virtual-dtor
-Wsign-promo

There are quite possibly other warnings supported by gcc 3.2.x that are not included in this list.
Comment 1 Amilcar do Carmo Lucas 2003-04-11 17:36:59 UTC
Fixed in CVS by Alexander Dymo <cloudtemple at mksat dot net> 
Comment 2 Chris Thompson 2003-04-11 21:48:02 UTC
Would like this bug reopened.  All of the requested modifications I had with one 
exception have been added, and I thank you. 
 
While you are right that the -Wall functionality is implicit, I would like this actually 
STATED.  That is, I would like the wording to change from: 
'All warnings below, combined' 
to: 
'All warnings below, combined (-Wall)' 
 
It was not clear to me that this is what the checkbox does. 
 
Additionally, it would be useful to somehow indicate that the Warnings I page contains 
the 'safe' warnings, i.e. warnings contained in -Wall, and that the Warnings II page 
contains options that do not fit into gcc's definition of 'warnings about constructions 
that some users consider questionable, and that are easy to avoid (or modify to 
prevent the warnings), even in conjunction with macros' (from gcc info page). 
 
I do not know the best way to notify the user that this is the intention of the Warnings I 
and Warnings II pages but I did not realise this until today. 
Comment 3 Amilcar do Carmo Lucas 2003-05-23 15:50:04 UTC
Added the (-Wall) text 
Comment 4 Chris Thompson 2003-05-23 17:03:02 UTC
Yay!  This is great! 
 
As noted, I would quite like 'Warnings I' renamed as 'Warnings (safe)' and 'Warnings 
II' renamed as 'Warnings (unsafe)' or something similar.  If necessary, I can submit a 
patch to do this, though it should be obvious I don't have particularly good wording 
here.  :) 
 
In any case, thanks for this fix. 
 
Comment 5 Chris Thompson 2003-05-23 17:09:10 UTC
Created attachment 1637 [details]
Patch to change warnings tab headers

This is a patch to change the title on the warnings tabs.  My wording is not
particularly good and I'm hoping someone else can think of something better.
Comment 6 Chris Thompson 2003-08-16 19:18:00 UTC
This is an update to note that this bug still applies to 3.0a5 and the attached patch 
would still resolve the remainder of this bug. 
Comment 7 Amilcar do Carmo Lucas 2003-08-21 15:44:38 UTC
Subject: kdevelop/plugins/gccoptions

CVS commit by aclu: 

renamed 'Warnings I'  as 'Warnings (safe)'
renamed 'Warnings II' as 'Warnings (unsafe)'

Thanks to: Chris Thompson (chris in hypocrite.org)
CCMAIL: 57116-done@bugs.kde.org


  M +2 -2      gccoptionsplugin.cpp   1.14


--- kdevelop/plugins/gccoptions/gccoptionsplugin.cpp  #1.13:1.14
@@ -569,8 +569,8 @@ GccOptionsDialog::GccOptionsDialog(GccOp
         g77 = 0;
 
-    vbox = addVBoxPage(i18n("Warnings I"));
+    vbox = addVBoxPage(i18n("Warnings (safe)"));
     warnings1 = new Warnings1Tab(type, vbox, "warnings1 tab");
 
-    vbox = addVBoxPage(i18n("Warnings II"));
+    vbox = addVBoxPage(i18n("Warnings (unsafe)"));
     warnings2 = new Warnings2Tab(type, vbox, "warnings2 tab");
 }


Comment 8 Tim Hutt 2005-05-01 20:27:01 UTC
Took me ages to find out what the difference between 'Safe' warnings and 'Unsafe' warnings are. This is possibly the worst relabelling ever!

I'm still not sure. I assume 'Safe' warnings are warnings that you should use, but 'Unsafe' ones are more likely warn you for things that are actually correct.

Please either add some extra text somewhere explaining this *in the dialog*, or relabel them to something like "Recommended Warnings", "Paranoid Warnings".

Also, it would be highly desirable to add some text explaining what each of the -W<something> options does as I have no idea from the dialog.