Bug 56659 - kdenetwork fails to compile on solaris 7 u_int8_t u_int32_t
Summary: kdenetwork fails to compile on solaris 7 u_int8_t u_int32_t
Status: RESOLVED FIXED
Alias: None
Product: ktalkd
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Solaris
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-31 11:14 UTC by Mikko Paananen
Modified: 2003-03-31 12:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikko Paananen 2003-03-31 11:14:28 UTC
Version:            (using KDE KDE 3.1.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2.2 
OS:          Solaris

Kdenetwork 3.1.1 fails to compile on Solaris 7, there are undefined types u_int32_t and u_int8_u in kdenetwork-3.1.1/ktalkd/ktalkd/machines/ in files forwmach.h talkconn.cpp and talkconn.h. These types should be changed to uint32_t and uint8_t (defined in C89 standard).
Comment 1 Mikko Paananen 2003-03-31 11:15:55 UTC
This bug was reported in KDE 3.1 and marked fixed but it's still on KDE 3.1.1.
Comment 2 David Faure 2003-03-31 12:25:08 UTC
Subject: kdenetwork/ktalkd/ktalkd/machines

CVS commit by faure: 

More u_int8 turned into uint8 for Solaris. I forgot the machines/ subdir initially...
CCMAIL: 56659-done@bugs.kde.org


  M +1 -1      forwmach.h   1.8
  M +3 -3      talkconn.cpp   1.15
  M +1 -1      talkconn.h   1.9


--- kdenetwork/ktalkd/ktalkd/machines/forwmach.h  #1.7:1.8
@@ -146,5 +146,5 @@ class ForwMachine
     TalkConnection * tcAnsw;
     /** id_num for the announce on answerer's machine. */
-    u_int32_t answ_id_num;
+    uint32_t answ_id_num;
 
     /** Local user name, the original 'callee' */

--- kdenetwork/ktalkd/ktalkd/machines/talkconn.cpp  #1.14:1.15
@@ -459,6 +459,6 @@ int TalkConnection::look_for_invite(int 
     ctl_transact(LOOK_UP, 0);
 
-    u_int8_t answer;
-    u_int32_t id_num;
+    uint8_t answer;
+    uint32_t id_num;
     getResponseItems(&answer, &id_num, &lookup_addr);
 
@@ -569,5 +569,5 @@ void TalkConnection::write_banner(char *
 }
 
-void TalkConnection::getResponseItems(u_int8_t * answer, u_int32_t * id_num, struct talk_addr * addr) {
+void TalkConnection::getResponseItems(uint8_t * answer, uint32_t * id_num, struct talk_addr * addr) {
     if (protocol == talkProtocol) {
         if (answer) *answer = old_resp.answer;

--- kdenetwork/ktalkd/ktalkd/machines/talkconn.h  #1.8:1.9
@@ -89,5 +89,5 @@ class TalkConnection
     /** Returns response answer and id_num. Allows protocol independence.
      * Each param can be null (0L). Then it isn't filled.*/
-    void getResponseItems(u_int8_t * answer, u_int32_t * id_num, struct talk_addr * addr);
+    void getResponseItems(uint8_t * answer, uint32_t * id_num, struct talk_addr * addr);
     /** Returns connection socket address. For FWT. */
     const struct talk_addr get_addr() { return new_msg.addr; } // idem in old_msg