Bug 55468 - only one page displayed
Summary: only one page displayed
Status: RESOLVED FIXED
Alias: None
Product: kghostview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Mandrake RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Wilco Greven
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-03 15:08 UTC by Blindauer Emmanuel
Modified: 2003-04-04 19:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blindauer Emmanuel 2003-03-03 15:08:57 UTC
Version:           0.13.2 (using KDE 3.1.0)
Installed from:    Mandrake Linux Cooker i586 - Cooker
Compiler:          gcc version 3.2 (Mandrake Linux 9.0 3.2-1mdk)
OS:          Linux (i686) release 2.4.19-16mdk

I've got a .ps, the file is correctly displayed with gv (5 pages), but kghostview say that only one page is available.
The "faulty" .ps can be found here:
http://www.cmi.univ-mrs.fr/~damour/maple/cor_crypto.ps
Comment 1 Luís Pedro Coelho 2003-04-04 00:42:24 UTC
Fixed in HEAD. 
Still fails in KDE_3_1_BRANCH. 
 
I will confirm the bug for now. 
Comment 2 Luís Pedro Coelho 2003-04-04 19:23:48 UTC
Subject: KDE_3_1_BRANCH: kdegraphics/kghostview

CVS commit by luis_pedro: 

Backport an earlier bugfix with handling of half-broken DSC-comments in files.

CCMAIL: 55468-done@bugs.kde.org


  M +7 -2      kdscerrordialog.cpp   1.5.4.1
  M +1 -6      kgv_miniwidget.cpp   1.155.2.2


--- kdegraphics/kghostview/kgv_miniwidget.cpp  #1.155.2.1:1.155.2.2
@@ -349,8 +349,4 @@ void KGVMiniWidget::scanDSC()
     _dsc = new KDSC();
     
-    KDSCErrorDialog errorDialog;
-    KDSCErrorThreshold errorHandler( 3, &errorDialog );
-    _dsc->setErrorHandler( &errorHandler );
-   
     char buf[4096];
     int  count;
@@ -371,5 +367,4 @@ void KGVMiniWidget::scanDSC()
     }
     _dsc->fixup();
-    _dsc->setErrorHandler( 0 );
 }
 

--- kdegraphics/kghostview/kdscerrordialog.cpp  #1.5:1.5.4.1
@@ -14,5 +14,5 @@
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  */
 
@@ -40,5 +40,8 @@ KDSCErrorHandler::Response KDSCErrorThre
         return _errorHandler->error( err );
     else
-        return Ok;
+        // Cancel is the default handling strategy for dsc_error_fn, so 
+        // we keep it. This cancels error handling and *not* document 
+        // parsing! 
+        return Cancel;
 }
     
@@ -163,2 +166,4 @@ void KDSCErrorDialog::slotIgnoreAll()
     accept();
 }
+
+// vim:sw=4:sts=4:ts=8:noet