Bug 53794 - Layout error in endnote/footnote dialog
Summary: Layout error in endnote/footnote dialog
Status: RESOLVED FIXED
Alias: None
Product: kword
Classification: Miscellaneous
Component: general (show other bugs)
Version: 1.5 or before
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-01 03:13 UTC by Mike McBride
Modified: 2003-02-02 16:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Pix of dialog box. (10.89 KB, image/png)
2003-02-01 03:15 UTC, Mike McBride
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike McBride 2003-02-01 03:13:19 UTC
Version:           1.2post (using KDE 3.1.0)
Installed from:    compiled sources
Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.2 2.96-108.7.2)
OS:          Linux (i686) release 2.4.7-10

There is a dialog layout error.  Resizing the dialog vertically does not correct the problem. 

An attachment will follow
Comment 1 Mike McBride 2003-02-01 03:15:19 UTC
Created attachment 852 [details]
Pix of dialog box.
Comment 2 David Faure 2003-02-02 16:38:26 UTC
Subject: koffice/kword

CVS commit by faure: 

When using our own layout for a QGroupBox, we must remember to reserve row 0
for the title of the groupbox, and to use addRowSpacing( 0, fontHeight / 2 ) on it.
CCMAIL: 53794-done@bugs.kde.org


  M +5 -3      footnotedia.cc   1.31


--- koffice/kword/footnotedia.cc  #1.30:1.31
@@ -51,6 +51,8 @@ KWFootNoteDia::KWFootNoteDia( NoteType _
 
     grp->setExclusive( true );
-    grid->addWidget( m_rbAuto, 0, 0);
-    grid->addWidget( m_rbManual, 1, 0);
+    int fHeight = grp->fontMetrics().height();
+    grid->addRowSpacing( 0, fHeight/2 ); // groupbox title
+    grid->addWidget( m_rbAuto, 1, 0);
+    grid->addWidget( m_rbManual, 2, 0);
     if ( _numberingType == KWFootNoteVariable::Auto )
         m_rbAuto->setChecked( true );
@@ -61,5 +63,5 @@ KWFootNoteDia::KWFootNoteDia( NoteType _
     connect( m_footLine, SIGNAL( textChanged ( const QString & )), this, SLOT(footLineChanged( const QString & )));
     connect( grp, SIGNAL( clicked ( int ) ), this, SLOT(footNoteTypeChanged()));
-    grid->addWidget( m_footLine, 1, 1);
+    grid->addWidget( m_footLine, 2, 1);