Bug 53235 - highlight does not keep nor save changed mime type info
Summary: highlight does not keep nor save changed mime type info
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: kwrite (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-21 16:14 UTC by Peter Soetens
Modified: 2003-01-25 07:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Soetens 2003-01-21 16:14:06 UTC 
Version:            (using KDE KDE 3.0.99)
Installed from:    Debian testing/unstable Packages
Compiler:          2.95 
OS:          Linux

Choosing another mime type for a Highlight mode (C++,...) does not have any effect after the configure dialog box is closed.

to reproduce :

Go to Settings -> Configure Editor -> Highlighting -> Highlight Modes,

Select C++ Highlight,
click the mime type icon,
select any other type,
press OK,
(everything seems to have changed correctly)
press OK,

now recheck the settings again performing the same steps and you will notice that the changes did not stay but reverted to the old settings.

Same with kdevelop 3.0 alpha 2
Comment 1 Hamish Rodda 2003-01-25 06:13:05 UTC 
This is a strange one... if you press apply twice it works ;) 
 
now to track it down...
Comment 2 Hamish Rodda 2003-01-25 07:40:00 UTC 
Subject: kdelibs/kate/part

CVS commit by rodda: 

Fix highlighting changes not getting applied until the second apply.

Needs a backport.

CCMAIL:53235-done@bugs.kde.org


  M +2 -2      katedialogs.cpp   1.43


--- kdelibs/kate/part/katedialogs.cpp  #1.42:1.43
@@ -296,7 +296,7 @@ void HlConfigPage::apply ()
   if (m_ready)
   {
+    page->saveData();
     hlManager->setHlDataList(hlDataList);
     hlManager->setDefaults(defaultStyleList);
-    page->saveData();
   }
 }