Bug 53122 - Changing to block mode status bar doesn't update till select.
Summary: Changing to block mode status bar doesn't update till select.
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-17 22:44 UTC by Joshua Moore-Oliva
Modified: 2003-01-21 05:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Moore-Oliva 2003-01-17 22:44:26 UTC
Version:           2.1 (using KDE 3.1.0 (RC5))
Installed from:    Gentoo
Compiler:          gcc version 3.2.1
OS:          Linux (i686) release 2.4.20

When I change the selection mode From NORM to BLK or BLK to NORM, the status bar doesn't update until I actually start selecting text.
Comment 1 Hamish Rodda 2003-01-21 05:23:43 UTC
Subject: kdelibs/kate/part

CVS commit by rodda: 

Fix for selection type change doesn't update statusbar

Needs a backport.

CCMAIL:53122-done@bugs.kde.org


  M +6 -1      katedocument.cpp   1.418
  M +8 -3      kateview.cpp   1.232
  M +1 -0      kateview.h   1.108


--- kdelibs/kate/part/kateview.cpp  #1.231:1.232
@@ -259,5 +259,5 @@ void KateView::setupActions()
   a->setWhatsThis(i18n("This decreases the display font size."));
 
-  a=new KAction(i18n("T&oggle Block Selection"), Key_F4, m_doc, SLOT(toggleBlockSelectionMode()), ac, "set_verticalSelect");
+  a=new KAction(i18n("T&oggle Block Selection"), CTRL + SHIFT + Key_B, m_doc, SLOT(toggleBlockSelectionMode()), ac, "set_verticalSelect");
   a->setWhatsThis(i18n("This command allows switching between the normal (line based) selection mode and the block selection mode."));
 
@@ -573,4 +573,9 @@ void KateView::slotStatusMsg ()
 
   emit viewStatusMsg (" " + s1 + " " + s2 + " " + ovrstr + " " + blockstr+ " " + modstr);
+}
+
+void KateView::slotSelectionTypeChanged()
+{
+  emit newStatus();
 }
 

--- kdelibs/kate/part/kateview.h  #1.107:1.108
@@ -294,4 +294,5 @@ class KateView : public Kate::View,
     void updateFoldingMarkersAction();
     void slotStatusMsg();
+    void slotSelectionTypeChanged();
     void slotSaveCanceled( const QString& error );
     

--- kdelibs/kate/part/katedocument.cpp  #1.417:1.418
@@ -1358,4 +1358,9 @@ bool KateDocument::setBlockSelectionMode
     clearSelection();
     setSelection(oldSelectStart, oldSelectEnd);
+
+    for (KateView * view = m_views.first(); view; view = m_views.next())
+    {
+      view->slotSelectionTypeChanged();
+    }
   }