Bug 52772 - khelpcenter does not remember location on session restore
Summary: khelpcenter does not remember location on session restore
Status: RESOLVED FIXED
Alias: None
Product: khelpcenter
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Cornelius Schumacher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-09 01:09 UTC by Roger Larsson
Modified: 2004-04-06 17:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
possible patch (878 bytes, patch)
2004-01-10 01:58 UTC, Dominique Devriese
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Larsson 2003-01-09 01:09:29 UTC
Version:           3.1 (using KDE 3.1.9)
Compiler:          gcc version 3.2
OS:          Linux (i686) release 2.4.19-4GB

Had some interesting pages open in two khelpcenters.
But  then I had to log out temporarily.
When I logged in again both were reset to the "Welcome" page.
(probably, I have to recheck this...)
Comment 1 Roger Larsson 2003-12-30 21:42:01 UTC
Rechecked with recent CVS 2003-12-30

Opened KDE Help Center on an page (kioslave audiocd),
log out, end session (do not exit Help Center)
log in - Help Center starts as expected.

But it does not restart with the page where it was left,
worse now it does not even start on the Welcome page!
Comment 2 Dominique Devriese 2003-12-31 04:03:25 UTC
For the record:
domi: ~/src/kdebase/khelpcenter> cvs log -r1.41 mainwindow.cpp        
<snip>
revision 1.41
date: 2003/05/04 16:43:23;  author: mlaurent;  state: Exp;  lines: +23 -1
Fix restore session
=> doesn't create two khelpcenter.

Now it saves url but readProperties doesn't work in khelpcenter
if a people can explain me why ...
=============================================================================


This is where the bug started, I can't debug further because I can't easily test stuff because I don't have a HEAD installation.
Comment 3 Dominique Devriese 2004-01-10 01:58:44 UTC
Created attachment 4074 [details]
possible patch

I *think* that this should fix it, but I cannot test because I don't have a
HEAD installation. 
Can anyone test ?
cheers
domi
Comment 4 Dominique Devriese 2004-01-10 16:22:00 UTC
or better yet: change readPathEntry in that patch to readEntry, and the same for writePathEntry.

cheers
domi
Comment 5 Roger Larsson 2004-01-10 22:28:16 UTC
This is written to the session file, looks OK to me.
But at restart of session I get "Malformed URL"
Read back is probably wrong in some way...

[1]
URL=help:/kioslave/floppy.html

[MainWindow Toolbar style]
Index=0

[Number]
NumberOfWindows=1

[WindowProperties1]
ClassName=KHC::MainWindow
Height 1024=600
ObjectName=MainWindow
Width 1280=800
Comment 6 Roger Larsson 2004-01-10 23:57:06 UTC
Oh, had not seen the modified patch - the test was performed with the old on.
I will retry.
Comment 7 Waldo Bastian 2004-03-10 22:03:27 UTC
I think I fixed this one, can someone verify and close?
Comment 8 Waldo Bastian 2004-04-06 16:44:52 UTC
*** Bug has been marked as fixed ***.
Comment 9 Dominique Devriese 2004-04-06 17:29:42 UTC
Waldo Bastian writes:

> *** Bug has been marked as fixed ***.

When did you fix this ?  I.e. in what release will the fix be present
?

thanks
domi