Bug 52001 - text color toolbar button does not behave as expected
Summary: text color toolbar button does not behave as expected
Status: RESOLVED FIXED
Alias: None
Product: kword
Classification: Miscellaneous
Component: general (show other bugs)
Version: 1.5 or before
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-17 05:58 UTC by donald
Modified: 2006-07-13 12:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description donald 2002-12-17 05:58:40 UTC
Version:           1.2.1 (using KDE KDE 3.0.4)
Installed from:    Gentoo Packages
Compiler:          g++ 3.2.1 CFLAGS="-march=athlon-tbird -O3 -pipe -fforce-addr -fomit-frame-pointer"
OS:          Linux

When selecting a text color from the toolbar, the behavior should be as follows:

1) Clicking on the "drop arrow" part brings up a color chooser of some kind (most likely a palette of discrete colors which contains a "more colors" button that will bring up a color wheel with an eye-dropper tool).

2) Clicking on the main part of the button applies the most recently selected color to the current selection.

3) The "underline" color on the button should show the currently selected color.

The current behavior brings up two different color choosers, one with a discrete palette (when you click on the arrow part), and the other with a continuous color wheel (when you click on the main part). The button face's underline color bar displays the color of the text in which the insertion caret is currently located (which is redundant, as the text color is fairly obvious). To be honest, this behavior is really weird, and it makes trying to mark changes in a document quite difficult. It's annoying having to hold down the button and select a new color every time I mark a change, when I only want the same color over and over.

Thanks you!
Donald
Comment 1 David Faure 2004-07-03 12:27:22 UTC
> 2) Clicking on the main part of the button applies the most recently selected color to the current selection. 
>
> 3) The "underline" color on the button should show the currently selected color.

Hello,
Thanks for the suggestion.
But I don't see how we can have both 2) and 3).
3) is exactly the reason for the current behavior: like all other toolbar buttons, the button reflects the current state of the selection (or the character near the cursor).

Wouldn't it be strange that clicking on a button showing a red color (because the current text is red) would apply a green color?
Some might find it strange that there's no way to see what the button is going to do (OTOH the user remembers which color he applied last, so this isn't a bad idea...). Opinions?
Comment 2 Sven Langkamp 2004-10-25 16:45:37 UTC
2) and 3) are the standard behavior in other word processors.
This also applies to the line and fill button.
Comment 3 Sven Langkamp 2004-11-02 15:18:19 UTC
CVS commit by langkamp: 


Changed color button behavior. The button now remembers the color and applies it on click.
BUG:52001


  M +0 -8      kivio/kiviopart/kivio_view.cpp   1.165
  M +0 -37     kpresenter/kprcanvas.cc   1.441
  M +0 -3      kpresenter/kpresenter_view.cc   1.1067
  M +0 -12     kspread/kspread_view.cc   1.798
  M +0 -1      kword/kwview.cc   1.1051
  M +1 -2      lib/kofficeui/tkcoloractions.cpp   1.31



Comment 4 Maciej Pilichowski 2006-07-13 12:43:38 UTC
Sven, it is two years later and I don't see how it works like suggested. V.1.4.1.

My suggestion. 
1) arrow-down -- bring shortened colors dialog on-fly, works this way now
2) single-click on the main part (left one) -- apply last selected color (doesn't work this way -- opens full color dialog)
3) double click on main part -- bring full color dialog