(*** This bug was imported into bugs.kde.org ***) Package: noatun Version: KDE 3.0.7 CVS/CVSup/Snapshot Severity: crash Installed from: Compiled sources Compiler: gcc 2.95.3 OS: Linux OS/Compiler notes: Not Specified How to reproduce: - select a playlist plugin - close noatun - remove the .so file associated - run noatun *CRASH* #6 0x4162759e in NoatunStdAction::PlaylistAction::PlaylistAction () from /usr/local/kde3/lib/libnoatun.so.0 #7 0x4162820c in NoatunStdAction::playlist () from /usr/local/kde3/lib/libnoatun.so.0 #8 0x4233ab78 in NoatunSystray::NoatunSystray () from /usr/local/kde3/lib/kde3/noatun_systray.so #9 0x4233c121 in create_plugin () from /usr/local/kde3/lib/kde3/noatun_systray.so #10 0x41620092 in LibraryLoader::loadSO () from /usr/local/kde3/lib/libnoatun.so.0 #11 0x4161f7df in LibraryLoader::loadAll () from /usr/local/kde3/lib/libnoatun.so.0 #12 0x41620873 in LibraryLoader::loadAll () from /usr/local/kde3/lib/libnoatun.so.0 #13 0x4161ea2a in NoatunApp::loadPlugins () from /usr/local/kde3/lib/libnoatun.so.0 #14 0x4161c5bc in NoatunApp::NoatunApp () from /usr/local/kde3/lib/libnoatun.so.0 #15 0x40ce51dc in main () from /usr/local/kde3/lib/kde3/noatun.so #16 0x804d109 in launch () #17 0x804dff8 in handle_launcher_request () #18 0x804e5ab in handle_requests () #19 0x804f4ff in main () #20 0x40f0e71f in __libc_start_main () from /lib/libc.so.6 (Submitted via bugs.kde.org)
just fixed it.
You think you fixed it Njaard ;) I still see this bug. I didn't verify if it is the case with every plugin but it looks like that. The fix should probably be a little involved: 1) If a plugin cannot be found in playlist or GUI category a default plugin must be sought. 1a) Failing that, any plugin in that category should be sought. 2) Failing to find a proper plugin a suitable error message should be produced 2a) If it is a _vital_ plugin then an appropriate error message should be produced and the program should quit 2b) If it isn't a vital plugin the program should report this incident (plugin X not found) and commence operation. Greetings to all noatun hackers who are willing to fix this (^_^) More detailed information following soon. Ouch. mETz claims there is in fact a fallback to split playlist for playlist plugins. I must investigate!
I can't replicate the bug I'm closing. I swear I saw it but maybe I just thought I'd seen something. :) Now Njaard will pick on me ;)
mETz says if split is not found it's gonna crash. This means reopen again. The fix I suggested prior to this still makes sense. Silent fail and crash conditions must be eliminated! We can use those new fancy info boxes to inform the user or message boxes in which you must click "OK" (wow I forgot all about kdelibs names :)
Noatun should be allowed to rely on the plugins it ships with being installed, though. If you remove SPL it's your own fault, and Noatun shouldn't have to be bloated with code to coddle your breaking it.
All I know is it should be near-impossible to crash a user friendly app!
I think it's reasonable to have it crash if it can't find a plugin that ships with noatun by default. The default plugin even.
Charles is right, but still I'd expect the most general form of a plugin manager to be wary of all system-level errors. Cheers,
I have a patch for this, eventually I'll sort out all my noatun changes and attach it here for others to test. Btw, it shouldn't crash, install errors are quite common with all these broken distros out there
I'll commit a fix after KDE 3.2, I'm not allowed to add new strings right now.