Bug 45415 - xmlgui files with <?xml...?> line break custom shortcuts
Summary: xmlgui files with <?xml...?> line break custom shortcuts
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Other
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-18 06:03 UTC by Thomas Zander
Modified: 2004-05-17 20:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander 2002-07-18 05:43:56 UTC
package: kmail
version: CVS 14-Jul

I changed the keyboard shortcut 'next unread text...' to use 'tab'. This wo=
rks
this session but when I restart KMail the key is reset to the default (whic=
h=20
is space).
--=20
Thomas Zander                                           zander@planescape.c=
om
                                                 We are what we pretend to =
be
Comment 1 Thomas Zander 2002-07-18 05:43:56 UTC
(*** This bug was imported into bugs.kde.org ***)

package: kmail
version: CVS 14-Jul

I changed the keyboard shortcut 'next unread text...' to use 'tab'. This wo=
rks
this session but when I restart KMail the key is reset to the default (whic=
h=20
is space).
--=20
Thomas Zander                                           zander@planescape.c=
om
                                                 We are what we pretend to =
be
Comment 2 Ingo Klöcker 2002-07-18 20:33:47 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 18 July 2002 07:43 Thomas Zander wrote:
> I changed the keyboard shortcut 'next unread text...' to use 'tab'.
> This works this session but when I restart KMail the key is reset to
> the default (which is space).

Here is works (KMail HEAD from yesterday kdelibs BRANCH from Jul-11).

What I tried: I changed the shortcut for 'next unread text...' to Tab 
confirmed that it works exited KMail restarted KMail and confirmed 
that the Tab key still works.

Please check if the keybinding is written to 
~/.kde/share/apps/kmail/kmmainwin.rc after you configured it.

Regards
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9NyY1GnR+RTDgudgRApBwAJ9GEThjkOUqm3Ot+cnJBZYF1GoVmgCfU+hw
ZKpiD53KhY7UHiATyBadSt8=
=Iqbd
-----END PGP SIGNATURE-----
Comment 3 Thomas Zander 2002-07-18 20:53:15 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm afrraid that in the file you point out only the XMLGui stuff is saved =
not=20
changes in keyboard shortcuts are present there.


On Thursday 18 July 2002 22:33 Ingo Kl=F6cker wrote:
> On Thursday 18 July 2002 07:43 Thomas Zander wrote:
> > I changed the keyboard shortcut 'next unread text...' to use 'tab'.
> > This works this session but when I restart KMail the key is reset to
> > the default (which is space).
>
> Here is works (KMail HEAD from yesterday kdelibs BRANCH from Jul-11).
>
> What I tried: I changed the shortcut for 'next unread text...' to Tab
> confirmed that it works exited KMail restarted KMail and confirmed
> that the Tab key still works.
>
> Please check if the keybinding is written to
> ~/.kde/share/apps/kmail/kmmainwin.rc after you configured it.
>
> Regards
> Ingo

- --=20
Thomas Zander                                           zander@planescape.c=
om
                                                 We are what we pretend to =
be
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9NyrACojCW6H2z/QRAij6AJwNTBhKkhUOvYb5jwakSPgm2kC0jwCgveFb
n1E1yvyTjn+I6JUqE0EbTk8=3D
=3DyW4o
-----END PGP SIGNATURE-----
Comment 4 Ingo Klöcker 2002-07-18 23:33:37 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 18 July 2002 22:53 Thomas Zander wrote:
> I'm afrraid that in the file you point out only the XMLGui stuff is
> saved not changes in keyboard shortcuts are present there.

Well then this is obviously no KMail problem but a problem of the 
underlying libs. Please reassign this bug report to a package which you 
think is appropriate.

Regards
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9N1BRGnR+RTDgudgRAoIBAKCfDFQlgByrT6IuouGUmaaMSNrJpwCg3HWP
87OWbm5DAjHAaqku9sisnJo=
=bL9h
-----END PGP SIGNATURE-----
Comment 5 Ladislav Strojil 2002-07-19 07:44:30 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 19 July 2002 01:33 Ingo Kl=F6cker wrote:
> On Thursday 18 July 2002 22:53 Thomas Zander wrote:
> > I'm afrraid that in the file you point out only the XMLGui stuff is
> > saved not changes in keyboard shortcuts are present there.
>
> Well then this is obviously no KMail problem but a problem of the
> underlying libs. Please reassign this bug report to a package which you
> think is appropriate.

Strange because in eg. Konqueror and Kate shortcuts do get saved and resto=
red=20
properly.

Cheers
Lada

- --=20
    ~       Ladislav Strojil MFF UK
  ' v '=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
 //   \\=20=20=20=20=20=20=20=20=20=20=20=20=20=20
/(     )\    Powered by Penguin.
  ^ ' ^
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9N8NfTnMZPFqq4nwRAlVKAJ0dav6Xqk9jr6um6nkObrTs85PcvgCfTE0a
ucrjf2A3U48m5liiTay0qRA=3D
=3D+YyE
-----END PGP SIGNATURE-----
Comment 6 Ingo Klöcker 2002-07-21 12:56:19 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 19 July 2002 09:44 Ladislav Strojil wrote:
> On Friday 19 July 2002 01:33 Ingo Klöcker wrote:
> > On Thursday 18 July 2002 22:53 Thomas Zander wrote:
> > > I'm afrraid that in the file you point out only the XMLGui stuff
> > > is saved not changes in keyboard shortcuts are present there.
> >
> > Well then this is obviously no KMail problem but a problem of the
> > underlying libs. Please reassign this bug report to a package which
> > you think is appropriate.
>
> Strange because in eg. Konqueror and Kate shortcuts do get saved and
> restored properly.

Yeah strange.

Please add the following kdDebug to KMMainWin::slotEditKeys() recompile 
KMail start KMail and select Settings->Configure Shortcuts...
=====
void KMMainWin::slotEditKeys()
{
+  kdDebug(5006) << "KMMainWin::slotEditKeys(): xmlFile() returns >"
+                << xmlFile() << "<\n";
  KKeyDialog::configureKeys(actionCollection() xmlFile() true this);
}
=====

Here xmlFile() returns >kmmainwin.rc<.

Regards
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9Oq94GnR+RTDgudgRArwjAJwKsnGRZS0ncbehf0ZC2T/luCkFDACgqLNy
Cf5JBbcGUqEk0G8qEe7LUmI=
=9b3T
-----END PGP SIGNATURE-----
Comment 7 Ladislav Strojil 2002-07-21 16:01:15 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 21 July 2002 14:56 Ingo Kl=F6cker wrote:
> Please add the following kdDebug to KMMainWin::slotEditKeys() recompile
> KMail start KMail and select Settings->Configure Shortcuts...
> =3D=3D=3D=3D=3D
> void KMMainWin::slotEditKeys()
> {
> +  kdDebug(5006) << "KMMainWin::slotEditKeys(): xmlFile() returns >"
> +                << xmlFile() << "<\n";
>   KKeyDialog::configureKeys(actionCollection() xmlFile() true this);
> }
> =3D=3D=3D=3D=3D
>
> Here xmlFile() returns >kmmainwin.rc<.

Here it is the same. kmmainwin.rc

I tried deleting my kmailrc and kmmainwin.rc files but this did not help.
Both files were however recreated OK (so it's not about corrupted content o=
r=20
about wrong permissions).

No idea what is wrong.

Cheers
Lada

- --=20
    ~       Ladislav Strojil MFF UK
  ' v '=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
 //   \\=20=20=20=20=20=20=20=20=20=20=20=20=20=20
/(     )\    Powered by Penguin.
  ^ ' ^
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9OtrNTnMZPFqq4nwRAotyAKDinYFqWlFWOoK8Ltn/XyrI149pwQCeOSPK
JB+VKhZnVM+TODyF2u15c5w=3D
=3DieqC
-----END PGP SIGNATURE-----
Comment 8 Thomas Zander 2002-07-21 16:43:57 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 21 July 2002 14:56 Ingo Kl=F6cker wrote:
> On Friday 19 July 2002 09:44 Ladislav Strojil wrote:
> > On Friday 19 July 2002 01:33 Ingo Kl=F6cker wrote:
> > > On Thursday 18 July 2002 22:53 Thomas Zander wrote:
> > > > I'm afraid that in the file you point out only the XMLGui stuff
> > > > is saved not changes in keyboard shortcuts are present there.
> > >
> > > Well then this is obviously no KMail problem but a problem of the
> > > underlying libs. Please reassign this bug report to a package which
> > > you think is appropriate.
> >
> > Strange because in eg. Konqueror and Kate shortcuts do get saved and
> > restored properly.
>
> Yeah strange.
>
> Please add the following kdDebug to KMMainWin::slotEditKeys() recompile
> KMail start KMail and select Settings->Configure Shortcuts...
> =3D=3D=3D=3D=3D
> void KMMainWin::slotEditKeys()
> {
> +  kdDebug(5006) << "KMMainWin::slotEditKeys(): xmlFile() returns >"
> +                << xmlFile() << "<\n";
>   KKeyDialog::configureKeys(actionCollection() xmlFile() true this);
> }

Did you notice that KKeyDialog::configureKeys is deprecated (at least in=20
HEAD)? Maybe the way you use the dialog or use these keys in general has=
=20
gotten broken in kdelibs.

CC-ing Ellis since he knows most about this stuff.
IIRC he's on holiday now so any solution is still appriciated!

Thanx.

- --=20
Thomas Zander                                           zander@planescape.c=
om
                                                 We are what we pretend to =
be
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9OuTQCojCW6H2z/QRAnImAJ9R9uaaPAsSGd++n5ox6yS+LIL/cACgwIEi
8eKUtP4dSUn0tQ/YYOLeKc8=3D
=3DBJbG
-----END PGP SIGNATURE-----
Comment 9 Marc Mutz 2002-07-23 10:52:33 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 21 July 2002 18:43 Thomas Zander wrote:
<snip>
> Did you notice that KKeyDialog::configureKeys is deprecated (at least
> in HEAD)? Maybe the way you use the dialog or use these keys in
> general has gotten broken in kdelibs.
>
> CC-ing Ellis since he knows most about this stuff.
> IIRC he's on holiday now so any solution is still appriciated!
<snip>

As you know the shortcuts stick in the composer but not in the=20
mainwindow.

I've just commited the configureKeys() -> configure() change but even=20
if the calls to the key dialog are now identical it still works in the=20
composer and doesn't in the mainwindow. Maybe I should grep both=20
classes for uses of xmlFile() and actionCollection() to see where a=20
difference lies. Oh wait:

$ head -n3 kmcomposerui.rc kmmainwin.rc
=3D=3D> kmcomposerui.rc <=3D=3D
<!DOCTYPE kpartgui ><kpartgui version=3D"8" name=3D"kmcomposer" >
 <MenuBar>
  <Menu noMerge=3D"1" name=3D"file" >

=3D=3D> kmmainwin.rc <=3D=3D
<?xml version=3D"1.0" encoding=3D"utf-8"?>
<!DOCTYPE kpartgui>
<kpartgui version=3D"37" name=3D"kmmainwin" >

That can't be it can it???

Marc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9PTV93oWD+L2/6DgRAsEdAKCd+taF0ySJIA4pwh8y2ZLtIUziMwCeMi1R
xNgdEnRwloGTddo0XxSjxaM=3D
=3DxfAM
-----END PGP SIGNATURE-----
Comment 10 Marc Mutz 2002-07-23 11:22:47 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 23 July 2002 12:52 Marc Mutz wrote:
<snip>
> $ head -n3 kmcomposerui.rc kmmainwin.rc
> =3D=3D> kmcomposerui.rc <=3D=3D
> <!DOCTYPE kpartgui ><kpartgui version=3D"8" name=3D"kmcomposer" >
>  <MenuBar>
>   <Menu noMerge=3D"1" name=3D"file" >
>
> =3D=3D> kmmainwin.rc <=3D=3D
> <?xml version=3D"1.0" encoding=3D"utf-8"?>
> <!DOCTYPE kpartgui>
> <kpartgui version=3D"37" name=3D"kmmainwin" >
>
> That can't be it can it???
<snip>

It can! KKeyDialog or something which it uses chokes on the xml=20
declaration in the first line of kmmainwin.rc. Here "choke" \subseteq=20
refuse to save or restore custom shortcuts.

Marc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9PTyH3oWD+L2/6DgRApIOAJ9QdVsNwtTtYotwCqnsyWeYiLcjywCgoqcR
rQjXn+kxSKUE5P+u5YPEWl0=3D
=3D0NrF
-----END PGP SIGNATURE-----
Comment 11 Stephan Kulow 2002-09-21 20:30:09 UTC
checking that 
Comment 12 Thomas Zander 2002-09-21 21:41:46 UTC
This works for about 2 weeks (or more) allready. 
Comment 13 Stephan Kulow 2002-09-21 22:08:10 UTC
it doesn't here 
Comment 14 Thomas Zander 2002-09-21 22:17:53 UTC
Hmm.. I did remove my config files (all of ~/.kde3) so that might be why it 
works here... 
No idea :( 
Comment 15 Stephan Kulow 2002-09-21 22:43:01 UTC
Subject: kdelibs/kdeui

kdelibs/kdeui kaction.cpp,1.290,1.291
Author: coolo


Modified Files:
         kaction.cpp
Log Message:
If there is a XML declaration as first line, firstChild() != documentElement
-               doc.firstChild().appendChild( elem );
+               doc.documentElement().appendChild( elem );
CCMAIL: 45415-close@bugs.kde.org