Bug 434948 - "Tasks" progress resets for each separate task
Summary: "Tasks" progress resets for each separate task
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: 5.24.5
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 454521 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-25 17:50 UTC by David
Modified: 2022-10-13 16:08 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David 2021-03-25 17:50:14 UTC
SUMMARY
When I'm installing some software through e.g. FlatPak, the "taskS" progress bar at the bottom-left will reset and run again every time a "task" is completed, which is misleading since it's called "tasks" in plural, and as such should show global progress and not task-by-task progress.

STEPS TO REPRODUCE
1. Download some app with dependencies from flathub through a .flatpakref file.
2. Install said file through discover.
3. Watch installation progress.

OBSERVED RESULT
The "tasks" bar runs multiple times from start to finish, for each separate "task" (e.g. downloading a file, installing said file).

EXPECTED RESULT
The "tasks" bar should report global progress across all steps needed to get the app installed.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-03-25 21:02:57 UTC
Yup, can confirm. This jumpiness kind of drives me crazy. :)
Comment 2 silopolis 2022-07-09 17:32:34 UTC
Still there in 5.24.5 on Kali
Comment 3 Nate Graham 2022-09-23 19:44:11 UTC
*** Bug 454521 has been marked as a duplicate of this bug. ***
Comment 4 Aleix Pol 2022-10-13 15:57:20 UTC
Git commit 8226ddf15fd7f04b18fc2d2f571215b695a9b2bb by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 13/10/2022 at 15:52.
Pushed by apol into branch 'master'.

flatpak: Address transaction progress skipping

Flatpak transaction progress skips back and forth as it is reported
according its different operations.
Report the progress according equally split among the different
operations.
Related: bug 404819, bug 435450, bug 448280

M  +10   -4    libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp
M  +3    -0    libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.h
M  +6    -0    libdiscover/backends/FlatpakBackend/tests/FlatpakTest.cpp

https://invent.kde.org/plasma/discover/commit/8226ddf15fd7f04b18fc2d2f571215b695a9b2bb
Comment 5 Nate Graham 2022-10-13 16:07:41 UTC
Git commit 336becd3ad0f8aa5b18d3c61b38c15d81a3f3544 by Nate Graham, on behalf of Aleix Pol.
Committed on 13/10/2022 at 16:07.
Pushed by ngraham into branch 'Plasma/5.26'.

flatpak: Address transaction progress skipping

Flatpak transaction progress skips back and forth as it is reported
according its different operations.
Report the progress according equally split among the different
operations.
Related: bug 404819, bug 435450, bug 448280


(cherry picked from commit 8226ddf15fd7f04b18fc2d2f571215b695a9b2bb)

M  +10   -4    libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp
M  +3    -0    libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.h
M  +6    -0    libdiscover/backends/FlatpakBackend/tests/FlatpakTest.cpp

https://invent.kde.org/plasma/discover/commit/336becd3ad0f8aa5b18d3c61b38c15d81a3f3544