Bug 42717 - interlaced PNGs are not displayed interlaced
Summary: interlaced PNGs are not displayed interlaced
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml image part (other bugs)
Version First Reported In: 4.0
Platform: Mandrake RPMs Linux
: VLO normal
Target Milestone: ---
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-17 13:03 UTC by Helge Hielscher
Modified: 2007-12-11 16:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Hielscher 2002-05-17 13:01:29 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           khtml
Version:           4.0 (using KDE 3.0.0 )
Severity:          wishlist
Installed from:    Mandrake RPMs
Compiler:          gcc version 2.96 20000731 (Mandrake Linux 8.2 2.96-0.76mdk)
OS:                Linux (i686) release 2.4.18-6mdk
OS/Compiler notes: 

This is an RFE to display interlaced PNG images gradually. At the moment konqueror downloads the whole picture first and displays it afterwards.

I have put 3 PNGs with Adam7 interlacing at
http://www.uni-weimar.de/~hielsch1/png-test/

(Submitted via bugs.kde.org)
(Called from KBugReport dialog. Fields KDE Version manually changed)
Comment 1 Unknown 2002-09-17 10:08:02 UTC
This would actually require re-writing a png loader in KDE (hence the change    
of priority) . But the much better fix would be if Qt's png loader was    
incremental, so actually this could be considered a Qt bug. 
Comment 2 S Leiber 2003-06-09 19:49:53 UTC
Have we annover testpage to test this bug later? The page that was here in the 
bug is not online!! 
 
Sven 
 
Comment 3 Helge Hielscher 2003-06-09 21:56:29 UTC
Seems like the main server is down. But the alternative server is still working. Use
http://gonzo.uni-weimar.de/~hielsch1/png-test/ 

Regards,
Helge
Comment 4 Nicolas Goutte 2003-12-21 23:07:25 UTC
An Adam7-interlaced PNG is: http://www.koffice.org/kword/pics/kword_classic_picture.png (The small version of the picture is in Adam7 too.)

All this can be accessed by http://www.koffice.org/kword/screenshots.php

(If you need more Adam7 files, you can use Gimp.)

Have a nice day!
Comment 5 Leo Savernik 2004-02-10 15:27:34 UTC
Still valid as of KDE 3.2
Comment 6 Nicolas Goutte 2004-02-17 02:20:42 UTC
I am increasing the severity of this bug report from "wishlist" to "bug".

The reason is that QImageDecoder::inputFormats() claims to know PNG, so incremental decoding and displaying of PNG files should work now, as JPEG files are using the same mechanism.

(I have not tested with Qt alone, so I cannot be sure if the real problem would not be in Qt.)

Have a nice day!
Comment 7 Nicolas Goutte 2004-02-20 18:17:51 UTC
Well, we have a conflict here.

Qt has everything the whole code to do progreesive loading, inclusive Adam7-interlaced, but it announces that it is finished, when the whole image is finished. :-(

(I do not knwo how to bug Trolltech without getting an answer of the type: "That was not our intend. If anybody has an idea...)

Have a nice day!
Comment 8 Michael Jahn 2004-07-02 11:37:04 UTC
This works for me using KDE 3.2.3 + QT 3.3.2. Can you still reproduce this?
Comment 9 Helge Hielscher 2004-07-02 11:55:19 UTC
WFM/KDE 3.2.3 & qt3-common-3.3.2-16mdk
Comment 10 Nicolas Goutte 2004-07-02 12:06:30 UTC
Do you can really see it progressively?

Sorry, I do not, not even with KDE CVS HEAD (and I have a Qt snapshot that is post-Qt 3.3.2, so it should not be the problem either.)

Have a nice day!
Comment 11 Helge Hielscher 2004-07-02 14:56:01 UTC
Yes, I could see it progressively, but Konqueror was using gwenview's kpart. Now I changed the settings back to "Embeddable Image Viewer" and now it does not load progressively anymore. Reopening.
Comment 12 Helge Hielscher 2004-07-02 17:22:10 UTC
Added pngtest.html to http://www.uni-weimar.de/~hielsch1/png-test/ for easier testing.
Konqueror is always using its internal PNG viewer, if the PNGs are wrapped inside an HTML-Document.
Comment 13 Michael Jahn 2004-07-03 10:29:00 UTC
> Konqueror is always using its internal PNG viewer, if the PNGs are wrapped inside an HTML-Document. 

If this is true then I have mysterious KDE/QT sources that don't exist ;-)
Because the images are also loaded progressively within the html. It is very slow and X consumes 100% (similar to the now closed bug when loading large images) while loading but they _are_ loaded progressively. Gwenview's kpart does not exhibit this slowness.

Let's see:
KDE_3_2_BRANCH and QT snapshot from 2004-06-30
libpng 1.2.5
qt configured with -system-libpng
Comment 14 Helge Hielscher 2004-07-03 15:56:40 UTC
Tested it a bit more, using Konqueror with embeded viewers set to: 1st Gwenview's KPart 2nd embedded image viewer. Cache set to off.
If I start a new intance of konqueror and open http://www.uni-weimar.de/~hielsch1/png-test/pngtest.html the PNGs are rendered non-interlaced.
But if I open http://www.uni-weimar.de/~hielsch1/png-test/falten1.png first and then http://www.uni-weimar.de/~hielsch1/png-test/pngtest.html the PNGs inside of the HTML are rendered progressively.

kdebase-3.2.3-9mdk, qt3-common-3.3.2-17mdk, libpng3-1.2.5-11mdk, gwenview_hack-1.1.3-0.1mdk
Comment 15 Nicolas Goutte 2004-10-31 16:35:26 UTC
If it works with Gwenview, then perhaps the code has to be moved to be able to use it without Gwenview too.

Have a nice day!
Comment 16 Maksim Orlovich 2005-06-19 01:48:31 UTC
most likely will work in 4.0
Comment 17 FiNeX 2007-12-11 16:39:49 UTC
It works both in KDE 3.5 and KDE4.
The image are loaded progressively as expected.