Bug 396170 - Gallery creation error
Summary: Gallery creation error
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Plugins (show other bugs)
Version: 5.9.0
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-04 16:19 UTC by Chris N D
Modified: 2022-02-04 22:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments
bridge photo - still image with exif info (1.71 MB, image/jpeg)
2018-07-18 14:54 UTC, Chris N D
Details
dance image from mp4 - no exif info (203.16 KB, image/jpeg)
2018-07-18 14:55 UTC, Chris N D
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris N D 2018-07-04 16:19:16 UTC
Generating a gallery in showfoto sometimes ends with the following error:
"could not load xml file '<filename + location>'". Everything appears to be ok except there is no index.html file created. There *is* a gallery.xml file.

I have created a lot of galleries successfully over the last couple of months and, 
after trying different photo selections I have come to the conclusion that this error only occurs when at least one of the images is from a screen grab!

I am using PaintShopPro 8 for the screen grabs. Maybe I should try something else? - but I don't see why, it functions perfectly well with all other images!

Please advise
Comment 1 Chris N D 2018-07-05 16:08:45 UTC
I have found a 'workaround' for this problem. Its a bit tedious but it works, viz:
1. Use showphoto with all the photos to create folders and thumbnails. 
2. When it fails, repeat procedure but without the images that cause the failure.
3. Edit the index.html file to add in all the other images with their respective thumbnails.

It still doesn't explain why the program thinks some of the images are dodgy though. Is it looking for particular tags somewhere?

Chris
Comment 2 Chris N D 2018-07-18 09:47:07 UTC
I've looked more deeply at this now and tried other photo groups. 
It seems the HTML gallery function will fail if any photo has no EXIF information.  This should not happen surely?  
Given that it does (for now), what is the minimum EXIF info I need add?
Comment 3 caulier.gilles 2018-07-18 11:23:20 UTC
Can you share some photo that have "no Exif" info from your collection. This is a little bit strange, and of course this must be happen...

Gilles Caulier
Comment 4 Maik Qualmann 2018-07-18 12:19:41 UTC
Yes, sample images with which the error occurs would be very helpful. I can not reproduce the problem even with images that are complete without EXIF, IPTC or XMP metadata.

Maik
Comment 5 Chris N D 2018-07-18 14:54:28 UTC
Created attachment 114001 [details]
bridge photo - still image with exif info

This is a still image which quite happily produces a gallery...
Comment 6 Chris N D 2018-07-18 14:55:41 UTC
Created attachment 114002 [details]
dance image from mp4 - no exif info

This is one without exif info
Comment 7 Chris N D 2018-07-18 14:57:29 UTC
Here are two images. The one of the dancers on the bridge is from a camera still and has exif info. The other in the courtyard is a screen gab from an mp4 video with no exif info...
Comment 8 Maik Qualmann 2018-07-18 20:32:43 UTC
Git commit 4219435ac9f10b8061f7658bbefbb85516a9ec31 by Maik Qualmann.
Committed on 18/07/2018 at 20:31.
Pushed by mqualmann into branch 'master'.

fix broken JFIF comment, remove non printable characters from the string
Related: bug 140374
FIXED-IN: 6.0.0

M  +3    -1    NEWS
M  +18   -1    core/libs/dmetadata/metaengine_p.cpp

https://commits.kde.org/digikam/4219435ac9f10b8061f7658bbefbb85516a9ec31
Comment 9 Maik Qualmann 2018-07-18 20:37:24 UTC
Note: To fix the problem with the gallery, you still have to re-read the metadata of the images.

Maik
Comment 10 Chris N D 2018-07-20 14:48:41 UTC
Thanks. I look forward to the 6.x.x release
:-)
Comment 11 caulier.gilles 2018-07-20 14:59:11 UTC
I will generate a new 6.0.0 AppImage pre-release while this week end. You will be able to test quickly.

Gilles Caulier