Bug 372676 - julia backend doesn't build
Summary: julia backend doesn't build
Status: RESOLVED FIXED
Alias: None
Product: cantor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Filipe Saraiva
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-19 17:47 UTC by Antonio Rojas
Modified: 2016-12-02 21:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 16.11.90


Attachments
Proposed patch (724 bytes, patch)
2016-11-22 21:57 UTC, Christoph Feck
Details
Proposed patch (1.11 KB, patch)
2016-11-22 22:03 UTC, Christoph Feck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2016-11-19 17:47:16 UTC
The julia backend fails to build in 16.12 beta with the error

[ 77%] Building CXX object src/backends/julia/tests/CMakeFiles/testjulia.dir/testjulia.cpp.o
In file included from /build/cantor/src/cantor-16.11.80/src/backends/julia/tests/testjulia.cpp:20:0:
/build/cantor/src/cantor-16.11.80/src/backends/julia/tests/testjulia.h:22:25: fatal error: backendtest.h: No such file or directory
 #include <backendtest.h>
                         ^
compilation terminated.

Also, please make building tests conditional on the BUILD_TESTING cmake variable.
Comment 1 Christoph Feck 2016-11-22 21:57:12 UTC
Created attachment 102398 [details]
Proposed patch

Could you please test attached patch? I have neither 'julia' nor 'python3' installed.
Comment 2 Christoph Feck 2016-11-22 22:03:17 UTC
Created attachment 102399 [details]
Proposed patch

(updated to respect the BUILD_TESTING variable)
Comment 3 Antonio Rojas 2016-11-22 22:22:26 UTC
Yes, the patch fixes the build (with and without building tests)
Comment 4 Antonio Rojas 2016-11-29 18:36:53 UTC
Git commit e071d41a88f018ce9fdb0c8eb774b61226daaff9 by Antonio Rojas.
Committed on 29/11/2016 at 18:33.
Pushed by arojas into branch 'Applications/16.12'.

Honor BUILD_TESTING cmake variable in julia backend

Differential Revision: https://phabricator.kde.org/D3441

M  +3    -1    src/backends/julia/CMakeLists.txt

https://commits.kde.org/cantor/e071d41a88f018ce9fdb0c8eb774b61226daaff9
Comment 5 Antonio Rojas 2016-11-29 18:39:25 UTC
Git commit cf08414f30309c784106ea86d526ff370142e2af by Antonio Rojas.
Committed on 29/11/2016 at 18:39.
Pushed by arojas into branch 'master'.

Honor BUILD_TESTING cmake variable in julia backend

Differential Revision: https://phabricator.kde.org/D3441

M  +3    -1    src/backends/julia/CMakeLists.txt

https://commits.kde.org/cantor/cf08414f30309c784106ea86d526ff370142e2af
Comment 6 Antonio Rojas 2016-12-02 11:01:24 UTC
This was only an issue if BUILD_TESTING was off, so it should be good now that the variable is honored