Bug 368724 - Complete cursor list is not enumerated -- /usr/share/cursors/xorg-x11 missing
Summary: Complete cursor list is not enumerated -- /usr/share/cursors/xorg-x11 missing
Status: RESOLVED FIXED
Alias: None
Product: kde-gtk-config
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Manuel Tortosa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 01:33 UTC by Jason A. Donenfeld
Modified: 2019-04-23 17:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jason A. Donenfeld 2016-09-13 01:33:19 UTC 
In cursorthemesmodel.cpp, /usr/share/icons/*/cursors is consulted for the list of all available system cursors. However, it does not consult /usr/share/cursors/xorg-x11. The fix is rather easy:

    availableIcons << dirs += QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "cursors/xorg-x11", QStandardPaths::LocateDirectory).toSet();

Reproducible: Always
Comment 1 Jason A. Donenfeld 2016-09-13 01:33:43 UTC 
Urg.

    availableIcons <<  QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, "cursors/xorg-x11", QStandardPaths::LocateDirectory);

There we go.
Comment 2 Jason A. Donenfeld 2016-09-13 02:15:53 UTC 
Sorry for the noise. Fixed this myself.

http://commits.kde.org/kde-gtk-config/43323a188f17822cc7b26055b70e1e79cd50fc23
Comment 3 Aleix Pol 2016-09-13 10:41:21 UTC 
I'm reverting the commits. Please open a review request like anyone of us does instead of pushing random chunks of code to git.
Comment 4 Jason A. Donenfeld 2016-09-13 11:50:05 UTC 
Sorry about that. It's been a while.

Here we go: https://git.reviewboard.kde.org/r/128897/diff/1/
Comment 5 Jason A. Donenfeld 2016-09-13 12:04:54 UTC 
Erm, rather, look at this and click diff to see the latest push: https://git.reviewboard.kde.org/r/128897
Comment 6 Nate Graham 2019-04-23 17:55:45 UTC 
The patch was accepted and merged; marking this as fixed.