The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen. Can somebody please have a look at this? The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet. I tested it on my Lenovo Thinkpad Yoga, and it works nicely. The patch needs some infrastructure from https://git.reviewboard.kde.org/r/126809/ On request, I can easily extract that infrastructure into a separate patch, or include it with this one here. Unfortunately, I can't get ReviewBoard to accept the patch file. The error message is "The uploaded diff uses short revisions, but Review Board requires full revisions. Please generate a new diff using the --full-index parameter." And when doing as told, I get "The specified diff file could not be parsed. Line undefined: fatal: git cat-file 36b31779250246b13f1096f0af443027058d989e: bad file " Any ideas? Reproducible: Always
Created attachment 100602 [details] Implement zooming with a two-finger pinch gesture on a touch screen. Needs the framework branch and https://git.reviewboard.kde.org/r/126809/
I managed to upload the patch to reviewboard after all: https://git.reviewboard.kde.org/r/128821/ Unlike the patch that I attached above, the one at reviewboard applies directly to the frameworks branch, and contains all necessary gesture-grabbing infrastructure. Therefore, https://git.reviewboard.kde.org/r/126809/ is not needed. Instead, the two will conflict. I'll update one as soon as the other one is committed.
Git commit 9d90a08ef5e22d682a5a5004128f72d1a5a84aff by Martin T. H. Sandsmark. Committed on 15/10/2016 at 13:22. Pushed by sandsmark into branch 'frameworks'. Implement zooming with a pinch gesture on a touch screen Patch by Oliver Sander <oliver.sander@tu-dresden.de> REVIEW: 128821 M +49 -0 ui/pageview.cpp M +5 -0 ui/pageview.h http://commits.kde.org/okular/9d90a08ef5e22d682a5a5004128f72d1a5a84aff