Bug 366010 - Main menu bar is not translated (localized)
Summary: Main menu bar is not translated (localized)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-i18n (show other bugs)
Version: 5.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-23 11:03 UTC by Lukas Sommer
Modified: 2021-12-30 16:09 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0


Attachments
screenshot.1.png (58.30 KB, image/png)
2016-07-23 11:04 UTC, Lukas Sommer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Sommer 2016-07-23 11:03:22 UTC
The main menu bar in digikam and in showPhoto is not translated. Everything is in english.

However, the submenus and all the rest of the application is correctly translated.

Reproducible: Always
Comment 1 Lukas Sommer 2016-07-23 11:04:09 UTC
Created attachment 100260 [details]
screenshot.1.png
Comment 2 caulier.gilles 2016-07-23 11:11:04 UTC
*** Bug 365694 has been marked as a duplicate of this bug. ***
Comment 3 Maik Qualmann 2016-07-24 10:43:38 UTC
Git commit 6119e94222d0e88312c1ea08828b634d7c394e0e by Maik Qualmann.
Committed on 24/07/2016 at 10:42.
Pushed by mqualmann into branch 'master'.

fix untranslated menu items
FIXED-IN: 5.1.0

M  +2    -1    NEWS
M  +1    -1    app/main/digikamui.rc
M  +1    -1    imageplugins/color/digikamimageplugin_color_ui.rc
M  +1    -1    imageplugins/decorate/digikamimageplugin_decorate_ui.rc
M  +1    -1    imageplugins/enhance/digikamimageplugin_enhance_ui.rc
M  +1    -1    imageplugins/filters/digikamimageplugin_fxfilters_ui.rc
M  +1    -1    imageplugins/transform/digikamimageplugin_transform_ui.rc
M  +1    -1    showfoto/main/showfotoui.rc
M  +1    -1    utilities/imageeditor/main/digikamimagewindowui.rc
M  +2    -2    utilities/importui/main/importui.rc
M  +1    -1    utilities/lighttable/lighttablewindowui.rc
M  +2    -2    utilities/queuemanager/main/queuemgrwindowui.rc

http://commits.kde.org/digikam/6119e94222d0e88312c1ea08828b634d7c394e0e
Comment 4 caulier.gilles 2016-07-24 12:18:56 UTC
Maik, 

Do you see this patch too ?

https://git.reviewboard.kde.org/r/128512/diff/1/

Gilles
Comment 5 Maik Qualmann 2016-07-24 16:58:24 UTC
Git commit f4c5e15d8619d2cb41a841b646e8d95a63f80350 by Maik Qualmann.
Committed on 24/07/2016 at 16:55.
Pushed by mqualmann into branch 'master'.

apply Patch from Burkhard Lueck to remove double setApplicationDomain() call

M  +0    -1    app/main/main.cpp

http://commits.kde.org/digikam/f4c5e15d8619d2cb41a841b646e8d95a63f80350
Comment 6 Antonio Rojas 2016-08-11 10:09:28 UTC
still happens in 5.1.0
Comment 7 caulier.gilles 2016-08-11 10:20:07 UTC
This is a different problem. 5.1.0-01 Windows installers miss all i18n files. Fixed in 5.1.0-02 installer just published.

Gilles Caulier
Comment 8 Antonio Rojas 2016-08-11 10:26:00 UTC
This is on Linux, not Windows. Everything is translated except for the menu bar, tested with different languages.
Comment 9 caulier.gilles 2016-09-23 15:15:50 UTC
*** Bug 369235 has been marked as a duplicate of this bug. ***
Comment 10 Antonio Rojas 2016-09-23 16:06:57 UTC
Reopening, this is not fixed as of 5.2
Comment 11 Antonio Rojas 2016-09-23 16:34:45 UTC
The problem is that, for some reason, the system digikamui.rc doesn't override the local one, even though it has a higher version number (514 v. 505). So if the user has a digikamrc.ui from 5.0 this won't be fixed on upgrade without manually removing the local digikamui.rc
Comment 12 caulier.gilles 2016-11-25 17:23:27 UTC
What's about this file using digiKam AppImage bundle 5.4.0 pre release given at
this url :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 13 caulier.gilles 2016-11-29 11:14:46 UTC
not a 5.4.0 windows installer is available in same repository for testing...
Comment 14 caulier.gilles 2016-12-29 11:38:47 UTC
Any feedback with 5.4.0 pre release installer for Windows available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM
Comment 15 caulier.gilles 2017-01-09 11:22:35 UTC
Git commit 9057447deee97a4ce5ee609251d3439ac2a1c583 by Gilles Caulier.
Committed on 09/01/2017 at 11:07.
Pushed by cgilles into branch 'master'.

there is definitively a problem with older ui.rc file
from DK4 when we migrate to DK5, as some items from main menu are not show (but action still avaialble through keyboard shortcut).
renaming ui.rc fix the problem

M  +1    -1    app/main/digikamapp.cpp
R  +1    -1    app/main/digikamui5.rc [from: app/main/digikamui.rc - 099% similarity]

https://commits.kde.org/digikam/9057447deee97a4ce5ee609251d3439ac2a1c583
Comment 16 caulier.gilles 2017-01-09 11:36:54 UTC
Git commit 20941e8744c3424efbc3e5c8604ecae772dd4f6f by Gilles Caulier.
Committed on 09/01/2017 at 11:24.
Pushed by cgilles into branch 'master'.

there is definitively a problem with older ui.rc file
from DK4 when we migrate to DK5, as some items from main menu are not show (but
action still avaialble through keyboard shortcut).
renaming ui.rc fix the problem

M  +1    -1    utilities/importui/CMakeLists.txt
R  +1    -1    utilities/importui/main/importui5.rc [from: utilities/importui/main/importui.rc - 098% similarity]
M  +1    -1    utilities/lighttable/CMakeLists.txt
M  +1    -1    utilities/lighttable/lighttablewindow.cpp
R  +1    -1    utilities/lighttable/lighttablewindowui5.rc [from: utilities/lighttable/lighttablewindowui.rc - 098% similarity]
M  +1    -1    utilities/queuemanager/CMakeLists.txt
R  +1    -1    utilities/queuemanager/main/queuemgrwindowui5.rc [from: utilities/queuemanager/main/queuemgrwindowui.rc - 097% similarity]

https://commits.kde.org/digikam/20941e8744c3424efbc3e5c8604ecae772dd4f6f
Comment 17 caulier.gilles 2017-01-09 19:04:19 UTC
Git commit fe695c6b038a3ac6311cafc646f044c5bd5fb084 by Gilles Caulier.
Committed on 09/01/2017 at 19:03.
Pushed by cgilles into branch 'master'.

fix target rc file names with '5' as prefix while migration from DK4 to DK5

M  +3    -4    utilities/assistants/firstrun/migratefromdigikam4page.cpp
M  +2    -2    utilities/assistants/firstrun/migratefromdigikam4page.h

https://commits.kde.org/digikam/fe695c6b038a3ac6311cafc646f044c5bd5fb084
Comment 18 caulier.gilles 2017-01-09 19:07:06 UTC
I'm able to reproduce the problem while migrating DK4 to DK5 with French language.

Renaming all RC files with '5' prefix fix the problem here.

Warning : migrating old settings still problematic, and i don't know why. sound like a dysfunction in KDE API, but not sure. It's always better to start DK5 with a fresh settings, as it's explained in First-Run assistant.

I close this file now. Don't hesistate to re-open if necessary.

Gilles Caulier