Bug 359483 - MPRIS2 property 'Identity' doesn't return displayName but plain executable name instead
Summary: MPRIS2 property 'Identity' doesn't return displayName but plain executable na...
Status: RESOLVED FIXED
Alias: None
Product: dragonplayer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-16 22:27 UTC by Elias Probst
Modified: 2016-04-19 17:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2016-02-16 22:27:05 UTC
According to the MPRIS2 specs [1], the 'Identity' property should return a friendly display name
Dragon just returns "dragonplayer" instead.

See also src/mpris2/mediaplayer2.cpp:97
  return APP_NAME;

and in src/codeine.h:42
  #define APP_NAME "dragonplayer"

The most reasonable approach would be to use the displayName from KAboutData for 'Identity' instead.
Affects currently latest dragon from git/master (faed654).

[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:Identity
Comment 1 Anthony Fieroni 2016-04-19 17:16:40 UTC
Git commit d262e5e90cdb73eab7b5d1fba86aba1ff8e8c6a3 by Anthony Fieroni.
Committed on 19/04/2016 at 17:15.
Pushed by anthonyfieroni into branch 'Applications/16.04'.

MPRIS2 property 'Identity' to match desktop file entry

REVIEW: 127684

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

M  +1    -1    src/mpris2/mediaplayer2.cpp

http://commits.kde.org/dragon/d262e5e90cdb73eab7b5d1fba86aba1ff8e8c6a3