Just started KDE Plasma session shows notifications twice, espeacially if the message of particular type is displayed for first time. Reproducible: Always
Created attachment 96055 [details] Screen foto
Thanks for the report Can you please start Konsole and run this kquitapp5 plasmashell && plasmashell and post the output *after* the two notifications have appeared? Thanks
Created attachment 96076 [details] after `kquitapp5 plasmashell && plasmashell`: from checking for package updates Log printed very fast and a lot of lines, I don't know exact moment of appearing, so I attach log since checking for updates.
Ok, that's good. I will need more info however. Can you please install bustle, start bustle, start the logging, then run the `kquitapp5 plasmashell && plasmashell` again, after the notifications appeared, stop bustle, save the log and please attach the log here. That should be the last info needed. Thanks
Created attachment 96094 [details] bustle document
Created attachment 96095 [details] bustle document, pdf version
info provided as attachments https://bugs.kde.org/attachment.cgi?id=96094 - bustle, https://bugs.kde.org/attachment.cgi?id=96095 - pdf format
This one is actually no good. Can you please verify that after you've started logging, the two notifications appeared? The log does not have that
Though I stopped recording about second after two notifications appeared...
The log has the notifications being closed but it doesn't have them being opened. Can you maybe try rebooting/logging out-and-in, run bustle right after start and then wait some more time before stopping the logging, just wait for the notifications to close, even.
Created attachment 96096 [details] bustle file
Created attachment 96097 [details] bustle pdf
I hope https://bugs.kde.org/attachment.cgi?id=96096 and https://bugs.kde.org/attachment.cgi?id=96097 is better
This one is the same as before, unfortunately. It recorded only events of the notification being closed, not being opened. Btw. you if you log out and in, you don't need to restart plasma, running bustle and starting logging is all that is needed. Once again - can you please confirm that the notifications appeared on screen *while* the bustle log was already recording? Also, are you able to test patches? Finally, the pdf attachment is not needed.
I confirm that the notifications appeared on screen *while* the bustle log was already recording. Maybe you are right – I restarted plasma just after started recording – maybe it affects... I don't want to download KDE sources to my computer and compiling KDE stuff. I a bit can play in openSUSE Build Service by branching https://build.opensuse.org/project/show/KDE:Frameworks5 package, applaying some patch and waiting for building RPM... But it would be awesome, if you could prepare patched RPM.
Created attachment 96099 [details] bustle file again
Created attachment 96100 [details] Video This time I filmed my desktop to ensure you, that I recorded before PackageKit showed notifications. This time enven 3 notifications was!
Video corresponds latest bustle attachment https://bugs.kde.org/attachment.cgi?id=96099
Ah, I understand now. It's (still) not in the bustle log because the dbus call is within the same process, therefore not going through dbus at all. Good effort though, thanks! I think I also know what's going on with it. Because this is emitted from a plasmoid (and therefore from plasmashell process), it bypasses the checks for duplicate notifications and then does not detect it as a duplicate. I'll see if I can reproduce a simple case.
356895 is an easy way to reproduce it
*** Bug 356895 has been marked as a duplicate of this bug. ***
Multifix at https://git.reviewboard.kde.org/r/126459/ https://git.reviewboard.kde.org/r/126460/ https://git.reviewboard.kde.org/r/126461/
(In reply to Martin Klapetek from comment #22) > Multifix at > > https://git.reviewboard.kde.org/r/126459/ > https://git.reviewboard.kde.org/r/126460/ > https://git.reviewboard.kde.org/r/126461/ Read the reviewboard, > "The lock-widgets one is I think because of multiscreen, cause > then you have two containments emitting two same notifications." Then as I understand its not a duplicate and these won't fix that particular issue? Best Regards
It will fix it Plasma will emit two. However, the notification applet will then squash that into one.
(In reply to David Edmundson from comment #24) > It will fix it > > Plasma will emit two. > However, the notification applet will then squash that into one. Oh I see, will try to build with these patches and test. But as a question why would it create only two when I have 3 monitors? Anyhow, will try and report back and thanks again =) Best Regards
Git commit 30e82248c787ee5224507957b8f2d5fd3e854917 by Martin Klapetek. Committed on 29/12/2015 at 20:06. Pushed by mklapetek into branch 'master'. Add a hint to skip notifications grouping Plasma currently groups notifications that have the same notification title or if they are on a "blacklist" (like media player apps that popup a notification for each song change), but sometimes the grouping needs to be skipped. This is for example when user removes two widgets from his desktop and the "Undo" notification appears, these cannot be grouped. This is currently handled rather by a hack in the notifications server, so introducing this new flag should allow for a clean and proper solution. REVIEW: 126459 M +7 -0 src/knotification.h M +4 -0 src/notifybypopup.cpp http://commits.kde.org/knotifications/30e82248c787ee5224507957b8f2d5fd3e854917
Git commit f639996becc2fae284d9c83273856dee510b699d by Martin Klapetek. Committed on 29/12/2015 at 20:12. Pushed by mklapetek into branch 'master'. Use the SkipGrouping flag for the "widget deleted" notification https://git.reviewboard.kde.org/r/126459/ introduced new flag that allows to skip the grouping of notifications. This should fix all bugs caused by checking for appName being "plasma_workspace" which are all default notifications from any plasmoid. REVIEW: 126461 (this also needs to raise the KF5 dep to 5.18 which is normally done at release time, but in order to use this now, it needs to be bumped now, otherwise build failures will ensue) M +1 -1 CMakeLists.txt M +1 -0 src/plasma/private/applet_p.cpp http://commits.kde.org/plasma-framework/f639996becc2fae284d9c83273856dee510b699d
Please test with plasma-framework 5.19 and knotifications 5.19 and reopen if this is still an issue.
Sorry, add plasma-workspace 5.6 to the mix.
*** Bug 358858 has been marked as a duplicate of this bug. ***
(In reply to Martin Klapetek from comment #29) > Sorry, add plasma-workspace 5.6 to the mix. Um has this gotten into main? Im still getting duplacate notifications about unlocked widgets on Arch with (kf5 5.19) and (plasma 5.5.5).
(In reply to Artur O. from comment #31) > (In reply to Martin Klapetek from comment #29) > > Sorry, add plasma-workspace 5.6 to the mix. > > Um has this gotten into main? Im still getting duplacate notifications about > unlocked widgets on Arch with (kf5 5.19) and (plasma 5.5.5). After Arch updated to Plasma 5.6 and QT 5.6 the issue is resolved for me.