Bug 355189 - legacy fuzzyness
Summary: legacy fuzzyness
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: fuzzy-clock (show other bugs)
Version: 5.4.2
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 14:07 UTC by tukkek
Modified: 2015-11-11 19:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tukkek 2015-11-11 14:07:59 UTC
If possible I would appreciate bringing back the granularity that showed only
4 options per hour:

    13:00
    13:15
    13:30
    13:45

None of the current fuzzinesses seem right to me. It also seems weird that from
"Afternoon" we jump to "Five minutes to six" or so. This legacy fuzziness would
be the perfect middle-ground between these two: one too fuzzy for me, the other not
fuzzy enough.

I'm curious why this was available in earlier versions and not on this one.
Comment 1 Kai Uwe Broulik 2015-11-11 14:27:12 UTC
Plasma 4 and Plasma 5, while looking similar, are completely different on a technical level meaning that Plasma 4 applets written in C++ do not work on Plasma 5. I basically re-implemented Fuzzy Clock from scratch. (Actually the first applet I ported to Plasma 5 because I love Fuzzy Clock)

I was under the impression I ported the fuzziness levels verbatim but apparently I was wrong :)
Comment 2 tukkek 2015-11-11 14:49:10 UTC
I love fuzzy clock too - actually had to install an extra Debian package just to find it. I got KDE working but it really felt like something was missing... So thanks a lot for the new plasmoid!

I hope you think this feature request makes sense, it would be great to see it implemented next time an updated package comes to Debian testing! Thank you again for the replies and interest in these reports I've opened!
Comment 3 Kai Uwe Broulik 2015-11-11 15:03:11 UTC
I just saw, apparently the "fuzziness level 2" logic is flawed jumping to 10 min to the hour at ~20min before and sometimes even returning undefined. It looks like that one is actually supposed to use 15min steps as you described but there's some Maths error in the calculation.
Comment 4 Kai Uwe Broulik 2015-11-11 15:23:10 UTC
Git commit 74f7ffff15b20cdf589c8c6a5c9f731c3167223e by Kai Uwe Broulik.
Committed on 11/11/2015 at 15:21.
Pushed by broulik into branch 'master'.

Fix quarterly fuzziness (level 2 fuzziness is now 15 minute accurate)

The formula I took from the old applet was flawed and/or I did not port it properly.
It was too fast and sometimes even returned undefined.
FIXED-IN: 5.5.0

M  +5    -3    applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml

http://commits.kde.org/kdeplasma-addons/74f7ffff15b20cdf589c8c6a5c9f731c3167223e
Comment 5 tukkek 2015-11-11 19:15:18 UTC
Thanks man, you rock! Hopefully it won't take too long for the fix to be packaged into Debian!
Comment 6 Kai Uwe Broulik 2015-11-11 19:19:09 UTC
Btw the files I changed were QML files, they lie on your hard drive as plain text. You could basically grab FuzzyClock.qml from KDE's quickgit and replace the one you have to get the fix immediately (obviously an update that doesn't have it yet would override again). It should be located in /usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock.
Comment 7 tukkek 2015-11-11 19:35:51 UTC
Did I mention you rock?!

I was able to do your commits locally (spreadsheet-oriented programming ftw btw) and everything is working fine! I'll try to keep an eye on the fuzziness level 2 to see if it's acting properly over time.

My desktop is perfect now! Thanks a lot again and hopefully my report (and your fix ofc) means other people will be enjoying the improved version too!