Bug 354900 - Question marks at game win
Summary: Question marks at game win
Status: RESOLVED FIXED
Alias: None
Product: kmines
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Dmitry Suzdalev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-05 14:47 UTC by torhamzed
Modified: 2016-10-16 21:31 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kmines/f3455686463c0e4c79c1c7ae376d21ef05cdd9c8
Version Fixed In:
Sentry Crash Report:

Attachments
Empty cells (62.03 KB, image/png)
2015-11-05 14:48 UTC, torhamzed 		Details
Patch file (551 bytes, patch)
2015-11-05 15:16 UTC, torhamzed 		Details
Question marks (63.12 KB, image/png)
2015-11-05 15:22 UTC, torhamzed 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description torhamzed 2015-11-05 14:47:05 UTC 
Leaving question marks when the game is won blanks out the cells.

Reproducible: Always

Steps to Reproduce:
1. Do not flag all the cells
2. Win the game
3.


Expected Results:  
All cells should be flags when the game is won.

This happens on both KDE5 and KDE4 versions.  There are no crashes or other behavior that I can see.
Comment 1 torhamzed 2015-11-05 14:48:04 UTC 
Created attachment 95329 [details]
Empty cells
Comment 2 torhamzed 2015-11-05 15:16:42 UTC 
Created attachment 95331 [details]
Patch file

I created a patch(I think) for this using Kompare, a new if statement in the MineFieldItem::checkWon method that first checks for isQuestioned.
Comment 3 torhamzed 2015-11-05 15:21:39 UTC 
Comment on attachment 95329 [details]
Empty cells

This was the second screenshot.
Comment 4 torhamzed 2015-11-05 15:22:13 UTC 
Created attachment 95332 [details]
Question marks
Comment 5 Albert Astals Cid 2016-10-16 21:31:12 UTC 
Git commit f3455686463c0e4c79c1c7ae376d21ef05cdd9c8 by Albert Astals Cid, on behalf of Torham Zed.
Committed on 16/10/2016 at 21:31.
Pushed by aacid into branch 'Applications/16.08'.

Fix clearing question marks at game win

Acked by Frederik Schwarzer
REVIEW: 128462

M  +2    -0    minefielditem.cpp

http://commits.kde.org/kmines/f3455686463c0e4c79c1c7ae376d21ef05cdd9c8