Bug 352949 - ark don't warn about broken rar file
Summary: ark don't warn about broken rar file
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 2.19
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-20 18:06 UTC by dmr drk
Modified: 2015-10-14 16:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 15.12.0
Sentry Crash Report:


Attachments
rar sample (36.29 KB, application/x-rar)
2015-09-22 12:14 UTC, dmr drk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dmr drk 2015-09-20 18:06:09 UTC
ark 15.04  don't warn unfinished or broken rar file with unrar-nonfree 5*, ark with unrar-nonfree 4 do.  

Reproducible: Always

Steps to Reproduce:
1.open unfinish or broken rar
2.there is no warning
3.


Expected Results:  
warn about rar file is broken
Comment 1 Ragnar Thomsen 2015-09-21 10:59:45 UTC
Thanks for reporting. Can you try with a more recent version such as Ark 15.08.1? Also, can you upload an affected archive here?
Comment 2 dmr drk 2015-09-21 20:26:51 UTC
i have not upgraded to kde5 yet.
i have meant extraction error dialog, to be clear, not just open.
and there is no progress dialog.
Comment 3 Ragnar Thomsen 2015-09-22 04:54:43 UTC
Can you upload a broken rar archive here by using "Add an attachment"?
Comment 4 dmr drk 2015-09-22 12:14:44 UTC
Created attachment 94674 [details]
rar sample

it is from rarlab.com themes, actual size is 105 KB and unfinished download.
Comment 5 Ragnar Thomsen 2015-10-04 14:03:22 UTC
Git commit 170115f17e2be3e1703efe5cec6fea8e762ddd67 by Ragnar Thomsen.
Committed on 04/10/2015 at 13:59.
Pushed by rthomsen into branch 'master'.

Improve handling of corrupt archives by CliPlugins

A new parameter was added to the Kerfuffle::CliInterfaceParameters enum
(called CorruptArchivePatterns), containing a list of regexps matching
output from CliPlugins when a corrupt archive is listed.

Due to the CliInterface not being able to launch a KMessageBox itself, a
query (LoadCorruptQuery) was added which launches a
KMessageBox::warningYesNo asking the user if he wants to try to load the
corrupt archive. This is useful because some files might still be
recoverable.

If the user answers no, loading of the archive is cancelled.

If the user answers yes the archive is loaded as usual, but to prevent
the user from trying to add/delete files from the corrupt archive (which
is likely to fail), the archive is set to readonly. This necessitated a
new private member in ReadOnlyArchiveInterface (m_isCorrupt) and
getter/setter functions. The setter function is used in
CliInterface::HandleLine, while the getter function is used in
ReadWriteArchiveInterface::isReadOnly().
Related: bug 261073
FIXED-IN: 15.12.0
REVIEW: 125363

M  +17   -3    kerfuffle/archiveinterface.cpp
M  +3    -0    kerfuffle/archiveinterface.h
M  +13   -0    kerfuffle/cliinterface.cpp
M  +5    -0    kerfuffle/cliinterface.h
M  +24   -0    kerfuffle/queries.cpp
M  +21   -0    kerfuffle/queries.h
M  +2    -0    plugins/cli7zplugin/cliplugin.cpp
M  +2    -0    plugins/clirarplugin/cliplugin.cpp
M  +1    -0    plugins/clizipplugin/cliplugin.cpp

http://commits.kde.org/ark/170115f17e2be3e1703efe5cec6fea8e762ddd67