Bug 34857 - [PATCH] kmail html external references suggestion prompt
Summary: [PATCH] kmail html external references suggestion prompt
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: 1.3.1
Platform: Mandrake RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Till Adam
URL:
Keywords:
: 59433 88145 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-11-13 14:48 UTC by sean
Modified: 2007-07-04 21:02 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch implementing the suggestion made by Jörg Rüppel (13.36 KB, patch)
2004-04-03 15:39 UTC, Ingo Heeskens
Details
Updated patch for handling of "load external references" (17.80 KB, patch)
2004-07-10 20:29 UTC, Ingo Heeskens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sean 2001-11-13 14:34:22 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           kmail
Version:           1.3.1 (using KDE 2.2.1 )
Severity:          wishlist
Installed from:    Mandrake Linux Vitamin
Compiler:          gcc version 2.96 20000731 (Mandrake Linux 8.1 2.96-0.62mdk)
OS:                Linux (i686) release 2.4.7-12.3mdk
OS/Compiler notes: 

I think the Load External Html References option should allow:

Yes / No / Ask

In this manner I can select Prompt and then each time I select a message containing external references I can be asked if I want to load them. The current system is inconvenient because I have a number of emails from vendors I trust that don't look right without images. BUT I don't want spammers to detect my reading behavior for those I don't trust. Right now I can't have my cake and eat it too :).

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Ingo Kl 2001-11-14 20:35:34 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 13 November 2001 15:34 sean@digitalspinner.com wrote:
> I think the Load External Html References option should allow:
>
> Yes / No / Ask
>
> In this manner I can select Prompt and then each time I select a
> message containing external references I can be asked if I want to
> load them. The current system is inconvenient because I have a number
> of emails from vendors I trust that don't look right without images.
> BUT I don't want spammers to detect my reading behavior for those I
> don't trust. Right now I can't have my cake and eat it too :).

Yes you can. Simply filter all non-spam messages to some folders for=20
which HTML is enabled and move all potential spam messages to a folder=20
which has HTML disabled. Just to be sure you should also disalbe HTML=20
for the inbox.

This will solve your problem because external HTML references are of=20
course only loaded if HTML is enabled.

Regards
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE78tWXGnR+RTDgudgRApIMAKDLSii1gtViWIXiPpIbtPRo9G8+YQCdFM5y
gR7zHVpY6zuUB2cf9ca+oWc=3D
=3D5i8c
-----END PGP SIGNATURE-----
Comment 2 Michael 2003-03-08 14:44:18 UTC
Good idea, 
maybe additional a option could be included, which gererally allows loading of 
external references, which don't contain active content, especially pictures. 
So the Look of a HTML-mail which often contains pictures is as it should be without 
any additional security risk. 
Comment 3 Ingo Klöcker 2003-03-08 17:17:46 UTC
Subject: Re:  kmail html external references suggestion prompt

Not loading external references has nothing to do with active content 
since KMail never executes active content. Not loading external 
references is about privacy, not about security. Read the What's This 
help (Shift+F1) for the corresponding setting in the configuration 
dialog. If you don't have any concerns about your privacy then you can 
safely enable loading of external references. It doesn't decrease the 
security of KMail.


Comment 4 mifi 2003-03-10 21:41:39 UTC
Subject: Re:  kmail html external references suggestion prompt

When does KMail load the ext. refs.? Already when popping and putting the 
mails to folders or when the user is viewing a mail?
Would it be possible to handle this option folder- or sender-specific?
Background: I'm using SpamAssassin to drop Spam automatically into another 
folder. For other Mails I'd like the ext. refs. loaded.

Comment 5 Ingo Klöcker 2003-03-11 01:12:21 UTC
Subject: Re:  kmail html external references suggestion prompt

On Monday 10 March 2003 21:41, mifi@gmx.de wrote:
> When does KMail load the ext. refs.? Already when popping and putting
> the mails to folders or when the user is viewing a mail?

When viewing a message. But of course only if HTML rendering is enabled.

> Would it be possible to handle this option folder- or
> sender-specific?

HTML rendering is already folder-specific.

> Background: I'm using SpamAssassin to drop Spam
> automatically into another folder. For other Mails I'd like the ext.
> refs. loaded.

In this case you can simply enabled ext. ref. loading globally and 
disable HTML rendering (and thus also ext. ref. loading) for the spam 
folder.

Regards,
Ingo

Comment 6 Ingo Klöcker 2003-06-07 14:42:37 UTC
*** Bug 59433 has been marked as a duplicate of this bug. ***
Comment 7 christophe 2003-07-08 21:29:51 UTC
 Filtering on HTML into a paor not in the body changes the whole meaning of 
"Inbox": one more folder to check... 
 I don't want to enable external references at all, EXCEPT for a few messages. 
A simple keypoard shortcut would be enough. 
  
Comment 8 Jay 2003-12-04 02:49:18 UTC
I too like to have a simple button: Load images somewhere in a prominent place, similar to what is done now for HTML messages. "Click here to also load images". Thanks for attention.
Comment 9 Ingo Heeskens 2004-04-03 15:39:24 UTC
Created attachment 5517 [details]
Patch implementing the suggestion made by Jörg Rüppel

This patch is for KMail 1.6.1 that comes with KDE 3.2.1. If loading of external
references is disabled and a message is shown as HTML, a note with a link to
enable loading of the external references is displayed at the top of the
message (similar to the note that allows you to turn on HTML rendering).
Clicking the link re-displays the message, with all references loaded. The
actual loading of the references is delayed until the user clicks the link.

Three points remain unsolved:
- The note is displayed for every message shown as HTML when loading external
references is disabled. It would be nice to check at first whether the message
has external references and only display the note if it has.
- There's no folder specific setting for loading external references as there
is for displaying HTML.
- KMail still doesn't display images embedded into the mail with img
src="cid:identifier".
Comment 10 Jay 2004-05-10 18:51:38 UTC
Has the patch been comitted already?
Comment 11 Yves Glodt 2004-06-22 19:57:20 UTC
I don't see it neither, using kmail 1.6.2, same for the "show as html"

Is this only in head maybe?
Comment 12 Ingo Heeskens 2004-07-10 20:29:18 UTC
Created attachment 6607 [details]
Updated patch for handling of "load external references"

I updated my previous patch to work with the current cvs version.

New: This patch also includes a folder specific setting for loading external
references.
Comment 13 mstearn 2004-07-13 19:01:01 UTC
Any chance of this getting into HEAD before 3.3 is released.
Comment 14 Carsten Burghardt 2004-07-14 11:13:31 UTC
No, sorry, we're in feature freeze.
Comment 15 Tom Albers 2004-09-08 18:07:43 UTC
*** Bug 88145 has been marked as a duplicate of this bug. ***
Comment 16 Jason Keirstead 2004-11-01 15:51:46 UTC
Can someone please approve Inglo's patch and commmit it, or explain what needs to be improved? I am getting sick of having to keep patching HEAD and fixing conflicts :(
Comment 17 Till Adam 2004-11-20 14:03:30 UTC
Patch looks good, thanks a lot, Ingo. I'll commit it, if the other Ingo has no objections.
Comment 18 Till Adam 2004-11-22 09:55:51 UTC
CVS commit by tilladam: 

Patch by Ingo Heeskens implementing a per folder option for loading
external references in html mails and a link to enable them for a single
mail, if they are disabled for the folder and globally. Thanks a lot, Ingo,
many people have been asking for this. :)

FEATURE: 34857
GUI:


  M +7 -4      kmcommands.cpp   1.178
  M +4 -1      kmcommands.h   1.52
  M +41 -2     kmmainwidget.cpp   1.296
  M +4 -2      kmmainwidget.h   1.84
  M +2 -1      kmmainwin.rc   1.83
  M +5 -2      kmreadermainwin.cpp   1.39
  M +1 -1      kmreadermainwin.h   1.14
  M +21 -2     kmreaderwin.cpp   1.792
  M +8 -1      kmreaderwin.h   1.203
  M +10 -0     objecttreeparser.cpp   1.122
  M +18 -11    urlhandlermanager.cpp   1.18



Comment 19 Gregor B. Rosenauer 2007-07-04 21:02:24 UTC
The current behaviour is still uncomfortable if using the inbox in a standard way (for general mail), because I have to click on "click here" for every message seperately.

A imho better solution inline to what the reporter originally wanted would be to offer an option for automatically loading images when the mail's sender is in the addressbook, similar to what Thunderbird does (but only for the Personal, not any additional addressbooks unfortunately).

Could this feature be considered please? :)
I did not want to open a new bug for this, but if my suggestion is too different from the original request, I can do that.