In report editor mode, in property editor in DB source tab in internal source combo box, there are 2 empty entries. This may mislead user. Comparing to form editor's data source select in the same tab (property editor->DB tab), data source combo box is completely different - entries have entry type icons and user can type data source. I do not see reason why Reports have different UX. Reproducible: Always Steps to Reproduce: 1.Create 2 or more tables 2.Create 2 or more queries 3.Create report, open property editor, set DB tab. Try to select internal source. Actual Results: 2 empty entries in combo box. Expected Results: One of the following: - Only one empty line (first) - First line should display "None" - Move DB source select from Forms tab (at least from UX perspective).
Created attachment 92155 [details] Current solution
Created attachment 92156 [details] Forms view
Thanks. The right fix could be to re-use the design (and some code?) in the Report Designer from Forms. I am not sure such larger change would go to 2.9.x. Rather to 3.0.x (which isn't buildable the moment so it's a challenge to perform the fix now).
At least it would be good to fix the empty space issue in Reports, close this bug (if for 2.9.3 then before Friday) and open a new wish for the whole 'right' redesign in 3.x.
@Kamil would you be able to fix the space issue? We're going to release 2.9.4 in a week of time.
Created attachment 92334 [details] attachment-14739-0.html I'll look at this issue over this weekend. 2015-04-29 21:54 GMT+02:00 Jarosław Staniek <staniek@kde.org>: > https://bugs.kde.org/show_bug.cgi?id=346449 > > --- Comment #5 from Jarosław Staniek <staniek@kde.org> --- > @Kamil would you be able to fix the space issue? We're going to release > 2.9.4 > in a week of time. > > -- > You are receiving this mail because: > You reported the bug. >
I'll found where empty entries was added. And I found other bug: Entries are added by text name. If I add table and query that have the same name, Kexi may not recognize internal source - is it query or table - because text is the same in both cases.
Git commit 627f37ff273e0cbb10189a8e85ac724d8131baa3 by Jaroslaw Staniek, on behalf of Kamil Lysik. Committed on 04/05/2015 at 21:01. Pushed by staniek into branch 'calligra/2.9'. Remove second empty internal data source entry in Kexi report designer REVIEW:123619 FIXED-IN:2.9.5 M +1 -2 kexi/plugins/reports/InternalSourceSelector.cpp http://commits.kde.org/calligra/627f37ff273e0cbb10189a8e85ac724d8131baa3