Bug 345787 - [desktop toolbox] toolbox dialog have inconsistent positioning on different corners
Summary: [desktop toolbox] toolbox dialog have inconsistent positioning on different c...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 04:08 UTC by Bhushan Shah
Modified: 2015-04-10 13:03 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-framework/6dfc6e38dd671b45cf8c6d84bae1fdd555cac407
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Bhushan Shah 2015-04-02 04:08:44 UTC 
In the left top corner dialog have no space between left edge and screen edge while on right side it have space between right edge and screen edge. Also sometimes that dialog covers the desktop toolbox itself. This is very inconsistent with previous non-dialog toolbox behavior.
Comment 1 Marco Martin 2015-04-10 13:03:19 UTC 
Git commit 6dfc6e38dd671b45cf8c6d84bae1fdd555cac407 by Marco Martin.
Committed on 02/04/2015 at 13:59.
Pushed by gerrit into branch 'master'.

Consider visualParent rotation in popupPosition

if there are transforms in the scene, to correctly compute the position the
transform is needed to be accounter for.
QQuickITem::mapRectToScene does consider tranforms.
this adresses bug 345787 where the toolbox may be rotated.
Change-Id: I13a5509d95a7498382155abf3c3d195708de56a6

M  +9    -5    src/plasmaquick/dialog.cpp
A  +93   -0    tests/dialog_positioning_parentrotated.qml     [License: GPL (v2+)]

http://commits.kde.org/plasma-framework/6dfc6e38dd671b45cf8c6d84bae1fdd555cac407