Bug 344599 - Thumbnails sidebar always open when okular starts
Summary: Thumbnails sidebar always open when okular starts
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.19.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2015-02-26 16:05 UTC by Chris Mavrakis
Modified: 2020-05-27 13:37 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.11.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mavrakis 2015-02-26 16:05:42 UTC
Every time Okular starts, one of the items of the Navigation Panel is open (usually the Thumbnails panel). There is no way to disable this globally, so that all panels are closed by default.

Reproducible: Always

Steps to Reproduce:
1. Open a PDF with Okular
2. Click on the "Thumbnails" icon of the Navigation Panel, to minimize Thumbnails panel
3. Close Okular
4. Open a PDF with Okular (same or different file as in step 1)

Actual Results:  
The Thumbnails panel is open again.

Expected Results:  
The Thumbnails panel should have stayed closed.

I guess two approaches are possible:
- either save the state of the panels upon exit, so that Okular restores it when a new PDF is opened
- or provide an option in settings, to set whether one of the panels should be open upon startup of okular

Related bugs and why this is not a duplicate:
https://bugs.kde.org/show_bug.cgi?id=201108 - Probably this IS a duplicate, but diverse comments have made it into a mess. Comment #14 prompts for the creation of a new, clean bug report to help devs, which is what I did here. Also, it's several years old and marked as Resolved.

https://bugs.kde.org/show_bug.cgi?id=343089 - Related but this emphasizes on which of the panels is open on reload. Does not mention panels being completely hidden

https://bugs.kde.org/show_bug.cgi?id=342094 - Same as above, for the closing and reopening procedure

https://bugs.kde.org/show_bug.cgi?id=321169 - This is about the default opening of Contents over Thumbnails.
Comment 1 Sumit Sahrawat 2015-12-03 14:09:08 UTC
Looks like this has been fixed.
Comment 2 Albert Astals Cid 2015-12-04 00:21:47 UTC
Chris can you reproduce your problem in newer versions of Okular?
Comment 3 Ansa 2015-12-04 00:37:21 UTC
I still have this problem, although I also have the impression that it has recently much improved. 

My hypothesis is that files which contain bookmarks (so that the "Contents" tab in the Navigation Panel can be activated) open with the Navigation Panel closed even if both the file and Okular where closed from a position with the Navigation Panel open. On the other hand, files without bookmarks open with the Navigation Panel open on the Thumbnail view, again irrespective of whether the Navigation Panel was open or closed the last time Okular and/or the file were open.

Ubuntu 14.04.3 LTS
Qt: 4.8.6
KDE Development Platform: 4.13.3
Okular: 0.19.3
Comment 4 Chris Mavrakis 2015-12-04 18:17:02 UTC
Hi all,

@Albert Astals Cid, yes, I can still reproduce it on my updated 14.04.3 LTS box. Okular 0.19.3, KDE 4.13.3.

What I now realize I should have mentioned is that I do not use KDE as the graphical interface. I use the default Unity and just some KDE programs.

Thanks!
Comment 5 Sumit Sahrawat 2015-12-04 18:40:42 UTC
I'm on archlinux using xmonad and no KDE/Plasma.

```
$ okular --version
Qt: 4.8.7
KDE Development Platform: 4.14.14
Okular: 0.23.2
```
Comment 6 Albert Astals Cid 2015-12-08 21:30:50 UTC
Using Plasma or not has nothing to do with the bug, and yes this bug is still reproducible.

Sumit please be a bit more careful at reproducing the steps when suggesting a bug has been fixed.
Comment 7 Sumit Sahrawat 2015-12-08 22:52:50 UTC
Yup. My bad. I'm extremely sorry.
I didn't read the issue carefully enough.

I'll be more careful in the future.
Sorry for the time wasted.
Comment 8 John Florian 2017-11-19 16:44:00 UTC
I too find the default behavior a minor annoyance.  I rarely work with PDFs that are but more than a few pages so the navigation panel is just wasted real estate for me.  I'd much prefer to enable it when needed rather than almost always closing it.

Can we expect a new configuration option for this any time soon?
Comment 9 Albert Astals Cid 2017-11-19 17:36:03 UTC
(In reply to John Florian from comment #8)
> I too find the default behavior a minor annoyance.  I rarely work with PDFs
> that are but more than a few pages so the navigation panel is just wasted
> real estate for me.  I'd much prefer to enable it when needed rather than
> almost always closing it.
> 
> Can we expect a new configuration option for this any time soon?

A configuration option i don't think makes any sense, remembering the last state after closing may be smarter, but needs someone with time to implement it.
Comment 10 Dileep Sankhla 2018-03-05 11:17:03 UTC
I have sent a patch here: https://phabricator.kde.org/D11051
Comment 11 Dileep Sankhla 2018-03-09 05:53:23 UTC
May someone please review my patch being sent?
Comment 12 jellby 2019-05-01 09:49:49 UTC
This has bothered me for a long time. Please fix/review.
Comment 13 Nate Graham 2020-05-27 13:37:46 UTC
Git commit b8b36ae529599da358f433fe23d7bac4dea79fa8 by Nate Graham.
Committed on 27/05/2020 at 13:37.
Pushed by ngraham into branch 'master'.

Improve the sidebar's navigation and UX

Okular's sidebar vertical view chooser toolbar suffers from a few issues:

* It's a nonstandard UI not used for category choosers in other pieces of KDE software,
  and not used in other FOSS document readers
* What is shown and what is hidden is simultaneously too configurable while still not
  offering the desirable UI common to other programs (i.e. no visible category chooser,
  but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
* With labels on it takes up quite a bit of horizontal space, while with labels off, the
  categories are less than clear
* UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
  to hide that category's view while keeping the view chooser visible, showing mostly
  disabled items)
* It's made with custom painting code, which reduces maintainability and introduces bugs
  (e.g. https://bugs.kde.org/show_bug.cgi?id=408190)

This patch removes the vertical category chooser entirely and replaces it with a tabbed
view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
button is added on the left side of the default toolbar to quickly hide or show the
sidebar. In order to make room for the new button, the Previous and Next buttons on the
toolbar are removed, as previous/next buttons are already present on the Page Bar on the
bottom of the window so there's no need to duplicate this functionality. This improves
the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
maintainability.

![vokoscreenNG-2020-04-16_13-29-24](https://invent.kde.org/graphics/okular/uploads/a1f96a315b69282df51de9993b1befaf/vokoscreenNG-2020-04-16_13-29-24.webm)
Related: bug 213508, bug 334441, bug 408190, bug 335189

FIXED-IN: 1.11.0

CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space

M  +-    --    doc/annotations.png
M  +-    --    doc/bookmark-management.png
M  +8    -10   doc/index.docbook
M  +-    --    doc/mainwindow.png
M  +-    --    doc/signatures-panel.png
M  +34   -34   part.cpp
M  +4    -2    part.h
M  +2    -3    part.rc
M  +10   -1    ui/bookmarklist.cpp
M  +11   -1    ui/layers.cpp
M  +11   -1    ui/side_reviews.cpp
M  +21   -654  ui/sidebar.cpp
M  +1    -19   ui/sidebar.h
M  +14   -1    ui/signaturepanel.cpp
M  +23   -0    ui/thumbnaillist.cpp
M  +2    -3    ui/thumbnaillist.h
M  +10   -1    ui/toc.cpp

https://invent.kde.org/graphics/okular/commit/b8b36ae529599da358f433fe23d7bac4dea79fa8