Bug 341809 - Crash after right-clicking a Part entry
Summary: Crash after right-clicking a Part entry
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: 2.19
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-12 12:48 UTC by Elvis Angelaccio
Modified: 2014-12-17 20:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 14.12.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Angelaccio 2014-12-12 12:48:11 UTC
The crash happens while previewing an archive inside another archive, using the Ark's Part.
This bug is very likely due to my ed3ea7d commit. I will investigate as soon as possible.

Reproducible: Always

Steps to Reproduce:
1. Open an archive which has another archive among its entries.
2. Double click the archived archive to preview it using the Ark's Part.
3. Right-click one of its entries.

Actual Results:  
Ark crashes.

Expected Results:  
Ark was supposed to show the context menu for the clicked entry.
Comment 1 Elvis Angelaccio 2014-12-12 15:29:38 UTC
(In reply to Elvis Angelaccio from comment #0)
> The crash happens while previewing an archive inside another archive, using
> the Ark's Part.
> This bug is very likely due to my ed3ea7d commit. I will investigate as soon
> as possible.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Open an archive which has another archive among its entries.
> 2. Double click the archived archive to preview it using the Ark's Part.
> 3. Right-click one of its entries.
> 
> Actual Results:  
> Ark crashes.
> 
> Expected Results:  
> Ark was supposed to show the context menu for the clicked entry.

Actually I was wrong, it's not true that Ark was supposed to show the context menu there. We are talking about a read-only preview of the archive, so the expected behavior is: nothing happens after the right-clicking.
Comment 2 Elvis Angelaccio 2014-12-17 20:50:37 UTC
Git commit 5805c830794eface7e706e71f5906743fc2e2d64 by Elvis Angelaccio.
Committed on 17/12/2014 at 20:42.
Pushed by elvisangelaccio into branch 'Applications/14.12'.

Stop crashing after right-clicking a KPart entry.

This commit fixes a crash introduced by commit ed3ea7d. When previewing an
archive inside another archive, factory() returns a null pointer and thus the
context menu can't be showed there after a right-click.
FIXED-IN: 14.12.1
REVIEW: 121468

M  +4    -0    part/part.cpp

http://commits.kde.org/ark/5805c830794eface7e706e71f5906743fc2e2d64