Bug 341007 - Big icons task switcher animates highlight focus on show
Summary: Big icons task switcher animates highlight focus on show
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: tabbox (show other bugs)
Version: 5.1.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-15 22:46 UTC by Albert Astals Cid
Modified: 2015-05-11 23:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: Plasma 5.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2014-11-15 22:46:26 UTC
I already fixed this issue in kwin4, sad to see it back in kwin5.

How to reproduce:
 * Have 5 apps open
 * Alt+tab to the last one
 * Press Alt+tab (without releasing the Alt)
 * See how the highlight focus travels from the 5th icon to the 2nd

The fix in kwin4 is http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=76d24ca7feb613413d3d6f307191b6c5fad78d50

If someone can point me where to fix this in kwin5 i'd be happy to try a similar fix.
Comment 1 Kai Uwe Broulik 2015-02-18 17:19:33 UTC
Looks fixed to me, at least the highlight doesn't move at all here anymore
Comment 2 Kai Uwe Broulik 2015-02-18 17:20:28 UTC
Nevermind, I overlooked the "big icons" switcher.
Comment 3 Thomas Lübking 2015-02-18 17:35:42 UTC
The bug (or not) here seems that the currently active window is moved to the first position, ie. the icon list is not static. Correct perception?
Comment 4 Albert Astals Cid 2015-02-18 18:37:51 UTC
The currently active window is moved to the first position, yes that's how it's supposed to work, the bug is that the highlight should not move from where it was last time to where it should be now, i.e. let's say you have 5 windows and you select the 4th, now the 4th will be the first, when you do alt+tab the highlight has to go to the 2nd, so it should move from 1st to 2nd position, but instead it moves from 4th to 2nd which is totally counter intuitive
Comment 5 Kai Uwe Broulik 2015-03-08 12:39:10 UTC
Git commit 633a4820aa5ca244ebc39c5672649bbc286aacf2 by Kai Uwe Broulik.
Committed on 08/03/2015 at 12:37.
Pushed by broulik into branch 'master'.

Kill animated highlight in tabbox

It's super annoying and distracting, also makes it consistent with most of Plasma's ListViews.

REVIEW: 122632

M  +2    -1    windowswitchers/IconTabBox.qml
M  +2    -1    windowswitchers/compact/contents/ui/main.qml
M  +2    -1    windowswitchers/informative/contents/ui/main.qml
M  +1    -0    windowswitchers/present_windows/contents/ui/main.qml
M  +2    -1    windowswitchers/text/contents/ui/main.qml
M  +2    -1    windowswitchers/thumbnails/contents/ui/main.qml

http://commits.kde.org/kdeplasma-addons/633a4820aa5ca244ebc39c5672649bbc286aacf2
Comment 6 Albert Astals Cid 2015-05-11 23:02:27 UTC
Kai forgot to close the bug