The buttons at the bottom of the dialog are invisible (for instance "Select File") and even resizing the dialog window doesn't allow to uncover them (see screenshot). This happens on a high DPI screen for which I had to force the fonts DPI to 168. Reproducible: Always Steps to Reproduce: 1. Open the dialog 2. 3.
OK, I see that on your screen-shot, plus some slight clipping of the stage labels on the left. What do you mean by "...... for which I had to force the fonts DPI to 168."? Are you able to use lower DPI? While I look into things, have you tried lower settings? On 120DPI, I see the buttons correctly, and with only very very minor label clipping on the Banking and Investments pages. I've struggled a bit to keep the wizard pages within 800x640, for small-screen users.
Removing hard-coded sizes from the dialogs should help with this. That's a work-in-progress, IIRC
(In reply to Alvaro Soliverez from comment #2) > Removing hard-coded sizes from the dialogs should help with this. That's a > work-in-progress, IIRC Yes, I'd already started, initially with the Banking page, but had to leave off to complete another bug elsewhere. So, I'm back on the case now.
This would fix the problem. diff --git a/kmymoney/plugins/csvimport/csvdialog.ui b/kmymoney/plugins/csvimport/csvdialog.ui index 166b04a..6f3d699 100644 --- a/kmymoney/plugins/csvimport/csvdialog.ui +++ b/kmymoney/plugins/csvimport/csvdialog.ui @@ -10,11 +10,11 @@ <height>640</height> </rect> </property> - <property name="minimumSize"> - <size> - <width>790</width> - <height>420</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="windowTitle"> <string>CSV Import Wizard</string> @@ -23,23 +23,11 @@ <item> <widget class="QFrame" name="frame_main"> <property name="sizePolicy"> - <sizepolicy hsizetype="Preferred" vsizetype="Expanding"> + <sizepolicy hsizetype="Expanding" vsizetype="Expanding"> <horstretch>0</horstretch> <verstretch>0</verstretch> </sizepolicy> </property> - <property name="minimumSize"> - <size> - <width>0</width> - <height>100</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>1900</width> - <height>16777215</height> - </size> - </property> <property name="frameShape"> <enum>QFrame::StyledPanel</enum> </property> @@ -127,7 +115,10 @@ </widget> </item> <item> - <layout class="QHBoxLayout" name="horizontalLayout_low" stretch="1,800,1"> + <layout class="QHBoxLayout" name="horizontalLayout_low"> + <property name="sizeConstraint"> + <enum>QLayout::SetNoConstraint</enum> + </property> <item> <spacer name="horizontalSpacer"> <property name="orientation"> @@ -143,17 +134,11 @@ </item> <item> <widget class="QFrame" name="frame_low"> - <property name="minimumSize"> - <size> - <width>0</width> - <height>260</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>800</width> - <height>265</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="Minimum" vsizetype="Minimum"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="frameShape"> <enum>QFrame::StyledPanel</enum> @@ -179,9 +164,15 @@ </property> <item> <widget class="QFrame" name="frame_stage"> + <property name="sizePolicy"> + <sizepolicy hsizetype="Preferred" vsizetype="Preferred"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="maximumSize"> <size> - <width>110</width> + <width>170</width> <height>16777215</height> </size> </property> @@ -210,14 +201,11 @@ </item> <item> <layout class="QVBoxLayout" name="verticalLayout_stage"> + <property name="sizeConstraint"> + <enum>QLayout::SetDefaultConstraint</enum> + </property> <item> <widget class="QLabel" name="label_intro"> - <property name="minimumSize"> - <size> - <width>90</width> - <height>0</height> - </size> - </property> <property name="text"> <string comment="Noun, the introduction." extracomment="Noun, the introduction.">1. Start</string> </property> @@ -225,12 +213,6 @@ </item> <item> <widget class="QLabel" name="label_separator"> - <property name="minimumSize"> - <size> - <width>90</width> - <height>0</height> - </size> - </property> <property name="text"> <string>2. Separators</string> </property>
Many thanks for that. I've actually nearly finished my work on this, which seems satisfactory, testing up to 360DPI, although using this setting still needs some tweaking. KMM itself is getting a bit unwieldy at this point, too. I'll have a good look at your version, as it may be better than mine. Did you test on the following wizard pages, as I've needed to adjust them, too. Out of interest, what size screen do you have, and what resolution?
The screen is a 15'' laptop screen and the native resolution is 3200x1800. You're right the rest of the wizard dialogs are broken too. I know this is not the best place to post patches but I don't actually quite know how to contribute patches. This patch works even better, tested it from 3200x1800 down to 1280x900 It is only for the csvdialog.ui and the investment wizard, didn't have time to look at the banking yet. diff --git a/kmymoney/plugins/csvimport/csvdialog.ui b/kmymoney/plugins/csvimport/csvdialog.ui index 166b04a..289d2b9 100644 --- a/kmymoney/plugins/csvimport/csvdialog.ui +++ b/kmymoney/plugins/csvimport/csvdialog.ui @@ -10,11 +10,11 @@ <height>640</height> </rect> </property> - <property name="minimumSize"> - <size> - <width>790</width> - <height>420</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="windowTitle"> <string>CSV Import Wizard</string> @@ -23,23 +23,11 @@ <item> <widget class="QFrame" name="frame_main"> <property name="sizePolicy"> - <sizepolicy hsizetype="Preferred" vsizetype="Expanding"> + <sizepolicy hsizetype="Expanding" vsizetype="Expanding"> <horstretch>0</horstretch> <verstretch>0</verstretch> </sizepolicy> </property> - <property name="minimumSize"> - <size> - <width>0</width> - <height>100</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>1900</width> - <height>16777215</height> - </size> - </property> <property name="frameShape"> <enum>QFrame::StyledPanel</enum> </property> @@ -127,178 +115,155 @@ </widget> </item> <item> - <layout class="QHBoxLayout" name="horizontalLayout_low" stretch="1,800,1"> - <item> - <spacer name="horizontalSpacer"> - <property name="orientation"> - <enum>Qt::Horizontal</enum> - </property> - <property name="sizeHint" stdset="0"> - <size> - <width>31</width> - <height>58</height> - </size> - </property> - </spacer> - </item> - <item> - <widget class="QFrame" name="frame_low"> - <property name="minimumSize"> - <size> - <width>0</width> - <height>260</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>800</width> - <height>265</height> - </size> - </property> - <property name="frameShape"> - <enum>QFrame::StyledPanel</enum> - </property> - <property name="frameShadow"> - <enum>QFrame::Raised</enum> - </property> - <layout class="QHBoxLayout" name="horizontalLayout" stretch="0"> - <property name="spacing"> - <number>0</number> - </property> - <property name="leftMargin"> - <number>4</number> - </property> - <property name="topMargin"> - <number>4</number> + <widget class="QFrame" name="frame_low"> + <property name="sizePolicy"> + <sizepolicy hsizetype="Expanding" vsizetype="Expanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> + <property name="frameShape"> + <enum>QFrame::StyledPanel</enum> + </property> + <property name="frameShadow"> + <enum>QFrame::Raised</enum> + </property> + <layout class="QHBoxLayout" name="horizontalLayout" stretch="0,0"> + <property name="spacing"> + <number>0</number> + </property> + <property name="leftMargin"> + <number>4</number> + </property> + <property name="topMargin"> + <number>4</number> + </property> + <property name="rightMargin"> + <number>4</number> + </property> + <property name="bottomMargin"> + <number>2</number> + </property> + <item> + <widget class="QFrame" name="frame_stage"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> - <property name="rightMargin"> - <number>4</number> + <property name="frameShape"> + <enum>QFrame::NoFrame</enum> </property> - <property name="bottomMargin"> - <number>2</number> + <property name="frameShadow"> + <enum>QFrame::Plain</enum> </property> - <item> - <widget class="QFrame" name="frame_stage"> - <property name="maximumSize"> - <size> - <width>110</width> - <height>16777215</height> - </size> - </property> - <property name="frameShape"> - <enum>QFrame::NoFrame</enum> - </property> - <property name="frameShadow"> - <enum>QFrame::Plain</enum> - </property> - <layout class="QVBoxLayout" name="verticalLayout_2" stretch="10,200,50"> - <property name="rightMargin"> - <number>2</number> + <layout class="QVBoxLayout" name="verticalLayout_2" stretch="10,200,50"> + <property name="rightMargin"> + <number>2</number> + </property> + <item> + <spacer name="verticalSpacer"> + <property name="orientation"> + <enum>Qt::Vertical</enum> + </property> + <property name="sizeType"> + <enum>QSizePolicy::MinimumExpanding</enum> + </property> + <property name="sizeHint" stdset="0"> + <size> + <width>20</width> + <height>24</height> + </size> + </property> + </spacer> + </item> + <item> + <layout class="QVBoxLayout" name="verticalLayout_stage"> + <property name="sizeConstraint"> + <enum>QLayout::SetDefaultConstraint</enum> </property> <item> - <spacer name="verticalSpacer"> - <property name="orientation"> - <enum>Qt::Vertical</enum> + <widget class="QLabel" name="label_intro"> + <property name="text"> + <string comment="Noun, the introduction." extracomment="Noun, the introduction.">1. Start</string> </property> - <property name="sizeHint" stdset="0"> - <size> - <width>20</width> - <height>6</height> - </size> + </widget> + </item> + <item> + <widget class="QLabel" name="label_separator"> + <property name="text"> + <string>2. Separators</string> </property> - </spacer> + </widget> </item> <item> - <layout class="QVBoxLayout" name="verticalLayout_stage"> - <item> - <widget class="QLabel" name="label_intro"> - <property name="minimumSize"> - <size> - <width>90</width> - <height>0</height> - </size> - </property> - <property name="text"> - <string comment="Noun, the introduction." extracomment="Noun, the introduction.">1. Start</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="label_separator"> - <property name="minimumSize"> - <size> - <width>90</width> - <height>0</height> - </size> - </property> - <property name="text"> - <string>2. Separators</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="label_banking"> - <property name="text"> - <string>3. Banking</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="label_investing"> - <property name="text"> - <string>4. Investing</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="label_lines"> - <property name="text"> - <string>5. Lines</string> - </property> - </widget> - </item> - <item> - <widget class="QLabel" name="label_finish"> - <property name="text"> - <string comment="Noun, the end." extracomment="Noun, the end.">6. Finish</string> - </property> - </widget> - </item> - </layout> + <widget class="QLabel" name="label_banking"> + <property name="text"> + <string>3. Banking</string> + </property> + </widget> </item> <item> - <spacer name="verticalSpacer_2"> - <property name="orientation"> - <enum>Qt::Vertical</enum> + <widget class="QLabel" name="label_investing"> + <property name="text"> + <string>4. Investing</string> </property> - <property name="sizeHint" stdset="0"> - <size> - <width>20</width> - <height>42</height> - </size> + </widget> + </item> + <item> + <widget class="QLabel" name="label_lines"> + <property name="text"> + <string>5. Lines</string> </property> - </spacer> + </widget> + </item> + <item> + <widget class="QLabel" name="label_finish"> + <property name="text"> + <string comment="Noun, the end." extracomment="Noun, the end.">6. Finish</string> + </property> + </widget> </item> </layout> - </widget> - </item> - </layout> - </widget> - </item> - <item> - <spacer name="horizontalSpacer_2"> - <property name="orientation"> - <enum>Qt::Horizontal</enum> - </property> - <property name="sizeHint" stdset="0"> - <size> - <width>65</width> - <height>68</height> - </size> - </property> - </spacer> - </item> - </layout> + </item> + <item> + <spacer name="verticalSpacer_2"> + <property name="orientation"> + <enum>Qt::Vertical</enum> + </property> + <property name="sizeType"> + <enum>QSizePolicy::Expanding</enum> + </property> + <property name="sizeHint" stdset="0"> + <size> + <width>20</width> + <height>24</height> + </size> + </property> + </spacer> + </item> + </layout> + </widget> + </item> + <item> + <spacer name="horizontalSpacer_3"> + <property name="orientation"> + <enum>Qt::Horizontal</enum> + </property> + <property name="sizeType"> + <enum>QSizePolicy::Expanding</enum> + </property> + <property name="sizeHint" stdset="0"> + <size> + <width>40</width> + <height>20</height> + </size> + </property> + </spacer> + </item> + </layout> + </widget> </item> </layout> </widget> diff --git a/kmymoney/plugins/csvimport/investmentwizardpage.ui b/kmymoney/plugins/csvimport/investmentwizardpage.ui index d3f2857..c86c424 100644 --- a/kmymoney/plugins/csvimport/investmentwizardpage.ui +++ b/kmymoney/plugins/csvimport/investmentwizardpage.ui @@ -6,15 +6,15 @@ <rect> <x>0</x> <y>0</y> - <width>662</width> - <height>266</height> + <width>1068</width> + <height>300</height> </rect> </property> - <property name="minimumSize"> - <size> - <width>0</width> - <height>190</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="maximumSize"> <size> @@ -26,37 +26,43 @@ <string>Investment Wizard Page</string> </property> <layout class="QGridLayout" name="gridLayout_2"> + <property name="sizeConstraint"> + <enum>QLayout::SetNoConstraint</enum> + </property> <item row="0" column="0"> - <layout class="QHBoxLayout" name="horizontalLayout" stretch="1,500,1"> + <layout class="QHBoxLayout" name="horizontalLayout"> + <property name="sizeConstraint"> + <enum>QLayout::SetNoConstraint</enum> + </property> <item> <spacer name="horizontalSpacer"> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> + <property name="sizeType"> + <enum>QSizePolicy::MinimumExpanding</enum> + </property> <property name="sizeHint" stdset="0"> <size> - <width>13</width> + <width>5</width> <height>243</height> </size> </property> </spacer> </item> <item> - <layout class="QVBoxLayout" name="verticalLayout" stretch="10,80"> + <layout class="QVBoxLayout" name="verticalLayout"> + <property name="sizeConstraint"> + <enum>QLayout::SetNoConstraint</enum> + </property> <item> <widget class="QLabel" name="label"> <property name="sizePolicy"> - <sizepolicy hsizetype="Preferred" vsizetype="Fixed"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> <horstretch>0</horstretch> <verstretch>0</verstretch> </sizepolicy> </property> - <property name="maximumSize"> - <size> - <width>16777215</width> - <height>50</height> - </size> - </property> <property name="font"> <font> <weight>75</weight> @@ -74,9 +80,18 @@ Otherwise, select the column for the symbol, and for the description or detail.< </widget> </item> <item> - <layout class="QGridLayout" name="gridLayout" rowstretch="9,9,9,1,9,5,9" columnstretch="23,10,10,10,15,15,20"> + <layout class="QGridLayout" name="gridLayout"> + <property name="sizeConstraint"> + <enum>QLayout::SetNoConstraint</enum> + </property> <item row="4" column="2"> <widget class="QLabel" name="labelInv_detailCol"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="text"> <string>Detail</string> </property> @@ -90,6 +105,12 @@ Otherwise, select the column for the symbol, and for the description or detail.< <property name="enabled"> <bool>true</bool> </property> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="text"> <string comment="column for monetary value">Amount</string> </property> @@ -100,11 +121,11 @@ Otherwise, select the column for the symbol, and for the description or detail.< </item> <item row="1" column="3"> <widget class="KComboBox" name="comboBoxInv_quantityCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Select column containing quantity field.</string> @@ -116,11 +137,11 @@ Otherwise, select the column for the symbol, and for the description or detail.< </item> <item row="2" column="3"> <widget class="KComboBox" name="comboBoxInv_amountCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Select column containing amount field.</string> @@ -132,11 +153,11 @@ Otherwise, select the column for the symbol, and for the description or detail.< </item> <item row="1" column="5"> <widget class="KComboBox" name="comboBoxInv_feeCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center">If necessary, select column containing fee. @@ -150,11 +171,11 @@ incorporated into the price.</span></p></string> </item> <item row="0" column="1"> <widget class="KComboBox" name="comboBoxInv_dateCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Select column containing date field.</string> @@ -169,6 +190,12 @@ incorporated into the price.</span></p></string> <property name="enabled"> <bool>true</bool> </property> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="accessibleName"> <string comment="column containing quantity field"/> </property> @@ -182,6 +209,12 @@ incorporated into the price.</span></p></string> </item> <item row="1" column="4"> <widget class="QLabel" name="labelInv_feeCol"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="accessibleName"> <string comment="column containing fee field"/> </property> @@ -198,11 +231,11 @@ incorporated into the price.</span></p></string> </item> <item row="2" column="1"> <widget class="KComboBox" name="comboBoxInv_memoCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center">Select column containing memo field. More than one column may be entered successively. <br />May also be selected to contain a copy of the type or detail column.</ @@ -214,11 +247,11 @@ incorporated into the price.</span></p></string> </item> <item row="0" column="5"> <widget class="KComboBox" name="comboBoxInv_priceFraction"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center">If necessary, select a fraction/multiplier for compatibility between imported and stored prices. For instance, if the import price is in cents but the file is priced in dol @@ -255,11 +288,11 @@ incorporated into the price.</span></p></string> </item> <item row="0" column="3"> <widget class="KComboBox" name="comboBoxInv_priceCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Select column containing price field.</string> @@ -271,11 +304,11 @@ incorporated into the price.</span></p></string> </item> <item row="5" column="0" colspan="7"> <widget class="Line" name="line_2"> - <property name="minimumSize"> - <size> - <width>620</width> - <height>2</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="Expanding" vsizetype="Expanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="orientation"> <enum>Qt::Horizontal</enum> @@ -284,11 +317,11 @@ incorporated into the price.</span></p></string> </item> <item row="6" column="6"> <widget class="KPushButton" name="buttonInv_hideSecurity"> - <property name="minimumSize"> - <size> - <width>100</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="maximumSize"> <size> @@ -309,6 +342,12 @@ incorporated into the price.</span></p></string> </item> <item row="3" column="0" colspan="6"> <widget class="Line" name="line"> + <property name="sizePolicy"> + <sizepolicy hsizetype="Expanding" vsizetype="Expanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="orientation"> <enum>Qt::Horizontal</enum> </property> @@ -316,6 +355,12 @@ incorporated into the price.</span></p></string> </item> <item row="1" column="0"> <widget class="QLabel" name="labelInv_type"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="accessibleName"> <string comment="column containing investment type/action field"/> </property> @@ -329,11 +374,11 @@ incorporated into the price.</span></p></string> </item> <item row="4" column="5"> <widget class="KLineEdit" name="lineEdit_filter"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="Expanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center">If the Detail column has an activity type prefixed by a standard text, enter the text here. For instance, if a field contains, say,<br/> 'type: dividend', enter 'type @@ -345,11 +390,11 @@ incorporated into the price.</span></p></string> </item> <item row="2" column="6"> <widget class="KPushButton" name="button_clear"> - <property name="minimumSize"> - <size> - <width>100</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Clear selected column entries.</string> @@ -364,17 +409,11 @@ incorporated into the price.</span></p></string> <property name="enabled"> <bool>false</bool> </property> - <property name="minimumSize"> - <size> - <width>0</width> - <height>24</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>375</width> - <height>16777215</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="font"> <font> @@ -401,11 +440,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="4" column="1"> <widget class="KComboBox" name="comboBoxInv_symbolCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center" >If more than one stock is present in the file, and if the stock symbols<br/> are shown in one of the columns, select it here. </p></string> @@ -414,17 +453,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="0" column="4"> <widget class="QLabel" name="labelInv_priceFraction"> - <property name="minimumSize"> - <size> - <width>85</width> - <height>0</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>100</width> - <height>16777215</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="accessibleName"> <string comment="noun, conversion factor to align pricing in the imported file with KMM's internal prices."/> @@ -442,11 +475,11 @@ The names are retained and may be selected from the list here.</p></string <property name="enabled"> <bool>true</bool> </property> - <property name="minimumSize"> - <size> - <width>50</width> - <height>0</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="maximumSize"> <size> @@ -467,6 +500,12 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="4" column="0"> <widget class="QLabel" name="labelInv_symbolCol"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="text"> <string>Symbol</string> </property> @@ -477,11 +516,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="4" column="3"> <widget class="KComboBox" name="comboBoxInv_detailCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string><p align="center" >If a descriptive column contains an activity type, select it here.<br /> See also Filter text field.</p></string> @@ -490,6 +529,12 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="0" column="0"> <widget class="QLabel" name="labelInv_date"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="toolTip"> <string comment="verb, Select column containing date field">Select column containing date field</string> </property> @@ -506,11 +551,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="4" column="4"> <widget class="QLabel" name="labelInv_FilterText"> - <property name="minimumSize"> - <size> - <width>80</width> - <height>0</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="text"> <string>Filter text</string> @@ -522,17 +567,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="6" column="0"> <widget class="QLabel" name="labelInv_security"> - <property name="minimumSize"> - <size> - <width>100</width> - <height>20</height> - </size> - </property> - <property name="maximumSize"> - <size> - <width>115</width> - <height>20</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="accessibleName"> <string comment="name of security"/> @@ -540,13 +579,25 @@ The names are retained and may be selected from the list here.</p></string <property name="text"> <string>or Security Name</string> </property> + <property name="scaledContents"> + <bool>false</bool> + </property> <property name="alignment"> <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> </property> + <property name="wordWrap"> + <bool>true</bool> + </property> </widget> </item> <item row="2" column="0"> <widget class="QLabel" name="labelInv_memo"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="accessibleName"> <string comment="column containing memo field"/> </property> @@ -560,11 +611,11 @@ The names are retained and may be selected from the list here.</p></string </item> <item row="1" column="1"> <widget class="KComboBox" name="comboBoxInv_typeCol"> - <property name="minimumSize"> - <size> - <width>50</width> - <height>24</height> - </size> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> </property> <property name="toolTip"> <string>Select column containing investment type field.</string> @@ -579,6 +630,12 @@ The names are retained and may be selected from the list here.</p></string <property name="enabled"> <bool>false</bool> </property> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> <property name="minimumSize"> <size> <width>0</width> @@ -608,9 +665,12 @@ The names are retained and may be selected from the list here.</p></string <property name="orientation"> <enum>Qt::Horizontal</enum> </property> + <property name="sizeType"> + <enum>QSizePolicy::MinimumExpanding</enum> + </property> <property name="sizeHint" stdset="0"> <size> - <width>13</width> + <width>5</width> <height>243</height> </size> </property>
Thanks again for your work. I had quite a bit of trouble with the formatting of the patch - trailing white space and wide lines being split (that's just for your future information, and not meant as a criticism). Your patch gives much the same result as my own, but both exhibit the same problem. The Investment window is much too wide - fields stretched etc., and I just wanted to confirm whether or not you see that. So far as submitting patches, the best way is via the bug report. Near to the bottom, and below the 'Add Comment' box, there is an attachments link that may be used. Thanks again. Allan
Sorry for dumping the diff directly in the comment stream. The trailing white spaces are introduced by qtcreator... With the patch, at 168 DPI and 3200x1800, the investment windows looks like this: Separators http://i.imgur.com/GOsEAuD.png Default investing dialog (ie without manual resizing) http://i.imgur.com/dAi3SfL.png After manual resizing: http://i.imgur.com/z986jI3.png So yes, you're right the dialog #4, still needs some tweaking so that its height is big enough for the buttons at the bottom.
(In reply to Wood from comment #8) > Sorry for dumping the diff directly in the comment stream. The trailing > white spaces are introduced by qtcreator... In the KMyMoney folder, look for kmymoney/astyle-kmymoney.sh which does all cleaning up like that. Don't do it on live stuff, until you're happy with it. It needs a particular minimum version of astyle. More detail in the script. With the patch, at 168 DPI and > 3200x1800, the investment windows looks like this: > Separators > http://i.imgur.com/GOsEAuD.png > > Default investing dialog (ie without manual resizing) > http://i.imgur.com/dAi3SfL.png > > After manual resizing: > http://i.imgur.com/z986jI3.png > > So yes, you're right the dialog #4, still needs some tweaking so that its > height is big enough for the buttons at the bottom. Don't worry about the tablewidget at the top. It is sized dynamically on a resize event, and takes its height from event.size().height() - wizard frame height. I need to look again as it's been upset by the activity in the wizard frame. > This patch works even better, tested it from 3200x1800 down to 1280x900... My screen is 1920x1024 and the investment window can be way wider than screen width. So my pixels are much bigger than yours. Haven't quite got my head around that yet.... Are you able to try on a different, less modern monitor? <bg> I think everything will be 50% bigger, possibly.
On my system, I have a problem with your investment patch. On DPI 96, the investment page is contained within the screen width, but is too wide, with stretched comboboxes and the intervening space. On 168 DPI, the window overlaps the screen some way, with the Cancel button off screen, and the combos above half missing. There is no scrollbar to retrieve them, so the window has to be moved. With my version, minus your patch, both are OK, with just one label slightly clipped at DPI 216. I'll tweak that when I'm awake. I had to apply minimum widths to the grid layout fields to make the display behave. Whether or not that should be necessary with your patch, I don't know, but a bit more investigation is needed.
If you want, you can push your change on a branch or attach a patch to this bug and I can test it. BTW, this line (csvdialog.cpp:205) m_wizard->setMaximumHeight(m_wizard->sizeHint().height() * 0.8); was also for me source of troubles. For what reason would we want to have the wizard max height being 0.8 of the sizeHint height? The framework should compute sensible values based on the layouts, contents and DPI of the screen.This line is the source of the clipping of the wizard buttons in the investment dialog that you can see here: http://i.imgur.com/dAi3SfL.png
Yes, thanks. I was going to ask about that. That line was not mine and has puzzled me, although not actually causing trouble, but I too have very recently removed it. I'll be in touch in a day or so. Wood <w00dp@mail.com> wrote: >https://bugs.kde.org/show_bug.cgi?id=340656 > >--- Comment #11 from Wood <w00dp@mail.com> --- >If you want, you can push your change on a branch or attach a patch to this bug >and I can test it. > >BTW, this line (csvdialog.cpp:205) > m_wizard->setMaximumHeight(m_wizard->sizeHint().height() * 0.8); > >was also for me source of troubles. For what reason would we want to have the >wizard max height being 0.8 of the sizeHint height? The framework should >compute sensible values based on the layouts, contents and DPI of the >screen.This line is the source of the clipping of the wizard buttons in the >investment dialog that you can see here: http://i.imgur.com/dAi3SfL.png > >-- >You are receiving this mail because: >You are on the CC list for the bug.
Hi, Any news about this? Thanks.
(In reply to Wood from comment #13) > Hi, > > Any news about this? > > Thanks. Sorry about the long delay, but funnily enough I was only thinking about contacting you a few hours ago. I have been having no end of trouble debugging, not specific to your issue, but with the plugin itself. The table widget and the wizard are both contained within the same window, and both may resize dynamically. The end result was that they interacted. Eventually, I decided to bite the bullet and split them into their own window, which I did about a week ago. Everything is now much cleaner and I am just doing some tidying up. If you are still willing, It would be good if you could test the patch before I submit it. Whilst I have it working up to 160 DPI, my monitor is not high density, and the pixels are much larger and I'm not sure how it will look on a genuine HD monitor. I'm assuming that you would have the opposite problem. Allan
This sounds great! Thanks for the update and yes, I will give it a try. Is the change on master or on a different branch, I didn't pull any change in almost a month. Thanks again.
(In reply to Wood from comment #15) > This sounds great! Thanks for the update and yes, I will give it a try. Is > the change on master or on a different branch, I didn't pull any change in > almost a month. > > Thanks again. It's on neither yet, just with me. Depending on what you find, I'll then submit it, all being well. Seven existing ui files have changes, plus there is a new one, so the patch is pretty big. I'll do an update from HEAD before sending it, so you will need to match.
The OP has now kindly tested my patch - " Hi Allan, I managed to test your patch yesterday on a Fedora 20, on a 160 DPI 3200x1800 and the importer works much better, no more hidden buttons or horked dialogs. I didn't notice any quirks but maybe I didn't look attentively enough. Thanks a lot!" BUG:340656 CSV Importer - Add capability to work on high-definition displays. Fix interaction between the import preview table widget and the parameter entry wizard, caused by them both resizing dynamically within the same window. This was achieved by creating a new class and UI for the wizard and transferring most of the existing relevant code out of the large csvdialog.cpp file into the new class and file. - Apologies, especially to Cristian, for the size of this patch. - ( 16 files changed, 4030 insertions(+), 3492 deletions(-) ) However, the net increase in size is only about 500 lines. and it becomes more easily maintainable. So, am I to go via Reviewboard, bearing in mind the size and nature of this change? It's been tested on three different distros and three different screen ratios, but not on Windows.
Git commit 0dc7e903d389c458289a92634f9e346928316173 by Allan Anderson. Committed on 28/03/2015 at 12:40. Pushed by allananderson into branch 'master'. REVIEW:122364 CSV Importer - Fix display on high-definition monitors. Fix interaction between QTable and QWizard in same window. Add a number of edits from Reviewboard. M +2 -0 kmymoney/plugins/csvimport/CMakeLists.txt M +223 -171 kmymoney/plugins/csvimport/bankingwizardpage.ui M +43 -10 kmymoney/plugins/csvimport/completionwizardpage.ui M +441 -2008 kmymoney/plugins/csvimport/csvdialog.cpp M +50 -411 kmymoney/plugins/csvimport/csvdialog.h M +11 -177 kmymoney/plugins/csvimport/csvdialog.ui M +0 -3 kmymoney/plugins/csvimport/csvutil.cpp A +1861 -0 kmymoney/plugins/csvimport/csvwizard.cpp [License: GPL (v2+)] A +442 -0 kmymoney/plugins/csvimport/csvwizard.h [License: GPL (v2+)] A +164 -0 kmymoney/plugins/csvimport/csvwizard.ui M +64 -34 kmymoney/plugins/csvimport/introwizardpage.ui M +21 -20 kmymoney/plugins/csvimport/investmentdlg.cpp M +609 -567 kmymoney/plugins/csvimport/investmentwizardpage.ui M +276 -360 kmymoney/plugins/csvimport/investprocessing.cpp M +2 -9 kmymoney/plugins/csvimport/investprocessing.h M +76 -33 kmymoney/plugins/csvimport/lines-datewizardpage.ui M +1 -1 kmymoney/plugins/csvimport/redefinedlgdecl.ui M +80 -17 kmymoney/plugins/csvimport/separatorwizardpage.ui http://commits.kde.org/kmymoney/0dc7e903d389c458289a92634f9e346928316173
Git commit 34d20dfbc76ac89d3a44cfebc39bdc951dc2326a by Allan Anderson. Committed on 28/03/2015 at 12:40. Pushed by allananderson into branch '4.7'. REVIEW:122364 CSV Importer - Fix display on high-definition monitors. Fix interaction between QTable and QWizard in same window. Add a number of edits from Reviewboard. (cherry picked from commit 0dc7e903d389c458289a92634f9e346928316173) Conflicts: kmymoney/plugins/csvimport/csvdialog.cpp kmymoney/plugins/csvimport/investprocessing.cpp M +2 -0 kmymoney/plugins/csvimport/CMakeLists.txt M +223 -171 kmymoney/plugins/csvimport/bankingwizardpage.ui M +43 -10 kmymoney/plugins/csvimport/completionwizardpage.ui M +441 -2008 kmymoney/plugins/csvimport/csvdialog.cpp M +50 -411 kmymoney/plugins/csvimport/csvdialog.h M +11 -177 kmymoney/plugins/csvimport/csvdialog.ui M +0 -3 kmymoney/plugins/csvimport/csvutil.cpp A +1861 -0 kmymoney/plugins/csvimport/csvwizard.cpp [License: GPL (v2+)] A +442 -0 kmymoney/plugins/csvimport/csvwizard.h [License: GPL (v2+)] A +164 -0 kmymoney/plugins/csvimport/csvwizard.ui M +64 -34 kmymoney/plugins/csvimport/introwizardpage.ui M +21 -20 kmymoney/plugins/csvimport/investmentdlg.cpp M +609 -567 kmymoney/plugins/csvimport/investmentwizardpage.ui M +276 -360 kmymoney/plugins/csvimport/investprocessing.cpp M +2 -9 kmymoney/plugins/csvimport/investprocessing.h M +76 -33 kmymoney/plugins/csvimport/lines-datewizardpage.ui M +1 -1 kmymoney/plugins/csvimport/redefinedlgdecl.ui M +80 -17 kmymoney/plugins/csvimport/separatorwizardpage.ui http://commits.kde.org/kmymoney/34d20dfbc76ac89d3a44cfebc39bdc951dc2326a
Is this compiled into the 4.7.2 version that is in SourceForge? I've installed but have a complex monitor set and the CSV wizard and some blank box show up on the task bar, but I don't seem to have any way to get to it.
(In reply to allison.woolbert from comment #20) > Is this compiled into the 4.7.2 version that is in SourceForge? I've > installed but have a complex monitor set and the CSV wizard and some blank > box show up on the task bar, but I don't seem to have any way to get to it. Yes, it is in 4.7.2. I actually have that installed at the moment and the fix is there. The change was quite large and included the creation for the CSV importer of a new class and UI. If you open a file in KMyMoney and can see the KMyMoney tab in the task bar, just click on it. It should show KMM itself, plus the CSV wizard and CSV importer windows. The latter two UIs are what you would need to be able to see. Are you actually able to see those two windows? They might be super-imposed, depending on their size so you might need to move the top one to see the other. I'm pretty sure I will have downloaded the tarball from sourceforge. Its size is 19.4MB (20,391,472). I've increased my desktop to 160 dpi and the importer appears OK. Let me know how you get on.
(In reply to allan from comment #21) > (In reply to allison.woolbert from comment #20) > > Is this compiled into the 4.7.2 version that is in SourceForge? I've > > installed but have a complex monitor set and the CSV wizard and some blank > > box show up on the task bar, but I don't seem to have any way to get to it. > > Yes, it is in 4.7.2. I actually have that installed at the moment and the > fix is there. > > The change was quite large and included the creation for the CSV importer of > a new class and UI. > If you open a file in KMyMoney and can see the KMyMoney tab in the task bar, > just click on it. It should show KMM itself, plus the CSV wizard and CSV > importer windows. The latter two UIs are what you would need to be able to > see. > > Are you actually able to see those two windows? They might be > super-imposed, depending on their size so you might need to move the top one > to see the other. > > I'm pretty sure I will have downloaded the tarball from sourceforge. Its > size is 19.4MB (20,391,472). > > I've increased my desktop to 160 dpi and the importer appears OK. > > Let me know how you get on. I am able to see them on the task bar, but I can't seem to get them to come to the front. The first window looks completely blank and then the wizard appears. They seem to be dialog boxes, but I can't get to them.
(In reply to allison.woolbert from comment #22) > (In reply to allan from comment #21) > > (In reply to allison.woolbert from comment #20) > > > Is this compiled into the 4.7.2 version that is in SourceForge? I've > > > installed but have a complex monitor set and the CSV wizard and some blank > > > box show up on the task bar, but I don't seem to have any way to get to it. > > > > Yes, it is in 4.7.2. I actually have that installed at the moment and the > > fix is there. > > > > The change was quite large and included the creation for the CSV importer of > > a new class and UI. > > If you open a file in KMyMoney and can see the KMyMoney tab in the task bar, > > just click on it. It should show KMM itself, plus the CSV wizard and CSV > > importer windows. The latter two UIs are what you would need to be able to > > see. > > > > Are you actually able to see those two windows? They might be > > super-imposed, depending on their size so you might need to move the top one > > to see the other. > > > > I'm pretty sure I will have downloaded the tarball from sourceforge. Its > > size is 19.4MB (20,391,472). > > > > I've increased my desktop to 160 dpi and the importer appears OK. > > > > Let me know how you get on. > > I am able to see them on the task bar, but I can't seem to get them to come > to the front. The first window looks completely blank and then the wizard > appears. They seem to be dialog boxes, but I can't get to them. Ok, I've been able to fix this. I have a Matrox TripleHeadToGo Digital and you need to specify the screen where it opens in the Desktop Management Settings. This was definitely unusual for a program not to pop up, but for now it appears solved. THANK YOU!